Rulle_Kebab
Warlord
Cairo is okay for seeing a few of the old areas of town, the Egyptian Museum (which unfortunately is adjacent to Tahrir Square) and the Pyramids (not just Giza), but the air quality, while not thw worst, is still pretty awful. It is also an extremely busy, large and overpopulated city.
The small tourist town of Dahab on the Red Sea is really chill and relaxing though, we found a great restaurant next to our (cheap and slightly rundown but had an excellent, friendly and very helpful manager) hotel-thing, and the nearby Blue Lagoon (iirc) is great for snorkeling.
Luxor was really cool too, the roof of the Morris hotel has an amazing view of the Nile and temples that I'll never forget (and wonderful pool).
Aswan was okay but mostly just because we could see Abu Simbel, load up on gifts and hookahs to take home, and take a felucca down the Nile.
I don't recall seeing many nightclubs or places offering alcoholic beverages in Luxor or Aswan though, in fact I only knew of ONE beer store in Luxor. Also don't stay at Happy Land, the name is deceiving and the management is full of their past good reviews.
Spot on with Dahab. I'm in Dahab every time I go to Egypt(2-3 times a year) and very affordable. The Blue Lagoon is The Blue Hole and yes very nice for snorkeling and diving. But there are many good diving sites in Dahab and its convenient since it is just gearing up and walking out into the water, no need for boats really.
The southern towns are nice and quiet when you are used to Cairo and ther are some nice things to see ofcourse.
Regarding Beer stores, there is more or less a monopoly there. A shop called Drinkies(in the whole of Egypt) thats sells alcoholic beverages. They deliver at some 5 dollar minimum fee and carry both local and foreign brands altho I wont recommend the Local spirits as you never know whats exactly in them. The local beer is nice, mostly Lagers. Best one in my opinion is called Meister Max and is a strong 8% pilsner. All the beers and the monopoly is owned by Heineken.
The egyptian museum is a must if you are into the pharonic stuff for sure and <i would risk going there even tho it is on Tahrir square. The main battle is in the other end of the square(it is pretty big)
For old antiquities there is a big bazaar/market Khan El Khalili, altho a must on the common turist tours and busy(when there is not an ongoing revolution) with turists and big busses, has some nice antique shops if you delve a little deeper inside. There is some really nice architecture in there as well, straight out of 1001 nights.
If you want genuine antiquities you should ahve some good contacts with the government/army/police or even Zahi Hawass himself(whom is widely susppected/known to sell them by the public, hehehe) but will get you a decent amount of time in jail if caught

The old cairo witht he first mosque and the coptic area right next to it is nice to see as well. There is the mausuleum or graveyard part of the city as well which has some magnificent buildings and some very old mosque worth a look. For a dollar or two all mosques and churches are open for you.
Seems you had a nice trip round the country maniacal!