Trouble with the Lock

[tchristensen]

I just added in a new improvement, a lock (or canal). I got everything patched in, and in World Builder I can place the improvement without issue. I have also tried it, and boats can use the Lock as intended.

My issue is that I cannot seem to build it in game, nor does the icon appear when my workers try to build it. Below I have included the appropriate XML and would like someone to see if there is something I am overlooking.

Note: I can see the thumbnail from World Builder and that appears OK too:


<ImprovementInfo>
<Type>IMPROVEMENT_LOCK</Type>
<Description>Canal or Lock</Description>
<Civilopedia>A man made construction allowing ships to move from different bodies of water, often over differing elevations. A lock was often a massive undertaking, not to be taken on lightly.</Civilopedia>
<ArtDefineTag>ART_DEF_IMPROVEMENT_LOCK</ArtDefineTag>
<YieldChanges/>
<bActsAsCity>1</bActsAsCity>
<bHillsMakesValid>0</bHillsMakesValid>
<bFreshWaterMakesValid>0</bFreshWaterMakesValid>
<bRiverSideMakesValid>0</bRiverSideMakesValid>
<bNoFreshWater>0</bNoFreshWater>
<bRequiresFlatlands>0</bRequiresFlatlands>
<bRequiresRiverSide>0</bRequiresRiverSide>
<bRequiresIrrigation>0</bRequiresIrrigation>
<bCarriesIrrigation>0</bCarriesIrrigation>
<bRequiresFeature>0</bRequiresFeature>
<bWater>0</bWater>
<bGoody>0</bGoody>
<bPermanent>0</bPermanent>
<bUseLSystem>1</bUseLSystem>
<iAdvancedStartCost>500</iAdvancedStartCost>
<iAdvancedStartCostIncrease>0</iAdvancedStartCostIncrease>
<iTilesPerGoody>0</iTilesPerGoody>
<iGoodyRange>0</iGoodyRange>
<iFeatureGrowth>0</iFeatureGrowth>
<iUpgradeTime/>
<iAirBombDefense>0</iAirBombDefense>
<iDefenseModifier>0</iDefenseModifier>
<iHappiness>0</iHappiness>
<iPillageGold>0</iPillageGold>
<bOutsideBorders>1</bOutsideBorders>
<TerrainMakesValids>
<TerrainMakesValid>
<TerrainType>TERRAIN_COAST</TerrainType>
<bMakesValid>1</bMakesValid>
</TerrainMakesValid>
<TerrainMakesValid>
<TerrainType>TERRAIN_GRASS</TerrainType>
<bMakesValid>1</bMakesValid>
</TerrainMakesValid>
<TerrainMakesValid>
<TerrainType>TERRAIN_PLAINS</TerrainType>
<bMakesValid>1</bMakesValid>
</TerrainMakesValid>
<TerrainMakesValid>
<TerrainType>TERRAIN_DESERT</TerrainType>
<bMakesValid>1</bMakesValid>
</TerrainMakesValid>
<TerrainMakesValid>
<TerrainType>TERRAIN_MARSH</TerrainType>
<bMakesValid>1</bMakesValid>
</TerrainMakesValid>
</TerrainMakesValids>
<FeatureMakesValids/>
<ImprovementPillage/>
<ImprovementUpgrade/>
<TechYieldChanges/>
<RouteYieldChanges/>
<bGraphicalOnly>0</bGraphicalOnly>
</ImprovementInfo>



<BuildInfo>
<Type>BUILD_LOCK</Type>
<Description>Build a Lock</Description>
<Help/>
<PrereqTech>TECH_ENGINEERING</PrereqTech>
<iTime>1000</iTime>
<iCost>100</iCost>
<bKill>0</bKill>
<ImprovementType>IMPROVEMENT_LOCK</ImprovementType>
<RouteType>NONE</RouteType>
<EntityEvent>ENTITY_EVENT_BUILD</EntityEvent>
<FeatureStructs/>
<HotKey>KB_F</HotKey>
<bAltDown>0</bAltDown>
<bShiftDown>0</bShiftDown>
<bCtrlDown>1</bCtrlDown>
<iHotKeyPriority>0</iHotKeyPriority>
<Button>Art/Interface/Buttons/Buildings/button_lock.dds</Button>
</BuildInfo>


<ImprovementArtInfo>
<Type>ART_DEF_IMPROVEMENT_LOCK</Type>
<bExtraAnimations>0</bExtraAnimations>
<fScale>1.25</fScale>
<fInterfaceScale>1.0</fInterfaceScale>
<NIF>Art/Structures/Buildings/lock/Autobahn.nif</NIF>
<KFM/>
<Button>Art/Interface/Buttons/Buildings/button_lock.dds</Button>
</ImprovementArtInfo>


Any thoughts?

 

[The_J]

Look at the definitions of your worker units: Everything what they can build has to be added to them in the UnitInfos.xml .

 

[tchristensen]

Good idea, but I have this added to each of my various workers:

<Build>
<BuildType>BUILD_LOCK</BuildType>
<bBuild>1</bBuild>
</Build>

Any other suggestions?

 

[NotSoGood]

I see you added a cost for it. Are you sure you had enough money and the required tech?

 

[The_J]

Then recheck, if in your test you really have the needed technology and gold. Edit: Aaaaah...i'm becoming old...

and does the button not appear at all, or is it greyed out?

 

[tchristensen]

I gave myself 5000 gold and the Engineering tech. No soap.

Anyway, I have the thumbnails for the other improvements, even without the requirements -- they are grayed out. So why is it that the Lock is not even appearing on it.

I also moved it to another computer, just thinking that perhaps it was caching weird or something odd like that and all the stuff I added today was there, but not the Lock.

I can go into world builder on the other computer and see the Lock, place the lock, and use the lock but I cant get my workers to build it (they can't see the thumbnail).

Very perplexing!!!!

 

[The_J]

...er...wild guessing: Remove:

<TerrainMakesValid>
<TerrainType>TERRAIN_COAST</TerrainType>
<bMakesValid>1</bMakesValid>
</TerrainMakesValid>

this here. Will not work, so it doesn't hurt, but i guess it could maybe have unexpected side effects.

 

[tchristensen]

I think I am going insane.

So, I try it again. I give myself 2000 gold and I give myself the Engineering Tech -- Now, I can see the icon on the build queue?

Still doesn't explain why I can see my improvement Keep on their, yet I do not have any of the required techs for that?

 

[tchristensen]

OK -- I will remove that. Originally, I had only that because I only wanted to build along a coast but figured that may be causing issues so I had other terrain.

Maybe that was the culprit. I will just remove the coastal terrain requirement.

Thanks for helping me walk through this problem!