[MOD] Version 2.7 release

[Devils_Advocate]

Frigates can carry birds.

Well, that's something, anyway. Is that explained somewhere in the Civilopedia? Failing that, is there some sort of explanation of how hawks work in MNAI, like, anywhere? The restrictions probably wouldn't annoy me if I just knew what they were and maybe the reasoning behind them. I'd probably still dislike some of them, but you can't please everybody. ("Have you met everybody? They're very argumentative.")

It should be happening exactly 20 turns after the deal was made, which is 10 turns after it becomes cancellable.

Ah, that sounds right! I think I remember several deals with various civs being cancelled at once sometimes. And I often make several on the same turn, so that makes sense.

It should show in the event log though.

Quite so. I get a notification but no dialogue from the leader, which always happens normally I think.

It would have been present as far back as the first beta of v2.7, but not in v2.63.

Sounds like you've probably found the source of the problem. Good to hear!

 

[fe79]

Is that explained somewhere in the Civilopedia?

The Sevopedia entry for Frigate says "Cargo Space: 1 (Carries Birds)".
Unfortunately, frigates are made obsolete by the Man o' war in the late game.

is there some sort of explanation of how hawks work in MNAI, like, anywhere?

The behaviour of hawks has changed multiple times. You kind of need to sift through the changelogs to get a full picture, but i can try to summarize.

• Hawks have a limited rebase range.
• Hawks can rebase within your own territory, as well as that of your team members and vassals (and your master's territory, if you yourself are a vassal).
• Hawks can rebase to units capable of carrying birds, even if said unit is outside your territory.

 

[Tholal]

Well, I do. No surprise that commit 2dcc439 is the culprit.

The patch may look intimidatingly large, but almost all of it is just fixing bad indentation.

I'm having trouble seeing the bugfix within all the indentation changes. Can you show me where the issue was that was causing the AI to cancel deals?

 

[fe79]

I'm having trouble seeing the bugfix within all the indentation changes.

The bugfix is essentially just an indentation change.

Can you show me where the issue was that was causing the AI to cancel deals?

Look at the function CvPlayerAI::AI_doDiplo in CvPlayerAI.cpp.
Find the part that looks like

if (bCancelDeal)
{
    [...]
}
bool bEmbassyCanceled = pLoopDeal->isEmbassy();
pLoopDeal->kill();
if (bEmbassyCanceled)
{
    [...]
}

It needs to be

if (bCancelDeal)
{
    [...]
    bool bEmbassyCanceled = pLoopDeal->isEmbassy();
    pLoopDeal->kill();
    if (bEmbassyCanceled)
    {
        [...]
    }
}

Beware that you cannot assume that any of the braces are correctly aligned.

 

[Terkhen]

I love how Python deals with whitespace

 

[Broken Hawk]

Thank you Tholal. Appreciate your hard work.

 

[keldath]

hello tholal,

does ffh2 + more naval ai works in mp game?

 

[Tholal]

does ffh2 + more naval ai works in mp game?

From what I have heard, yes it does. I believe all of the known OOS errors have been resolved as well.

 

[keldath]

ok thank you

 

[ciruela]

Thanks for keep maintain your mod!
Is there a changed file list from V2.6.3 to V2.7?
so I can update my mod manually

 

[Terkhen]

You can get a list of changed files by using Mercurial on the code repository (https://bitbucket.org/Tholal/more-naval-ai/) and comparing the 2.6.3 revision with the 2.7 revision. If you are tired of doing merges manually, it might be worth the effort of learning how to use version control systems; that way Mercurial would take care of everything that can be merged automatically.

 

[ciruela]

You can get a list of changed files by using Mercurial on the code repository (https://bitbucket.org/Tholal/more-naval-ai/) and comparing the 2.6.3 revision with the 2.7 revision. If you are tired of doing merges manually, it might be worth the effort of learning how to use version control systems; that way Mercurial would take care of everything that can be merged automatically.

Thanks, I'll try this.

 

[Bungle]

Hey Tholal,

It seems your installer doesn't work on my computer. Might be related to my Windows 10 OS, or the fact that I'm running the GOG version of Civ4.

The problem is that the "Install" button is grayed out, no matter which path I select. The normal FFH installer works fine. I had to download the repository, compile the DLL and manually patch my game

I couldn't find the source for the installer.. if you do make it available I'm sure I could figure it out on my own

 

[Sezren]

Hey Tholal,

It seems your installer doesn't work on my computer. Might be related to my Windows 10 OS, or the fact that I'm running the GOG version of Civ4.

The problem is that the "Install" button is grayed out, no matter which path I select. The normal FFH installer works fine. I had to download the repository, compile the DLL and manually patch my game

I couldn't find the source for the installer.. if you do make it available I'm sure I could figure it out on my own

For those who cant use installer: You can use 7zip to extract the files and manually move/write/overwrite them. Requires some tech skills but much less than compiling the DLL. Havent tested if the result works for 2.7 (and probably wont anytime soon) though.

Good to know that the GOG version works with MNAI 2.7 otherwise.

 

[Bungle]

Wow, I did not know that :-D Way easier than compiling, haha. Can confirm that the mod works perfectly with the GOG version.

 

[Bad Player]

From what I have heard, yes it does. I believe all of the known OOS errors have been resolved as well.

:O That's pretty huge!

 

[swapoer]

This is a life saver. It really annoy me when the open border are cancelled every 10 or 20 turns and I have to wait a few more turn to renegotiate the term.

Well, I do. No surprise that commit 2dcc439 is the culprit.

The patch may look intimidatingly large, but almost all of it is just fixing bad indentation.

 

[swapoer]

Well, I do. No surprise that commit 2dcc439 is the culprit.

The patch may look intimidatingly large, but almost all of it is just fixing bad indentation.

Hallo, could you tell me how to install the patch?

 

[fe79]

Hallo, could you tell me how to install the patch?

Since it involves changes in the C++ source code, you would need to apply said changes to the source (either through something like git-apply, or by following these instructions) and then compile the DLL yourself (possibly by following these instructions).

If recompiling the DLL is outside your skill-set, you will have to wait for someone else to do it. Presumably, a version 2.71 will be released at some point.

Alternatively, you could go back to version 2.63 (which does not have this particular bug), although that has its own set of slightly annoying bugs.

 

[swapoer]

Since it involves changes in the C++ source code, you would need to apply said changes to the source (either through something like git-apply, or by following these instructions) and then compile the DLL yourself (possibly by following these instructions).

If recompiling the DLL is outside your skill-set, you will have to wait for someone else to do it. Presumably, a version 2.71 will be released at some point.

Alternatively, you could go back to version 2.63 (which does not have this particular bug), although that has its own set of slightly annoying bugs.

Thanks for your timely reply.
I have a look at the instructions and found it to be too complicated for my ability.
I suppose I would take your advice and wait for a new update.