3UC/4UC for VP: Project Coordination Thread

adan_eslavo · Jan 14, 2018

I changed Iron Chariot's model and flag, but model is not working for me now and I need to find why.
- @pineappledan Where did you get from this art and model. I need to put it to Credits.
- Ok, this file has textures for Iron Chariot inside. That;s why it is not working.

Code:

<Asset>
    <Mesh file="Chariot_Babylon.gr2" />
    <Animation file="egyptianwarchariot_md_idle.gr2" ec="1000, 1020, 1450, 1800, 2000, 2020" />
    <Animation file="egyptianwarchariot_md_run.gr2" ec="1120, 1140, 1400, 1440, 2440, 1460, 1480" />
    <Animation file="egyptianwarchariot_md_fidget.gr2" ec="1040, 2040" />
    <Animation file="egyptianwarchariot_md_fortifya.gr2" ec="1500" />
    <Animation file="egyptianwarchariot_md_fortifya_idle.gr2" ec="1520, 1540, 1560, 1580, 1600, 1620, 1640, 1285, 1290" />
    <Animation file="egyptianwarchariot_md_strikea.gr2" ec="1100, 1160, 1180, 2100" />
    <Animation file="egyptianwarchariot_md_diea.gr2" ec="1200, 2200" />
    <Animation file="egyptianwarchariot_md_diea_fade.gr2" ec="1220, 2220" />
    <Animation file="egyptianwarchariot_md_hurta.gr2" ec="1280" />
    <Texture file="Unit_Environment_Dull.dds"/>
    <Texture file="Unit_Environment_Sharp.dds"/>
    <Texture file="Unit_Irradiance.dds"/>
    <BoneUsage>
        <Bone name="point_WORLD"/>
    </BoneUsage>
    <TimedTrigger file="FX_Triggers_Chariot_Civ4.ftsxml"/>
    <AnimGraph file="IDLE_OFFSET_CONTINUE_TRUE_GRAPH.dge"/>
    <AnimGraph file="SHUFFLE_STOP_GRAPH.dge"/>
    <AnimGraph file="FORTIFY_FIDGET_GRAPH.dge"/>
    <AnimGraph file="MELEE_ATTACKS.dge"/>
    <AnimGraph file="MOUNTED_RUNNING_LOOP.dge"/>
    <AnimGraph file="ENTER_FORTIFY.dge"/>
    <AnimGraph file="LEAVE_BOMBARD_DEFEND_TRANS_IDLE_A_GRAPH.dge"/>
    <AnimGraph file="DEATH_FINAL_GRAPH.dge"/>
    <AnimGraph file="BOMBARD_DEFEND_LOOP_GRAPH.dge"/>
    <AnimGraph file="ENTER_BOMBARD_DEFEND_GRAPH.dge"/>
    <AnimGraph file="DEATH_GRAPH.dge"/>
    <AnimGraph file="LEAVE_COMBAT_READY.dge"/>
    <AnimGraph file="ENTER_COMBAT_READY_GRAPH.dge"/>
    <AnimGraph file="FORTIFY_LEAVE_GRAPH.dge"/>
    <AnimGraph file="COMBAT_READY_GRAPH.dge"/>
    <AnimGraph file="FORTIFY_GRAPH.dge"/>
    <AnimGraph file="TRANSITIONS_FOR_IDLES.dge"/>
    <AnimGraph file="STOP_RUNNING.dge"/>
    <AnimGraph file="IDLE_GRAPH.dge"/>
    <AnimGraph file="FIDGETS_GRAPH.dge"/>
    <AnimGraph file="RUN_CHARGE_SHUFFLE_LOOP.dge"/>
    <AnimGraph file="RUN_CHARGE_SHUFFLE_TO_SHUFFLE_RUN_CHARGE.dge"/>
    <AnimGraph file="ATTACK_CITY_TO_RUN_CHARGE_SHUFFLE.dge"/>
    <AnimGraph file="ATTACK_TO_RUN_CHARGE_SHUFFLE.dge"/>
    <AnimGraph file="START_RUN_CHARGE_SHUFFLE.dge"/>
    <StateMachine file="1_OMNI_MOUNTED_STATE_01.fsmxml"/>
</Asset>

What is the difference between border growth bonus for Ranch written in lua by BG and sql table ready function "Building_YieldFromBorderGrowth"?
Picture of material for flax would be nice even without changes I think.
SV icon for flax is ready, but the rest shouldn't have that black border look at figs - there's complete package of art I need
22px flax icon needs to be contrasted.
Madrasah lacks 25% Science on Citizent Birth and I cannot find proper table... Found and added...
!Added 3 civs from BG to my main post.

pineappledan · Jan 14, 2018

adan_eslavo said:
@pineappledan Where did you get from this art and model. I need to put it to Credits.

It is a modified version of the hittite chariot found in the 7-wonders DLC. Modified by Civitar. I pulled it from Mikeburnfire's 4UC project, and it may have been slightly modified by him as well. If you are having trouble making it work, you could try re-downloading it here

adan_eslavo · Jan 14, 2018

Do you know hot modify this .nb2 file to files we need?

Pushed v23.3 to github.

Hinin · Jan 14, 2018

So, my game crashed when I tried to make a Corsair appear through the IGE... I'll retry to see the effects/models/flags of all the UMs tomorrow. For now, I've only read all the civilopedia entries of the new/modified UCs and the promotions linked to them. I've quite a lot of things to say.

The comments about the civilopedia aren't a form of criticism, simply statements (I know how much work it is, and simply wanted to signal "unperfect", if this word exists in English, pages and unit descriptions).

Spoiler A lot of things to say :

Have a good day !

Blue Ghost · Jan 14, 2018

I submitted a merge request for the text rework. I thought I submitted it last night, but it looks like it didn't go through. Will need to be more careful about making sure submissions go through from now on.

Looks like some things got broken with the merge. I'll try to pick up the pieces.

IcyAngel · Jan 14, 2018

Can confirm that the Celts UA change for faith per city to remain on founding doesn't work:

Spoiler :

Blue Ghost · Jan 14, 2018

Okay, so there are a lot of issues currently, and I'm not sure how we're going to handle them. @adan_eslavo, I see that you added new art assets for Arabia and Assyria, so I won't try to restore the ones I had before. Can you tell me what needs to be done on my end for the cleanup, so we don't overlap our efforts? I’d like to get the merged mod in working order before continuing with more UCs.

pineappledan · Jan 14, 2018

I'll address the parts of Hinin's review that involve me:

Spoiler :

Hinin said:
Greece :
- Klepht : The Game Info of the civilopedia doesn't say the unit has less CP than the Gatling gun

The Klepht civilopedia does make reference to the unit being less powerful. I don't think a change is needed

Hinin said:
Rome :
-Ballista : There is no Game Info and no Strategy part in the civilopedia article

This is best dealt with in SQL as an update to the unit's text. I haven't dealt with these yet

Hinin said:
Celts :
- Scythed Chariot : The quote at the end of the Historical Info part of the civilopedia article needs to be better presented with some guillemets

I don't know if this is necessary. There are no quotes in normal civilopedia entries, so we have no precedent for how these should be formatted

Hinin said:
Persia :
- Qizilbash : In the Historical Info part of the civilopedia, there is no explanation for the "Safavi Agitator" promotion + the Strategy part of the unit needs to emphazise the use of the "SAgitator" promotion (helps create new units through faith purchase + triggers more GA => strengthen the unit)

I will do this.

Hinin said:
- Paradise Garden : No game Info/No Strategy/No Historical Info

Oops!

Hinin said:
England :
- Longbowman : No Game Info/No strategy

See Ballista

Hinin said:
Iroquois :
- Sachem's Council : If we read the attributes of the building, it provides 3 Papers and not 2 as its Game Info says + There is no mention of the faith/food from CS friends/allies (normally the bonus of the NW it replaces)

Is it 2 paper or 3? the changelog on page 6 of the forum says 3 paper.
I will add the Food/Faith on CS ally to text

Hinin said:
Spain :
- Armada : The Armada, which is supposed to be "a slow but terrifying opponent at sea", has 1 less CP than the Dutch Sea Beggar, costs a lot more than it and has 1 less MP... I know that, at full strength and a lvl 0, the Armada has 50 base CP and the Sea Beggar 42, but still...

*shrug* it's still pretty damn scary.

Hinin said:
France :
- SPAD S.VII : No civilopedia (not even the paragraphs appear)
- Grande Ecole : The Civilopedia article lacks some icons and effect description

SPAD - entries have been written. sounds like a compiling error
GE - Perhaps an old version was compiled? I'm looking at the code now and it doesn't appear to have anything missing

Hinin said:
Maya :
- Ball Court : The Civilopedia article needs some rework (in the Strategy part)

noted. I added bullet points so it is more consistent with the Conquistadors strategy section

Hinin said:
Siam :
- Armstrong Gun : Shouldn't the unit be renamed Seir Morb (since the Armstrong Gun is the name of the weapon, and is American...) to give a bit of "Siamese flavor" ?

I don't know. If we go for an anglicized version we could call it the Crouching Tiger cannon instead, or just Seir Morb in both cases

Hinin said:
- Elephant Camp : No mention of the bonus Pr/Go to forest of the Workshop it replaces

I have abandoned the idea of Pr/Go on the lumber camps. It's too many yields on the same tiles for 1 building (4 total)

Hinin said:
- Wat : the civilopedia attributes of the UB says that the unit stops the spy actions we wanted, but the building still gives +1 culture to forest/jungle

See Ballista re. text
@adan_eslavo The culture needs to be removed.

Hinin said:
Ottoman :
- Great Turkish Bombard : the unit had three "Bonus vs cities" promotion, two "+100 % CS" and one "+150 % CS". If we want a "+350 % CS against cities", shouldn't we simply give the unit a "Great Bombard" promotion (+350 % CS against cities) ? + the Game Info/Strategy parts don't talk about the fact that the unit hurts itself when attacking

I agree. There are 2 promotions doing 1 job

Hinin said:
- Tersane : shouldn't the building give a maximum of +25 % pr to melee ships (same as Runestone) ? + the building is really really powerful (bonus production to sea + bonus production to melee ships + "prize ships" to all melee ships) : I'll do some tests to see how it performs ingame. +(the bonus production in the civilopedia attributes of the UB gives two separated cases (+1 Fo/Pr to Coast ; +1 Fo/Pr to Ocean), while the ones of the Harbor says '+1 Food to Sea' : maybe it could be simpler to do like for the Harbor ?)

If I am reading the code correctly, Harbour gives 15% for all naval military units
Tersane gives 30% for naval MELEE units, but not ranged
WRT runestone, combines with harbor, the runestone gives 40% to melee and 15% to ranged. The runestone is far stronger in this regard.

Hinin said:
Byzantium : Dromon : Game Info is absent

This was working in prior versions; something must have compiled wrong

Hinin said:
Netherlands :
- Goedendag : the Strategy part of the civilopedia article says that the unit is less effective as the Pikeman against mounted units, but the unit has now the same amount of CP and the "+50 % CS against mounted unit" promotion, so this part of the civilopedia article should be reworked a bit (+ the bonus of the "Goedendag !" promotion should be tweaked a bit to replace the "+50 % CS against mounted units" promotion in a unique way, maybe "+10 % CS and +20 % CS against mounted units to all adjacent units" (the problem being that adjacent archers would benefit from a bonus similar to the "Agincourt" promotion of the Longbowman when attacking mounted units...) => We need to talk about this unit again)

I thought that the anti-mounted was removed from the unit.
I don't think the overlap with Agincourt is much of an issue.

Hinin said:
- Waag : No civilopedia (not even the paragraphs appear)

Waag entries have been written. sounds like a compiling error

Bug report @Blue Ghost - I just re-loaded my playthrough with Aztecs and was given unending free policies. The need to keep unlocking free policies prevented me from actually playing another turn, as I ran out of policies to pick

Blue Ghost · Jan 14, 2018

pineappledan said:
Bug report @Blue Ghost - I just re-loaded my playthrough with Aztecs and was given unending free policies. The need to keep unlocking free policies prevented me from actually playing another turn, as I ran out of policies to pick

... Huh. I honestly have no idea how that can happen. Do you know what caused this?

For all our testers and developers, can we please submit any bugs we find on Github? That would help immensely in tracking what needs to be done. Thanks.

adan_eslavo · Jan 14, 2018

@Blue Ghost You need to pull full version from master. When I get back from work I will merge your part and send another request (or maybe you will need to do that but from master to your branch. It's syncing.

What I can tell, UCs that was previously CS units have their text updated in SQL. For now they are empty. I will move them to main xml after all merge stuff with BG.

Rest is strange. Maybe it's matter of some mistake at the end of text but rather no wrong link. It would be good if you post all issues on github, every missing text, period or crash. Guys, especially @Hinin (you had tge most bugs), try to separate every little bug to different github thread (no text, different text, wrong bonus, balance issue etc.) Try to not mix them in one.

Wat shouldn't have bonuses but it needs to be checked. With such amount of errors it is hard to track all if we dont have list.

So I will get all text stuff and wat and icons and continue cleaning the code. I will not touch lua for now.

@Blue Ghost repair luas and this crash on corsair. Thats priority for now. You can probably do this without sync. If not wait for my merge few hours.

@IcyAngel Please check vanilla VP. I used ready table for Celts. Didn't change anything. But I will also check that. Post on github.

@pineappledan you can make those icons and civilopedia and strategy reworks @Hinin asked. I will take rest (help and no text issues, rest of bugs.

Good day.

pineappledan · Jan 14, 2018

New text entries for Legion, Ballista, Wat and Longbowman. I will add these to their respective units' SQL code on GitHub

Code:

UPDATE Language_en_US 
SET Text = 'Unique Roman replacement for the Catapult. This Unit is stronger than the Catapult, has no vision penalties, and has no penalty against land Units. When near a Great General, has double movement in open terrain in enemy territory.'
WHERE Tag = 'TXT_KEY_UNIT_HELP_BALLISTA' AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='COMMUNITY_CORE_BALANCE_UNITS' AND Value= 1 );

UPDATE Language_en_US 
SET Text = 'The Ballista is a potent replacement for the Catapult, with few of the drawbacks of a normal Siege unit. When near a Great General the Ballista can move freely in unhindering terrain, even in enemy territory. Use these war machines in conjunction with your Legions to expand quickly and consolidate your early empire. The power and flexibility of the Ballista may allow your army to ignore producing Composite Bowmen entirely.'
WHERE Tag = 'TXT_KEY_UNIT_ROMAN_BALLISTA_STRATEGY' AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='COMMUNITY_CORE_BALANCE_UNITS' AND Value= 1 );

UPDATE Language_en_US
SET Text = 'The Legion is the Roman unique unit, replacing the Swordsman. The Legion is more powerful than the Swordsman, making it the one of the most powerful melee units of the Classical Era. The Legion can also construct roads and forts. When near a Great General, the Legion constructs improvements faster.'
WHERE Tag = 'TXT_KEY_UNIT_ROMAN_LEGION_STRATEGY' AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='COMMUNITY_CORE_BALANCE_UNITS' AND Value= 1 );

UPDATE Language_en_US 
SET Text = 'Unique ranged unit of the English civilization. Replaces the Crossbowman. Begins with the [COLOR_POSITIVE_TEXT]Range[ENDCOLOR] and [COLOR_POSITIVE_TEXT]Agincourt[ENDCOLOR] Promotions, giving increased attack range and a bonus against Mounted units.'
WHERE Tag = 'TXT_KEY_UNIT_HELP_LONGBOWMAN' AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='COMMUNITY_CORE_BALANCE_UNITS' AND Value= 1 );

UPDATE Language_en_US 
SET Text = ' The Longbowman has a greater range than the Crossbowman, allowing it to attack enemies three hexes away, often destroying them before they can strike back. Longbows also are more effective against Mounted opponents, thanks to their Agincourt Promotion. Like other ranged units, Longbowmen are vulnerable to melee attack.'
WHERE Tag = 'TXT_KEY_UNIT_ENGLISH_LONGBOWMAN_STRATEGY' AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='COMMUNITY_CORE_BALANCE_UNITS' AND Value= 1 );

UPDATE Language_en_US
SET Text = 'Reduces enemy spy stealing rate by 50%, and prevents the disruption of Building and Wonder construction by Spy Advanced Actions, and enemy Spies cannot cause Unrest in the City. +2 [ICON_RESEARCH] Science from Temples and Shrines in this City, and reduces [ICON_HAPPINESS_3] Crime.'
WHERE Tag = 'TXT_KEY_BUILDING_WAT_HELP' AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='COMMUNITY_CORE_BALANCE_LEADERS' AND Value= 1 );

pineappledan · Jan 15, 2018

Blue Ghost said:
... Huh. I honestly have no idea how that can happen. Do you know what caused this?

For all our testers and developers, can we please submit any bugs we find on Github? That would help immensely in tracking what needs to be done. Thanks.

Regardless, it was an old version, before all of this merging. I have no idea how I managed to do that and I suspect it is something on my end

adan_eslavo said:
@pineappledan you can make those icons and civilopedia and strategy reworks @Hinin asked. I will take rest (help and no text issues, rest of bugs.

I have dealt with Hinin's text issues w.r.t. our civs. Would you and @Blue Ghost like me to take a look at BG's, rewrite them, and try to integrate them into the larger text file?

Flax Icons attached:

Spoiler :

adan_eslavo · Jan 15, 2018

BG is working on integrating his text files. I need to merge his work. You can then rewrite them. Can you also move those sql text (with hakkapeliitta, mission, conquistador, mehal sefari, dromon, polder, atatlist, grocer, caravansary and carolean and others I forgot to move or add (check my main post)) to this NewText.xml?

Send merge request as soon as possible so I could accept it after work.

Blue Ghost · Jan 15, 2018

@pineappledan You can take care of any Civilopedia issues after the merge goes through.

I have no idea what could be causing the Corsair crash... Guess I'll do some trial and error to try to figure it out.

pineappledan · Jan 15, 2018

adan_eslavo said:
BG is working on integrating his text files. I need to merge his work. You can then rewrite them. Can you also move those sql text (with hakkapeliitta, mission, conquistador, mehal sefari, dromon and carolean and others I forgot (check my main post)) to this NewText.xml?

I don't know th syntax for updating text using xml. Should I start a new .sql text file instead?

adan_eslavo said:
Send merge request as soon as possible so I could accept it after work.

the sql text changes are already implemented; I don't need forks as a contributor

Blue Ghost · Jan 15, 2018

pineappledan said:
I don't know th syntax for updating text using xml. Should I start a new .sql text file instead?
the sql text changes are already implemented; I don't need forks as a contributor

Just follow the example in the existing XML text file.

adan_eslavo · Jan 15, 2018

Write in google xml civ 5 synthax and there are examples. It is easy.

I didn't know that. So you can make changes to master?

Example adds text and we need update. Syntax is different.

Blue Ghost · Jan 15, 2018

Okay, I pushed a new change on my branch that should fix the CTD. So that should be resolved once my branch is merged.

adan_eslavo · Jan 15, 2018

Line
"AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='COMMUNITY_CORE_BALANCE_UNITS' AND Value= 1 );"
Is not needed because our mod has set dependency from 5 parts of vp and this needed when someone plays only community patch (1st).

BG part merged.

You guys are working ants. I will have nothing to do this afternoon
I will do rest of cleanups then, put flax and look into first 3 civ's luas.
What about ranch.lua I asked earlier? Is it needed now?
How about reworking Monitor.lua according to my previous suggestions? Code is almost ready.
What about monitors sv icon?

@pineappledan look here

Blue Ghost · Jan 15, 2018

For the ranch, YieldFromBorderGrowth only looks at natural border growth. I want the ranch to trigger on buying tiles as well, for synergy with America’s UA.

I can rework the Monitor, yes.

The Monitor is lifted directly from the Civil War scenario. Its not having a SV icon would be an oversight of the scenario. Nevertheless, we’ll need one. @pineappledan, can you get an SV for the Monitor?

3UC/4UC for VP: Project Coordination Thread

Archmage of all Pixels

Deity

Archmage of all Pixels

Emperor

King

Prince

King

Deity

King

Archmage of all Pixels

Deity

Deity

Attachments

Archmage of all Pixels

King

Deity

King

Archmage of all Pixels

King

Archmage of all Pixels

King

Similar threads