BUG Charts

[Cammagno]

Thanks EF. Re your comments ...

1. what? the graphs should remember how you left it
2. good point - more consistent - F9 info screen was coded by someone different from other screens so the method of yellow is slightly different - but I can worth with their method
3. nawww - I like top left - and less chance of actually covering a graph line that way
4. that shouldn't happen - lines use leader colors - will look at it. The order is based on the player ID - just loops thru them and draws the lines in that order
5. good point - will look at it
6. IFAIK, panels aren't not clickable - I did try it.

Great!

I add one little (at least, I hope it's little) request:
the Select All/None 'button' can be splitted? Two buttons are better, both because if I have some lines selected, with 2 buttons I can select or deselect all (as I wish) with only one click, and because as it is, in the localized versions the text goes out of the legend panel (not terrible, of course, but ugly)

 

[EmperorFool]

what? the graphs should remember how you left it

When I reopen the window, the leaders' lines I had deselected are visible again. And the dropdown in the top right switches back to "Entire History". Are you saying you save those and it should work? I thought you just saved which graph you were viewing.

nawww - I like top left - and less chance of actually covering a graph line that way

No no, not the titles on each graph in the all-graphs view. I'm talking about the titles across the top in the single-graph view. Once you change it so the current graph remains in the list, it won't look so odd and you can ignore this.

that shouldn't happen - lines use leader colors - will look at it. The order is based on the player ID - just loops thru them and draws the lines in that order

That's what I assumed. But if you look closely at a graph while de/selecting a leader, you'll see that some lines get shifted in the order they are drawn, unless that's just my bad eyes.

IFAIK, panels aren't not clickable - I did try it.

Bummer, oh well.

You could create a one-pixel 100% transparent image and stretched it over the graph, but I'm not sure that would work. If it did, it would mean you wouldn't have to make each part clickable -- just the single overlay DDS.

 

[ruff_hi]

1) will check what is remembered and what isn't
2) i like top left on big graph too
3) bad eyes!
4) interesting - that was my preference too - will try it

 

[EmperorFool]

2) i like top left on big graph too

I agree, but that's still not what I'm talking about.

When you are viewing a single graph, the titles of all graphs are listed across the top of the screen. Each one is drawn using CvUtil.FONT_LEFT_JUSTIFY. I'm suggesting drawing them using CvUtil.FONT_CENTER_JUSTIFY to look more balanced.

3) bad eyes!

Nope, I just checked again. There is a definite difference. I'll post a screenshot if you like, but there's nothing you can do about it so I won't unless you ask.

I'm guessing that you can't fix it because I'm seeing that the lines for two leaders overlap each other at different points. Meaning that sections of Ragnar cover up Lincoln and vice versa, and which sections do which change depending on whether or not Hannibal is selected.

It's probably something weird in Civ's UI code that does it. I'm thinking that elements at the same Z depth are probably drawn by Civ in alphabetical order -- rather than in the order in which they were added to the screen -- or something equally unavoidable by us.

But it's not my eyes, damnit!

 

[ruff_hi]

and I will center those suckers. Might need to move the layout around a little.

screenshot pls!

 

[EmperorFool]

Okay, prepare to have your mind blown!

Compare Ragnar's (purple) and Lincoln's (blue) lines in the red circles. Notice that in the left shot Ragnar is on top, and in the right Lincoln is on top. The only difference is that I deselected Kahn.

 

[EmperorFool]

and I will center those suckers. Might need to move the layout around a little.

If you wanna go nuts, you could measure the width of each one and evenly distribute them across the top.

 

[ruff_hi]

1. Remember all settings: add selected leaders and time frame selection.
2. Show all graph names across top in single-graph view. Best to avoid disappearing/moving elements in UI. Bold/yellow the one being viewed. Could drop title from corner of graph if done this way but not necessary.
3. Center the graph titles across top instead of left-align.
4. Selecting leaders results in drawing the lines in different orders, so lines shift in front/behind each other. Not a big deal, but I'm a perfectionist. Why is the draw order be changed?
5. Horizontally size legend so leader names fit inside the box. You can use CyInterface.determineWidth(string) for this.
6. Allow click on the graph itself (or just the background) to switch to single-graph view.

I'm still floored. Great work!

1. now remembers selected leaders - forgot about time frame - will take a look
2. done - click on the yellow one on the top or the title (top left on graph) to return to 7-in-1
3. done
4. noticed that in one of my games too now - just a quirk
5. maybe - will look at it (later)
6. maybe - will look at it (later)

 

[Cammagno]

deleted...

 

[mystyfly]

This looks like another great feature. Just a small request: Could you change the german version of the "Power" chart to be called "Armee", "Militär", "Macht" or similar instead of "Elektrizität" which is just slightly misleading...

 

[The Doc]

This looks like another great feature. Just a small request: Could you change the german version of the "Power" chart to be called "Armee", "Militär", "Macht" or similar instead of "Elektrizität" which is just slightly misleading...

Sure. I'll add it to the XML. I think, the Italian and Spanish translation are wrong aswell, so it's not only a problem of the German localization.

Edit: Committed.

 

[ruff_hi]

Note that I didn't change those sorts of translations - they are BtS Vanilla.

 

[The Doc]

Note that I didn't change those sorts of translations - they are BtS Vanilla.

Sure, they are. But they are totally wrong. "Elektrizität" means "electricity" or "electrical power" and has nothing to do with the power that is referred to in the context of those graphs. So, why not fix it.
EF has added a fix for the spy icon. It's just a fix for a minor flaw of the original game. Nothing dramatic or gameplay-changing.

 

[ruff_hi]

Q: What do these power numbers / graphs represent? They are a combination of points from techs, units, buildings and other(??). Some part of it represents the ability to enforce (units) while other parts represent the ability to create (units / buildings).

 

[Sam_Yeager]

Q: What do these power numbers / graphs represent? They are a combination of points from techs, units, buildings and other(??). Some part of it represents the ability to enforce (units) while other parts represent the ability to create (units / buildings).

This might help.

 

[EmperorFool]

Q: What do these power numbers / graphs represent? They are a combination of points from techs, units, buildings and other(??). Some part of it represents the ability to enforce (units) while other parts represent the ability to create (units / buildings).

If you're arguing that "electric power" is a good description of this, I have to disagree. If you're merely asking, then ya the link Sam_Yeager gave is quite helpful. This explains why the AI builds SAM Infantry way too much.

 

[ruff_hi]

I'm just saying - don't call it 'unit count', or 'army size' or something like that. Power, or the ability to project power is fine.

 

[EmperorFool]

I'm just saying - don't call it 'unit count', or 'army size' or something like that. Power, or the ability to project power is fine.

Yes, I absolutely agree with that.

 

[ruff_hi]

Checking the BUG Graphs option on Advisors tab replaces the default Graphs (F9) with BUG Graphs. The main differences between the BUG Graphs and the default Graphs are:

• 2 Graph views
  • 7-in-1 view showing all 7 graphs at once (6 if the 'No Espionage' option is checked)
  • Large single graph showing the selected item with graph tabs across the top of the page
• You can swap between the two views by clicking a small graph title (shows the large graph for that graph), clicking the large graph title (returns to 7-in-1 view) or clicking on the large graph title in the title list across the top of the screen (returns to 7-in-1 view)
• You can show different graphs when in large graph mode by clicking on the appropriate item from the list across the top of the screen
• Each graph includes a title in the top left corner
• The legend has various modifications
  • Each leader's line can be excluded or included (click on leader name to toggle between the two)
  • 'Show All' and 'Show None' options included, click on them to show all leader lines or show no leader lines
  • Legend auto sizes horizontally with a minimum default width
  • Legend is locked to top left corner on large graphs and bottom left corner on 7-in-1 view
  • Leader name, Leader Civilization or both can be shown in the Legend depending on the user selection for this option under the scoreboard
• Graph type drop down removed
• Graph time period drop down moved to top right of screen - the ability to scroll back and forth when you have changed the time period is still active.

 

[Dresden]

Finally gotten a chance to play with this in-game and it's great. I love being able to see all the charts at once.

One thing I noticed is that under debug mode, you still only see the graphs of those players who you've spent enough EP on to see their graphs "normally." I think it'd be useful when debugging to have access to the full graphs so what about making the following addition? (quote starts at line 608)

					if (	iDemographicsMission == -1 or
							self.pActivePlayer.canDoEspionageMission(iDemographicsMission, iLoopPlayer, None, -1) or
							iEndGame != 0 or
							iLoopPlayerTeam == CyGame().getActiveTeam()):

to

					if (	iDemographicsMission == -1 or
							self.pActivePlayer.canDoEspionageMission(iDemographicsMission, iLoopPlayer, None, -1) or
							iEndGame != 0 or
							[COLOR="Green"]CyGame().isDebugMode() or[/COLOR]
							iLoopPlayerTeam == CyGame().getActiveTeam()):