Bug Reporting

[Cammagno]

I mentioned that earlier. EF should have fixed it some revisions ago (I think it was 1281).

I know, but they are still there

I guess, some of the PLE options are only available in the INI files.

I thought so, but it's a bit strange to have the vertical offset of the hover pannel in the BOS and not the checkbox to enable the PLE hover pannel... probably there is a reason. though.

 

[EmperorFool]

I know, but they are still there

Really? Okay, I'll check again. They should be working. Of course, they should have been working before, but they had the wrong XML key (my fault), so maybe I didn't fix it correctly.

This is why I nag people to test before they commit.

It's a bit strange to have the vertical offset of the hover pannel in the BOS and not the checkbox to enable the PLE hover pannel... probably there is a reason. though.

I want to be able to use the regular Civ hover pane by turning off the checkbox, but I can't get it to work. I have hopes that in the future I'll figure out what the problem is and fix it, so I left in the code and translations. They're in SVN, so I can simply remove them if you wish and recover them later. It's more there for a reminder to me whenever I edit that file.

 

[Cammagno]

I know, but they are still there

Really? Okay, I'll check again. They should be working. Of course, they should have been working before, but they had the wrong XML key (my fault), so maybe I didn't fix it correctly.

This is why I nag people to test before they commit.

Can it be related with this other (and worst) bug?
http://forums.civfanatics.com/showpost.php?p=7239971&postcount=918

I want to be able to use the regular Civ hover pane by turning off the checkbox, but I can't get it to work. I have hopes that in the future I'll figure out what the problem is and fix it, so I left in the code and translations. They're in SVN, so I can simply remove them if you wish and recover them later. It's more there for a reminder to me whenever I edit that file.

No no, leave them where they are, I was just curious, now everything is clear

 

[EmperorFool]

No no, leave them where they are, I was just curious, now everything is clear

Okay, cool. Oh, and I forgot to address the options that fully work but aren't on the BOS D): PLE Hover X and Y and Text Lineheights. I left them off the screen because most users won't fiddle with them and the way Civ draws the input box is really wide.

I'm afraid of cluttering the screens too much. There are already far too many options for most users that I'm afraid people open the screen and immediately close it because it's overwhelming. Maybe I'm underestimating our users?

Alerum is working to create layouts for a simplified set of options so we can have "Simple" and "Advanced" views of the BOS. This would allow us to add all the options yet have a streamlined view for new users.

 

[EmperorFool]

Okay, I've cleaned up the options.

• The labels are working (and verified!) on the Alerts tab.
• Added hover text about overriding column spacing and some missing codes on Scores tab. I put the English text where missing into German and French; it looked like Italian was complete. Please compare these against the English and fix or tell me where I'm missing something (like the column spacing, oopsies).
• Changed some defaults to line up with BUG Mod.ini. e.g. show the clock in NJAGC. I must have made some copy-paste errors early in the Core rewrite because I was using regexp to translate Python to XML later on.
• Logging is on but Silent Start is off. This results in nothing happening unless the user starts the log themselves.

Please let me know if any default option values should be changed. I have tried to make it so all options are enabled by default so players will see that something is different and hopefully go to the BOS to change settings.

The only one that is off by default is Unit Naming, and I don't like that myself. Should we turn it on?

 

[Cammagno]

Okay, I've cleaned up the options.

• The labels are working (and verified!) on the Alerts tab.

• 
  
  Good ^_^
  There is still "Main interface" one in General tab"
  (TXT_KEY_BUG_OPTLABEL_MAIN_INTERFACE in XML)
  
  

  Please let me know if any default option values should be changed. I have tried to make it so all options are enabled by default so players will see that something is different and hopefully go to the BOS to change settings.

  
  PLE tab, Wounded Dot should be on
  (TXT_KEY_BUG_OPT_PLE__WOUNDED_INDICATOR_TEXT)
  
  

  [*]Logging is on but Silent Start is off. This results in nothing happening unless the user starts the log themselves.

  
  Uhm... what about logging by default? It's a pity to loose some logging because one forgot to start it, while I don't see any problem if somebody logs some turn before remembering to shut it off.
  And speaking of this, can the start-log-shortcut be enabled to pause and restart logging even when Autostart (Silent Start died some time ago, killed by a conspiracy of translators ) is on? I think I put a feature request about this on SF, but I'm not sure
  
  

  The only one that is off by default is Unit Naming, and I don't like that myself. Should we turn it on?

  
  Yes!
  (and maybe with a better default convention?
  Something like ^ut^ ^cntu[n]^ of ^ct^)

 

[EmperorFool]

There is still "Main interface" one in General tab"
(TXT_KEY_BUG_OPTLABEL_MAIN_INTERFACE in XML)

Fixed: TXT_KEY_BUG_OPTLABEL_MAININTERFACE.

PLE tab, Wounded Dot should be on
(TXT_KEY_BUG_OPT_PLE__WOUNDED_INDICATOR_TEXT)

It's on by default. Is this not working for you? I'm pretty sure it is for me (will test again).

<option id="Wounded_Indicator" key="Wounded Indicator" 
		type="boolean" [B]default="True" [/B]
		get="isShowWoundedIndicator" dirtyBit="PlotListButtons"/>

Uhm... what about logging by default? It's a pity to loose some logging because one forgot to start it, while I don't see any problem if somebody logs some turn before remembering to shut it off.

I'm thinking that most players won't ever log, so I wanted to avoid filling up a bunch of Autolog files that will never get used. Those that do log regularly would turn on Autostart. I don't mind turning Autostart on by default, though.

I was also thinking that when Logging is enabled but not logging (not started) we should have a flashing message on-screen. How often do you pause logging -- should it be majorly in your face or do you pause often enough that you want it perhaps where the flashing end-turn text goes normally?

And speaking of this, can the start-log-shortcut be enabled to pause and restart logging even when Autostart is on?

Yes, that should be fine. I assumed it was like that already.

Something like ^ut^ ^cntu[n]^ of ^ct^)

Done.

 

[EmperorFool]

Can the start-log-shortcut be enabled to pause and restart logging even when Autostart is on?

When Autostart is on, ALT + L starts logging only without confirmation or asking for a file name. This is due to its previous purpose: Silent Start. So there's no way to stop logging if Autostart is on.

Changing this so ALT + L would always stop logging would be an easy fix I think. Is this sufficient?

 

[Cammagno]

When Autostart is on, ALT + L starts logging only without confirmation or asking for a file name. This is due to its previous purpose: Silent Start. So there's no way to stop logging if Autostart is on.

Changing this so ALT + L would always stop logging would be an easy fix I think. Is this sufficient?

Sorry, I fear I didn't understood you

From a user point of view, when autostart is on, ALT+L does nothing, while when autostart is out, ALT+L starts and stops logging.

My request was to have a shortcut (I sayd ALT+L, but even another one is ok) acting as a Pause key (when autolog is on, because when autolog is out ALT+M already acts in that way, eve if it ask for a name); I mean: stop logging if it is on, start again if it is out (without promting for a name, using the Autostart name); if it is impossible to use the same shortcut for stopping and for restarting, even two different ones are ok.
If it is not possible at all, make as if I didn't ask

 

[EmperorFool]

I think you just described what I said.

Right now if Autostart is off (BTW, the opposite of "on" is "off", not "out") ALT + L starts logging without asking for a filename. You can't tell because there's no feedback.

I agree that ALT + L should do start/stop (which acts like pause unless there's some difference you can think of) all the time.

If Autostart is on, Autolog starts logging when the game is started/loaded. It should have no effect on ALT + L.

You should only be asked for a filename if Default File Name is off.

I see no reason to confirm that you actually want to start logging when you hit ALT + L. As long as there is a message saying that logging is now ON or OFF, that should be enough. If you didn't mean to start it, just stop it.

 

[Cammagno]

Fixed: TXT_KEY_BUG_OPTLABEL_MAININTERFACE.

Thanks!

It's on by default. Is this not working for you? I'm pretty sure it is for me (will test again).

Sorry, my mistake.
I saw it off, but probably I clicked on it without realizing, because when I checked again with a fresh install it was on.

I'm thinking that most players won't ever log, so I wanted to avoid filling up a bunch of Autolog files that will never get used. Those that do log regularly would turn on Autostart. I don't mind turning Autostart on by default, though.

Well, not a bunch of autolog files, only one, but an increasing one, you are right.
Ok, I think you are right, and probably not all the player are stupid like me, who almost always forget to put it on and loose some turns in the log

I was also thinking that when Logging is enabled but not logging (not started) we should have a flashing message on-screen. How often do you pause logging -- should it be majorly in your face or do you pause often enough that you want it perhaps where the flashing end-turn text goes normally?

Well, considering that I never looked at that text in my life...
What about a reminder?

 

[Cammagno]

I think you just described what I said.

Right now if Autostart is off (BTW, the opposite of "on" is "off", not "out")

I knew this one!
"out" is the opposite of "in"
I made a mistake, but I knew!

ALT + L starts logging without asking for a filename. You can't tell because there's no feedback.

I agree that ALT + L should do start/stop (which acts like pause unless there's some difference you can think of) all the time.

If Autostart is on, Autolog starts logging when the game is started/loaded. It should have no effect on ALT + L.

You should only be asked for a filename if Default File Name is off.

I see no reason to confirm that you actually want to start logging when you hit ALT + L. As long as there is a message saying that logging is now ON or OFF, that should be enough. If you didn't mean to start it, just stop it.

I fully agree with you, it will be perfect.

 

[EmperorFool]

Well, considering that I never looked at that text in my life...
What about a reminder?

But when would the reminder pop up? When you start/load a game with Autolog on but Autostart off? What about when you stop logging while playing? I can't think of a reason to pause logging like this, but you mentioned wanting to be able to.

It seems a message on-screen all the time would be more difficult to ignore (and miss) than a popup. Can you give me an example of when you would pause logging but keep playing, intending to start logging again? It helps me to have a concrete example.

 

[Cammagno]

But when would the reminder pop up? When you start/load a game with Autolog on but Autostart off?

Yes.

What about when you stop logging while playing?

If I pause the logging, or it is for a short try and so I'm able to remember doing so or if I pause it for a longer time I can set a reminder manually, selecting an appropriate number of turns.

I can't think of a reason to pause logging like this, but you mentioned wanting to be able to.

Oh, for each try I want to do...
A couple of examples:
'cheating': I want to see what happens taking a particular decision instead of another one (not everybody using autolog use it for SG, I've never played a SG but I've always used Autolog, because I like to have an html log of all my games)
'testing': I want to test something (for BUG, but not only for BUG) without messing up my log file
Eeach time you load you get some crap lines that later you have to delete, and even more important, editing the log manually is not so easy, because it's a bit difficult to say where is the separating line between the events happened in the real part of the turn and those happened in the test part of it. Of course there are workarounds for these problems (for example for the last one I can add a customized note saying "delete from here"), but the possibility to pause the game will be the perfect solution, and anyway I think that a logger, generally speaking, shoud have a pause key, like any recorder . But clearly it's not a priority, so if it requires hard work leave it as it is, I'll cope with it when I'll be an experienced python coder

It seems a message on-screen all the time would be more difficult to ignore (and miss) than a popup.

Yeah, but you know, there is always something not interesting written there, I think nobody looks at it... maybe if it has a different color.

 

[EmperorFool]

Okay, so you definitely want a different pause capability that doesn't put in the "log started on ..." header, right? I think this could be done easily by never "closing" the log file but rather only pausing it.

So, when a game is started or loaded, the header is added when the log is started. After that, the header is never added and ALT + L becomes pause rather than start. There is no stop because stopping doesn't really do anything other than pause.

And I see the reason for an alert on start/load game for sure. I was thinking of the flashing text at the bottom of the screen for when the logging is paused.

 

[Cammagno]

Okay, so you definitely want a different pause capability that doesn't put in the "log started on ..." header, right? I think this could be done easily by never "closing" the log file but rather only pausing it.

So, when a game is started or loaded, the header is added when the log is started. After that, the header is never added and ALT + L becomes pause rather than start. There is no stop because stopping doesn't really do anything other than pause.

And I see the reason for an alert on start/load game for sure. I was thinking of the flashing text at the bottom of the screen for when the logging is paused.

It will be perfect

 

[ripple01]

Again, not strictly a bug, but something that would be nice to have fixed, IMO. See the attached screenshot: When highlighting an air unit in the SevoPedia, the Range stat goes outside of the box with the Strength, Moves, and Cost. Anyway to rearrange that info in the top box so it all fits?

This is from my mod, but I believe the error would affect stock BUG as well.

Cheers,
ripple01

 

[EmperorFool]

When highlighting an air unit in the SevoPedia, the Range stat goes outside of the box with the Strength, Moves, and Cost.

One easy solution is to drop the "MOVEMENT: 1" line since it's 1 for all Air units.

As well, the Unit Categories table for Air units shows Movement instead of Range. I can change this here as well.

Question: Do any mods/Promotions give any Air units more than 1 Movement Point? Note: Gunship is not an Air unit.

 

[Caesium]

Found a little bug.

Traceback (most recent call last):

  File "CvScreensInterface", line 917, in handleInput (note, this line is from my mod)

  File "CvBUGMilitaryAdvisor", line 1205, in handleInput (note, this line is from bug mod)

AttributeError: CvMilitaryAdvisor instance has no attribute 'SitRepGrid'
ERR: Python function handleInput failed, module CvScreensInterface

 

[EmperorFool]

AttributeError: CvMilitaryAdvisor instance has no attribute 'SitRepGrid'

Oops. I've committed a fix. Please give it a try.