Bug Reporting

[Caesium]

As reported earlier there is a bug in the MainInterface, when pointing on an air unit:

I get python exceptions when selecting air units (Airships at least).

Something about airCurrCombatStr being called with different C++ signature (in CvMainInterface.py).

This has to do with the unit info pane... I found the call, in line 1835

fCurrStrength = float(pUnit.airCurrCombatStr()*0.01)

if you change that to

fCurrStrength = float(pUnit.airBaseCombatStr())*float(1.0-pUnit.getDamage()*0.01)

and also replace airMaxCombatStr by airBaseCombatStr in the next line (and remove the *0.01), it should work.

Best Regards,
Ace

So I looked into the normal code that displays strength for air units, and it is using getBaseAirCombat(). I didn't want to switch to the method used for land units without investigating. Therefore, while the above code works, it may differ from the game's display.

I'll copy the code used by the regular game to fix this problem correctly. I have some outstanding changes to my CvMainInterface.py that are causing a small delay, but I hope to do that tonight.

Is Ace Of Spade's code correct or are you going to release another code?


----------

Here's a new one:

  File "CvMainInterface", line 1163, in tempMove

ArgumentError: Python argument types in
    CyUnit.setXY(CyUnit, int, int)
did not match C++ signature:
    setXY(class CyUnit {lvalue}, int, int, bool, bool, bool)
ERR: Python function handleInput failed, module CvScreensInterface[/quote]

The shown bug's line is the same as in your svn.
Could you please give me a solution for this one?

The posted autolog bugs were related to Revolution Mod.
But these two bugs above are still in the MainInterface.py and I'm still interested in getting rid of them.

 

[Dresden]

Website bug

This page: http://civ4bug.sourceforge.net/BUGMod.html says the following next to the download link for version 3:

The BUG Mod for Beyond the Sword version 3.13

This has caused at least one person to think BUG isn't yet compatible with 3.17. I'd suggest changing that to "3.13+" like the download page says or even a more explicit "3.13 - 3.17"

 

[Milly]

Ah, I can do this at a later time perhaps, but if you can post the Python exception you're getting, I might be able to make a quick fix sooner (won't have to install the mod).

1. Turn on the logging system (maybe you already have it) and turn off python exception popups (probably aready off)
2. Run the game and open the Military Advisor
3. Quit the game
4. Open Logs\PythonErr.log (not the one with a "2" in it)
5. Post the entire contents in a [ code ] ... [ /code ] block (# button above post editor)

I'm quite sure that logging is on... but there's no PythonErr.log file after I look at the military adviser screen. Just PythonErr2.log. :/

 

[EmperorFool]

I'm quite sure that logging is on... but there's no PythonErr.log file after I look at the military adviser screen. Just PythonErr2.log. :/

That's strange. Can you turn on python exception popups and try again? If you still don't see anything, I'm at a total loss. If there's no Python error, and no DLL error (crash to desktop), it means there's a Python logic problem that is making it decide not to draw anything.

Can you post a screenshot of the MA?

 

[ruff_hi]

our mod code is now included in the HOF mod ...

 

[Milly]

That's strange. Can you turn on python exception popups and try again? If you still don't see anything, I'm at a total loss. If there's no Python error, and no DLL error (crash to desktop), it means there's a Python logic problem that is making it decide not to draw anything.

Can you post a screenshot of the MA?

I have no clue how to turn on Python exception pop-ups.

I do, however, have a screenshot! Despite what it says, I'm in the sit-rep part. Deployment is perfect.

 

[Cybah]

is this hall of fame error already known? (original BUG mod, newest revision from SVN)

 

[nadszyszkownik]

I have a problem with civics screen with BTS 3.17, BUG 3.0, it looks like this:

what could be the problem?

 

[ruff_hi]

I'm pretty sure that BUG hasn't touched the civics screen. Don't think it is BUG.

 

[Cybah]

there is a foreign advisor bug:

as you can see here, I'm at war with pacal:

but the foreign advisor tells me, there is no war:

also, when I go to pacal on the scoreboard with my mouse, there is no "at war with Cybah, Mansa Musa" even no "at war with Mansa Musa"

 

[EmperorFool]

@Milly - Can you post your saved game so I can debug it? It looks like it's a Python error since the screen isn't drawing completely (left DEPLOYMENT highlighted for starters).

@Cybah - The code for the victory screen is . . . interesting. I'll have to rewrite this in the future. Do you happen to have the replay that would have been drawn in the list first? If so, could you post it please? Are you running BUG's HoF screen or one from another mod?

I notice that you are running a different Foreign Advisor from what BUG uses. BUG's FA modifies only the Glance tab. As well, BUG does not touch the SDK, and the hover info you mention is provided by the SDK. I would inspect whatever mods you have merged with BUG.

@nadszyszkownik - As Ruff said, BUG doesn't touch the civics screen. Have you merged any other mods into BUG?

 

[Dresden]

This is an odd post. It's a bug report for something that probably shouldn't be fixed...

The Foreign Advisor uses the LeaderType to display the favorite civic on the Info tab. However, if you are playing with random personalities, the true favorite civic would come from the PersonalityType. So in this case it's usually displaying the wrong favorite civic.

But, knowing the favorite civic immediately is really spoiler information since part of the fun of random personalities is in not knowing how the other nations will react. So I guess I just wanted to note that this bug exists and throw my support for ignoring it.

Although a reasonable alternative would be to check for the Random Personalities option (assuming you can) and put in a placeholder like a big question mark icon or simply not display the favorite civic then.

 

[EmperorFool]

Although a reasonable alternative would be to check for the Random Personalities option (assuming you can) and put in a placeholder like a big question mark icon or simply not display the favorite civic then.

I like this. It is certainly better than displaying false information as happens now.

Even better would be to change it to the actual civic once the user has seen the information. For example, if you switch to Bureaucracy and suddenly get a +1 diplomatic bonus from Monty, you know that's his favorite civic (and will be all game). Unfortunately, the game doesn't give any sort of event for this.

We could check the diplo modifiers every time the player changes civics (and the AIs too, if my memory is correct that they must be running it as well to get the modifier). This would be quite easy, save for detecting the actual diplo modifier entry given that they aren't available programmatically.

 

[Cybah]

@Cybah - The code for the victory screen is . . . interesting. I'll have to rewrite this in the future. Do you happen to have the replay that would have been drawn in the list first? If so, could you post it please? Are you running BUG's HoF screen or one from another mod?

HoF is not working in your original version (without any merges/other mods) either. Just try it out from the main menue.

I notice that you are running a different Foreign Advisor from what BUG uses. BUG's FA modifies only the Glance tab. As well, BUG does not touch the SDK, and the hover info you mention is provided by the SDK. I would inspect whatever mods you have merged with BUG.

hm okay maybe this results from the revolution mod merge. I will try to ignore the revolution code for the FA. but this can also be a bug of 3.17... will test this too.

 

[EmperorFool]

HoF is not working in your original version (without any merges/other mods) either. Just try it out from the main menue.

That's just it -- HoF works fine for me. Perhaps the Revolution mod creates replays that confuse the new HoF code. Without a replay, though, I can't begin to guess what's wrong.

 

[Milly]

@Milly - Can you post your saved game so I can debug it? It looks like it's a Python error since the screen isn't drawing completely (left DEPLOYMENT highlighted for starters).

Um. Well. I posted it before... I tried to make a new game using worldbuilder and without my mod so you could check it out.

But BUG works perfectly fine with just BtS. It was my mod causing the problems, unfortunately. :/ I'm guessing it's the custom DLL that's the problem.

Sorry to have bugged you all these days!

 

[EmperorFool]

Sorry to have bugged you all these days!

No worries.

Once we get a FAQ put up (eventually), I'll make sure to note that anyone reporting a bug that is using a modified version of BUG should start by testing their broken saved game in stock BUG to verify that it is BUG that is the problem.

 

[Cybah]

That's just it -- HoF works fine for me. Perhaps the Revolution mod creates replays that confuse the new HoF code. Without a replay, though, I can't begin to guess what's wrong.

is there a chance to clear the HoF ?

 

[EmperorFool]

is there a chance to clear the HoF ?

There's a Replays folder inside "My Games\BTS". I assume you can simply delete them all, but I haven't played with this part of Civ before. Ruff might know.

 

[·Imhotep·]

There's a Replays folder inside "My Games\BTS". I assume you can simply delete them all, but I haven't played with this part of Civ before. Ruff might know.

This is how it works, EF is correct as always .