Bug Reports and Discussion

Azhral · Feb 9, 2015

Hey Guys

Found a weird and interesting bug last night. Not too sure exactly what was going on, but a Clan city with no culture but a large garrison was being beseiged by the Amurites who had a Hill Giant (event one based on the empty pasture I saw) and Loki was 1 tile away from said city. Had the dreaded infinite 'Waiting on Civilizations' on the interturn, until I went back and killed off Loki with the Worldbuilder, then everything was fine. Wasn't the Clans last city, but it did appear that the Amurites would capture it on the next turn. Unsure of the diplomatic status of either side with the Balseraphs however.

Can go back and find an Autosave with the issue (maybe) if you care enough to investigate further.

On another note, does anybody know where I can find the code that doubles the Khazad cultural defense bonus? Can't seem to find it myself. Would it be in the DLL or somewhere in the Python?

Edit: Ignore the "I can provide a save" bit. Changed a bunch of stuff and now I can't load that game or any saves associated with it. Immediate CTD, and the error logs are as unhelpful as always. Pity, was an awesome game and I spent a good hour regenerating till everything looked good. Thought all I changed was just XML, but then I was pretty drunk...

Tholal · Feb 10, 2015

Azhral said:
Can go back and find an Autosave with the issue (maybe) if you care enough to investigate further.

Yes, I would appreciate savegames for any infinite hangs or crashing issues. Thought I had taken care of all of them.

On another note, does anybody know where I can find the code that doubles the Khazad cultural defense bonus?

Never heard of it.

Thought all I changed was just XML, but then I was pretty drunk...

XML changes are the easiest way to break savegames. All it takes is adding or removing one entry.

fe79 · Feb 11, 2015

Revision 1780 broke the Heal spell. Very easy to fix though.

Qgqqqqq · Feb 11, 2015

On another note, does anybody know where I can find the code that doubles the Khazad cultural defense bonus? Can't seem to find it myself. Would it be in the DLL or somewhere in the Python?

As Tholal said, this isn't a thing. What you're likely thinking of is the +20% to all cities the Khazad get through their palace (which will likely be in the building entry).

Azhral · Feb 11, 2015

Qgqqqqq said:
As Tholal said, this isn't a thing. What you're likely thinking of is the +20% to all cities the Khazad get through their palace (which will likely be in the building entry).

Ahh, yeah that's probably it. Cheers.

Terkhen · Feb 12, 2015

While using r1784 merged with a development version of ExtraModMod, the assert on line 13360 of CvPlayerAI.cpp was triggered. Since the Sidar are present in the game and recently a new UNITAI type for shades was added, I suspect that the switch including the triggered assert is missing a new case for this UNITAI type.

Tholal · Feb 13, 2015

fe79 said:
Revision 1780 broke the Heal spell. Very easy to fix though.

Terkhen said:
the assert on line 13360 of CvPlayerAI.cpp was triggered.

Fixed and fixed. Thanks to you both!

Terkhen · Feb 14, 2015

Hello again:

I have been analyzing More Naval AI code with some static analysis tools in order to detect any possible issues. I have used cppcheck to analyze the CvGameCoreDll code. A list of the most serious issues can be found below, but besides those the tool has found a lot of variables (more than 200) that are assigned but never used. I'm hesitant to tackle those because some have notes in the style of "do something with this in the future", while others seem to have been used in the past but BTS_BETTER_AI or MNAI improvements commented their usage out. The compiler is likely to remove most of those variables anyways.

The method CvCity::getRevIndexHappinessVal apparently does a lot of things, but in the end it just returns zero.
In line 1260 of CvCityAI, iFreeSeaExperience is never used, but the other two are. Seems like something is missing.
In CvCityAI::AI_updateBestBuild, some calculations are done with iWorkedFood and iWorkableFood, but the calculated values are never used.
In CvCityAI::AI_getYieldMultipliers, some calculations are done with iWorkableFood and iWorkableFoodPlotCount, but the calculated values are never used.
In CvCityAI::AI_getImprovementValue, a value is calculated for bHasBonusImprovement but it is never used.
In line 6787 of CvGameTextMgr, BuildTypes eBestBuild is calculated but never used.
There is a duplicated condition in CvGameTextMgr:arseFreeSpecialistHelp: (!szYield.isEmpty() || !szYield.isEmpty())
In line 17742 of CvPlayerAI, there is a bitwise operator (bFirstPass | bWantSwitch) that definitely looks like as if it should be an or operator.
A break is missing in line 4106 of CvPlayerAI.
In CvPlayerAI, all lines from 6055 to 6087 can be removed as they only set values to variables that are never used.
In CvPlayerAI::AI_magicCombatValue, iSpellBonus is calculated but never used.
On line 3867 of CvSelectionGroup, bSentryAlert is initialized but never used.
On line 1528 of CvUnitAI there is a bitwise operator (!bHero & !isAlive()) that probably should be an and operator.
On line 11017 of CvUnitAI, the following condition is duplicated: "(eUnitAI == UNITAI_ATTACK_SEA) ||". "(eUnitAI == UNITAI_RESERVE_SEA) ||" is duplicated too.

Sarmatian · Feb 15, 2015

I've tried playing MNAI, downloaded 2.61 (6mb or so), installed it and launched when prompted after installation finished.

It all started normally, I've set up a custom game and hit play - after some loading, the game crashed to desktop. There was no actual crash, there was just a black screen for a moment and then I've landed to desktop.

Any idea what might be the reason?

Korak · Feb 15, 2015

Not sure this is a bug, but I'm getting tech that I didn't research. At times during a game, I receive notice of gaining a tech that I wasn't chasing. When I trade tech, I notice that I have gained bulbs on techs my opponents have, but I haven't researched. Something in the game is researching these techs for me.

fe79 · Feb 16, 2015

Sarmatian said:
I've tried playing MNAI, downloaded 2.61 (6mb or so), installed it and launched when prompted after installation finished.

It all started normally, I've set up a custom game and hit play - after some loading, the game crashed to desktop. There was no actual crash, there was just a black screen for a moment and then I've landed to desktop.

Any idea what might be the reason?

Let's check the simple stuff first:

Did you install FFH2, and the media pack, and the patch before installing MNAI?

Have you installed Blue Marble? That can cause problems together with some video card drivers, especially if you have the map grid-lines option enabled in-game.

Terkhen · Feb 16, 2015

Korak said:
Not sure this is a bug, but I'm getting tech that I didn't research. At times during a game, I receive notice of gaining a tech that I wasn't chasing. When I trade tech, I notice that I have gained bulbs on techs my opponents have, but I haven't researched. Something in the game is researching these techs for me.

Tech diffusion (enabled by the game option advanced tactics) does that.

Sarmatian · Feb 16, 2015

fe79 said:
Let's check the simple stuff first:

Did you install FFH2, and the media pack, and the patch before installing MNAI?

Have you installed Blue Marble? That can cause problems together with some video card drivers, especially if you have the map grid-lines option enabled in-game.

Yep.

1) FFH2
2) patch (latest from ffh2 thread)
3) media pack

and blue marble...

Could blue marble be the problem?

Tholal · Feb 16, 2015

Sarmatian said:
Could blue marble be the problem?

Yes. That's the issue.

Something about Blue Marble causes a crash. I believe you can install Blue Marble last and it will work.

Sarmatian · Feb 16, 2015

Tholal said:
Yes. That's the issue.

Something about Blue Marble causes a crash. I believe you can install Blue Marble last and it will work.

Thanks!

Is there a way to just uninstall blue marble, or do I have to uninstall everything (vanilla CIV/BtS included) and do everything all over again?

fe79 · Feb 17, 2015

Sarmatian said:
Is there a way to just uninstall blue marble, or do I have to uninstall everything (vanilla CIV/BtS included) and do everything all over again?

The Blue Marble installer has an "Uninstall all" option that you can try.

Korak · Feb 17, 2015

Thanks Terkhen.

Sarmatian · Feb 17, 2015

fe79 said:
The Blue Marble installer has an "Uninstall all" option that you can try.

Thanks!

MagisterCultuum · Feb 26, 2015

I just found this bug around line 358 of PyHelpers.py

NameError: global name 'i' is not defined

Code:

	def getPlotList(self):
		' plotList - player plots '
		lPlots = []
		for[COLOR="Red"] iIndex [/COLOR]in self.getPlotIDList():
			lPlots.append( CyMap().plotByIndex([COLOR="Red"]i[/COLOR]) )
		return lPlots

Obviously either iIndex or i should be changed to match the other. Since iIndex is used nowhere else in that file and i is used often, I assume it would be better to change iIndex to i.

omegaflames · Feb 27, 2015

in CustomFunctions.py what do the last 2 lines of the genesis code actually do? Because it looks to me like all it does is set a feature that is already there.

Spoiler :

Bug Reports and Discussion

Let's get Tactical!

Emperor

Chieftain

Attachments

Emperor

Let's get Tactical!

King

Emperor

King

Chieftain

Chieftain

Chieftain

King

Chieftain

Emperor

Chieftain

Chieftain

Chieftain

Chieftain

Great Sage

Warlord

Similar threads