C2C SVN Changelog

[olduser]

8129 (I assume)
A combat modifier fix for attackers which had a severe flaw in unitcombat modifications.

It looks like you didn't commit the changed source files.

 

[Thunderbrd]

It looks like you didn't commit the changed source files.

Ah... you're probably right since I didn't do the normal commit but rather just specified the dll since my XML was undergoing major modifications. However, at this time I'm struggling with an issue that somehow breaks save compatibility. I'm not sure if it's the XML or something in the very small amount of coding I've done since that commit.

I may need some help on this one anyhow but I need to run some tests here before I can determine what the source of the issue is before I can commit any changes. I'm hoping to have it fixed very soon... figured I was ready for commit and then testing came up with this .

The one thing that really bugs me about the issue is that I haven't changed much in code and there's not much in xml that should be capable of causing a savegame to hit an infinite loop on loading so I'm a bit disturbed here. Anyhow, if I can assure myself it's not the dll and is instead some aspect of the xml then I can get an early commit on the code stuff in quickly.


EDIT: Looks like it's probably a problem in the code - hits the same loop on initializing a starting game so something's whack there. I'll review the few changes with a compare between my code files and a codeset updated to the latest SVN and should be able to quickly sort out the issue - as I said I hadn't done much coding since the last full commit.

 

[Thunderbrd]

Ok, so my dll runs fine on an updated version but doesn't on my modified one... something is wrong in the xml apparently. So that's going to be fun sorting out (since the game loads ok and shows everything in the pedia just fine... hrmph)

But I can give you an updated sources file and dll set soooo...

8124/8125
Updates sources and dll



EDIT: Wow... ok so word to the wise: NEVER set a unit to upgrade to itself accidentally... nothing catches this until you hit an infinite loop trying to load or initiate a game! Pain in the arse to find!

So I've got another commit pending here (no code adjustments just lotsa xml.) I just need to take a bit to write out what it includes.

 

[Thunderbrd]

8136

• All New Healing Units according to the list given in the Heal by UnitCombat thread.
  
  
• All New Healing Promotions according to the Healing Promotions review linked to in the Heal by UnitCombat Thread.
  
  
• Numerous unit tweaks to support the above adjustments.
  
  
• Some supporting code tweaks - in particular makes NOT having a UnitCombat that is specified as added by a promotion with the SubCombatChangeTypes tag a prerequisite of that promotion.
  
  
• Note this includes a new promotionline, Educate, to help some unit types add Education values to a city.

Also... it should be clarified that testing shows that since the old healing promotions were removed to pave the way for the new ones, existing healers apparently don't lose their previous abilities assigned by those promotions although they've lost the promos nevertheless. So healers in existing games will probably end up a little too powerful. Of course, as soon as upgraded they'll lose this unintended power.

 

[Thunderbrd]

8137

• Reduces some general building healing factors for cities as a temporary patch until the full workup of building HealbyUnitCombatTypes can be sorted out properly.
  
  
• Audit of building Education sources which adds numerous new sources of education to help balance the education property.

Aside from new sources of Education that may be coming soon, between these and the new Educate promotions we should now have a much better education property system balance. Some feedback from any playtesters on this will be welcome.

 

[Dancing Hoskuld]

8138

A couple of minor fixes
- fix Myth of Tuna button
- Thylacine buildings now Thylacine not Gryptodon

 

[Sparth]

8136

• All New Healing Units according to the list given in the Heal by UnitCombat thread.

• 
  
  I presume its time for new buttons/models yes?

 

[Thunderbrd]

I presume its time for new buttons/models yes?

Yeppers

 

[Yudishtira]

8139

Small fix to Dynamic Civ Names python (countering the tendency of civ names to get stuck on "Provisional" during anarchy).

See thread in this forum for details.

 

[Sparth]

8140
New buttons for all new mechanic/veterinary units.

 

[Thunderbrd]

8141

• Debugs CvUnitInfo::hasUnitCombat
  
  
• Refines UnitCombat access to new self heal and self recovery promos (rather than a coding change I just kept these promotionlines mainly to combat capable classes.)

 

[Dancing Hoskuld]

8142

Elephant Myth can no longer be built in every city

 

[Sparth]

8143

- fixed some healing units buttons
- added new wise woman button

 

[Dancing Hoskuld]

8144

- change Biodome to produce any available subdued animal

 

[Thunderbrd]

8145

• Restructures some promotion prereqs for new healing promotions that give non-healing units some limited healing access.
  
  
• Adjusts the code to work properly with Alberts2's hasUnitCombat method and improves a few loading procedures for updating after-load unitinfo details.

 

[Thunderbrd]

8146

• Adds some new promotionlines for Quality accessed base strength bonuses (for Size Matters Only)

 

[Sparth]

8147
- new models/skins for some veterinary/mechanic units

 

[Thunderbrd]

8148

• Adjusts the benefits of the new quality strength promos
  
• Fixes experience award displays

 

[Hydromancerx]

Updates
- Bug Catcher now produces Bugs resource.

 

[Sparth]

8150
- new parrot, sapphire and jade buttons
- new no justice event image