C2C SVN Changelog
- Thread starter Dancing Hoskuld
- Start date
JosEPh_II
TBS WarLord
I agree Is612, leave them in for now.
JosEPh
JosEPh
strategyonly
C2C Supreme Commander
You forgot that the Armed Worker stuff also is in the _Remove Before Freeze area thus causing the errors, its easy to fix.
Best thing to do for now is make it a modmod module in that thread area, then alot of testing can be done that way, hows that.
Dancing Hoskuld
Deity
IIRC if you want units to get XP then they need combat strength. So if you want workers to get promotions then they need combat str. I have been known to be wrong.
strategyonly
C2C Supreme Commander
Well there goes my hopes and dreams, out the door then
i dont thing this is true. in fall of heaven mod workers get exp from working
Needs code in either the DLL (ideally) or Python, triggered by worker actions though to achieve that.
Dancing Hoskuld
Deity
Removed improvement types breaks save games.
It needs the same treatment then. I will change it tonight.
Dancing Hoskuld
Deity
Thanks. I am in a bit of confused brain space at the moment. It does not help that it is after midnight here.
strategyonly
C2C Supreme Commander
Added NEW Mexican Civ, with help from new trainee SargontheGreat2
Latest SVN has broken XML for promotions PROMOTION_TROUBLEMAKER2 and PROMOTION_TROUBLEMAKER3:
The bolded pre-req should be PROMOTION_COMBAT2 not just COMBAT2. The other troublemaker promotion has a similar issue
Edit - also in latest SVN the footstep audio types LOOPSTEP_SPACESHIP and ENDSTEP_SPACESHIP are referenced from the new terrain types but not defined.
Code:
<PromotionInfo>
<Type>PROMOTION_TROUBLEMAKER2</Type>
<Description>TXT_KEY_PROMOTION_TROUBLEMAKER2</Description>
<Sound>AS2D_IF_LEVELUP</Sound>
<LayerAnimationPath>NONE</LayerAnimationPath>
<PromotionPrereq>PROMOTION_TROUBLEMAKER1</PromotionPrereq>
[B]<PromotionPrereqOr1>COMBAT2</PromotionPrereqOr1>[/B]
<PromotionPrereqOr2>NONE</PromotionPrereqOr2>
<TechPrereq>NONE</TechPrereq>The bolded pre-req should be PROMOTION_COMBAT2 not just COMBAT2. The other troublemaker promotion has a similar issue
Edit - also in latest SVN the footstep audio types LOOPSTEP_SPACESHIP and ENDSTEP_SPACESHIP are referenced from the new terrain types but not defined.
Just pushed to SVN:
@Thunderbrd - if you return 'true' from one of the mission-searching subroutines in CvUnitAI (AI_foundReligion() in this case) you MUST push a mission, because by returning true you are asserting that you have given the unit something to do. Without doing that the unit will loop. I have made the simplest fix possible consistent with what I think your intent was, though it will simply cause the prophet to sit still until it's favorite religion becomes technologically available, which I think is probably (highly) sub-optimal AI (since if you have multiple prophets they will ALL just hang around until you get the tech for your favorite religion). For that reason you may want to revisit this, but it only effects players using divine prophets.
- Fixed WFoC hang when you use divine prophets
@Thunderbrd - if you return 'true' from one of the mission-searching subroutines in CvUnitAI (AI_foundReligion() in this case) you MUST push a mission, because by returning true you are asserting that you have given the unit something to do. Without doing that the unit will loop. I have made the simplest fix possible consistent with what I think your intent was, though it will simply cause the prophet to sit still until it's favorite religion becomes technologically available, which I think is probably (highly) sub-optimal AI (since if you have multiple prophets they will ALL just hang around until you get the tech for your favorite religion). For that reason you may want to revisit this, but it only effects players using divine prophets.
strategyonly
C2C Supreme Commander
Fixed it in the ls612 promotions
Dancing Hoskuld
Deity
Updates
- Add resources BONUS_COCONUT. BONUS_DATES, BONUS_PISTACHIO and BONUS_POMEGRANATE. Note these can't be improved yet, waiting on AIAndy's fix for missing improvements.
- New map art for Jungle Camp by hrochland Note feedback needed on this one.
@StrategyOnly please remove the following from art/terrain/features in your FPK
- barrel_cactus
- coconut
- prickly_pear
You don't need to push a new FPK it is just house keeping so "we" don't forget to remove them later. They are in the _Remove mod just in case we want them back.
@Hydro I have a Cocoa resource almost ready it just needs a button
- Add resources BONUS_COCONUT. BONUS_DATES, BONUS_PISTACHIO and BONUS_POMEGRANATE. Note these can't be improved yet, waiting on AIAndy's fix for missing improvements.
- New map art for Jungle Camp by hrochland Note feedback needed on this one.
@StrategyOnly please remove the following from art/terrain/features in your FPK
- barrel_cactus
- coconut
- prickly_pear
You don't need to push a new FPK it is just house keeping so "we" don't forget to remove them later. They are in the _Remove mod just in case we want them back.
@Hydro I have a Cocoa resource almost ready it just needs a button
Has PROMOTION_BARBAR_HUNTER been removed recently? If so the Python needs tidying up to remove references to it also - currently it's calling the DLL from this code:
The effect is to get back -1 from the call to gc.getInfoTypeForString(), which it does NOT test for (it really should), and just uses as arguments to isHasPromotion() and canAcquirePromotion(). That causes access off the end of an array in the DLL, which it usually gets away with (the result will be undefined), but which can cause crashes.
I'll harden those calls in the DLL to cope with this usage, but the Python really needs tidyign up too.
Code:
iBarbarHunter =gc.getInfoTypeForString('PROMOTION_BARBAR_HUNTER')
iGreatWall = gc.getInfoTypeForString("BUILDINGCLASS_GREAT_WALL")
if not gc.getGame().isOption(GameOptionTypes.GAMEOPTION_NO_BARBARIANS):
if (iPromotion<>iBarbarHunter):
if not pWinner.isHasPromotion(iBarbarHunter):
if pWinner.canAcquirePromotion(iBarbarHunter):The effect is to get back -1 from the call to gc.getInfoTypeForString(), which it does NOT test for (it really should), and just uses as arguments to isHasPromotion() and canAcquirePromotion(). That causes access off the end of an array in the DLL, which it usually gets away with (the result will be undefined), but which can cause crashes.
I'll harden those calls in the DLL to cope with this usage, but the Python really needs tidyign up too.
Dancing Hoskuld
Deity
I may have changed the spelling for the name because we had two similarly named ones which was confusing me. Besides why would have a promotion just to attack one specific elephant
.Fix on the SVN.
