Just pushed to SVN (5123):
Note - I never had a 100% certain test case for the CTD, but I found a bug that is implicated in the provided minidumps, and all 3 posted saves complete turns fine with the putative fix. If the original reporters of the CTDs could also verify it works now that would be useful please.
@TB - this does not include your proposed change to CvUnit::maxCombatStr(). Something there **may** still be necessary, but I don; see a hole in the code currently (though you may have test cases I don't)
- Fixed CTDs reported by various people
- Fixed bug in odds caching
- Fixed application of combatMod bonuses of a unit against itself
- Tweaked AI attack stack am-I-big-enough evaluation slightly
Note - I never had a 100% certain test case for the CTD, but I found a bug that is implicated in the provided minidumps, and all 3 posted saves complete turns fine with the putative fix. If the original reporters of the CTDs could also verify it works now that would be useful please.
@TB - this does not include your proposed change to CvUnit::maxCombatStr(). Something there **may** still be necessary, but I don; see a hole in the code currently (though you may have test cases I don't)