Fanatic Noob
King of Noobism
I see you dont like to brag, HUH
Well, I just made impossible, porting my nation, from RoM to C2C as possible, so it's just my random happines, nothing about bragging ; ]
Help Wanted Ads
- Thread starter strategyonly
- Start date
Well, I just made impossible, porting my nation, from RoM to C2C as possible, so it's just my random happines, nothing about bragging ; ]
I have run into a new error with the Sevopedia and art files. I am working on a Woodstock Wonder (to use the new Counterculture tech) and I found a building model here: http://forums.civfanatics.com/downloads.php?do=file&id=18990. When I try to use the building model, I get an error from the Sevopedia when I go into the Wonder entry. Has anyone seen this error before, or know what causes it? I know it has to do with the building model, because if the ArtDefines file doesn't call the building NIF file, there is no problem. The NIF looks fine in NifSkope, so I don't know what the problem is.
This is what the error reads:
I've attached a ZIP of the current module. Please let me know if there is any way to get the building model usable. I suppose the wonder could work without the building model if that is the only way.
This is what the error reads:
Code:
Traceback (most recent call last):
File "CvScreensInterface", line 464 in pediaJumptoBuilding
File "SevoPediaMain", line 293, in pediaJump
File "SevoPediaBuilding", line 78, in interfaceScreen
Runtime error: unidentifiable C++ exceptionI've attached a ZIP of the current module. Please let me know if there is any way to get the building model usable. I suppose the wonder could work without the building model if that is the only way.
Quick question here. I'm working on an Alamo wonder that will add the base strength of any of your units killed as culture in all cities. This is the Python function that adds the culture to the cities:
What does the last parameter mean? I looked it up in the API and it just said BOOL bPlots. I have it set to False right now and it seems to work, but I just want to know what that parameter is doing.
Code:
city.changeCulture(unitStr, false)What does the last parameter mean? I looked it up in the API and it just said BOOL bPlots. I have it set to False right now and it seems to work, but I just want to know what that parameter is doing.
God-Emperor
Deity
I would hope that you are not actually missing the first argument to the call, the one that specifies which player's culture is getting added...
It may be a quick question, but the answer is not quite so quick.
If the bPlots argument is set to True it will run some code that distributes culture to plots in the city's cultural radius like it normally does just once per turn, although with a quick look at the code it appears that it is checking for a city's workable plots (it checks the range via CvPlot::isPotentialCityWorkForArea isntead of CvPlot::isWithinCultureRange) so it appears to only do this for plots in the city's workable area (the 3x3 area centered on the city if its borders have not expanded, or the full BFC if they have expanded at least once) rather than the full cultural radius. The amount of culture it adds to each plot is always the minimum value (the function that distributes the culture is called with a amount value of 0), which is 1 + the base amount (call it "B", the CITY_FREE_CULTURE_GROWTH_FACTOR defined value) multiplied by the culture level (call it "C") minus the range ("R"), as in B*(C-R) + 1. That value "B" is normally 20 and the value of R will be 0 for the city plot itself, 1 for adjacent plots and 2 for the remaining plots that make up the BFC. The amount of culture you are adding to the city does not affect this. It would pretty much be a free distribution of some amount of culture to all the affected plots beyond the normal amount they get during the processing between turns.
You probably don't want to set it to True. The one example I see (from just a quick search in the CvCity.cpp file) that does use True happens when a city is liberated, so when a city is liberated it immediately gets some of its new civ's culture spread around and then it will get the regular amount on its turns as usual after that.
It may be a quick question, but the answer is not quite so quick.
If the bPlots argument is set to True it will run some code that distributes culture to plots in the city's cultural radius like it normally does just once per turn, although with a quick look at the code it appears that it is checking for a city's workable plots (it checks the range via CvPlot::isPotentialCityWorkForArea isntead of CvPlot::isWithinCultureRange) so it appears to only do this for plots in the city's workable area (the 3x3 area centered on the city if its borders have not expanded, or the full BFC if they have expanded at least once) rather than the full cultural radius. The amount of culture it adds to each plot is always the minimum value (the function that distributes the culture is called with a amount value of 0), which is 1 + the base amount (call it "B", the CITY_FREE_CULTURE_GROWTH_FACTOR defined value) multiplied by the culture level (call it "C") minus the range ("R"), as in B*(C-R) + 1. That value "B" is normally 20 and the value of R will be 0 for the city plot itself, 1 for adjacent plots and 2 for the remaining plots that make up the BFC. The amount of culture you are adding to the city does not affect this. It would pretty much be a free distribution of some amount of culture to all the affected plots beyond the normal amount they get during the processing between turns.
You probably don't want to set it to True. The one example I see (from just a quick search in the CvCity.cpp file) that does use True happens when a city is liberated, so when a city is liberated it immediately gets some of its new civ's culture spread around and then it will get the regular amount on its turns as usual after that.
This is what the code looks like:
Code:
from CvPythonExtensions import *
from PyHelpers import PyPlayer
import CvUtil
import sys
# globals
gc = CyGlobalContext()
bc_Alamo = gc.getInfoTypeForString("BUILDINGCLASS_ALAMO")
def onUnitKilled(argsList):
unit, iAttacker = argsList
player = PyPlayer(unit.getOwner())
if player.getBuildingClassCount(bc_Alamo) == 1:
unitStr = unit.baseCombatStr()
cityList = player.getCityList()
for city in cityList:
city.changeCulture(unitStr, False)If I add anything else to the city.changeCulture line, I get this error:
Code:
TypeError: changeCulture() takes at most 3 arguments (4 given)It looks to me like the changeCulture is already using player as its first argument. I could be wrong - is there something going on that I'm not aware of?
OK. Thank you for the explanation. I will leave the parameter on False.
I think thjis is a bug in the (exposure of the) method being exposed to Python. The code has:
Code:
void CyCity::changeCulture(int /*PlayerTypes*/ eIndex, int iChange, bool bPlots)
Code:
.def("changeCulture", &CyCity::changeCulture, "void (int PlayerTypes eIndex, int iChange, bool bPlots)")I have just fixed this in SVN rev 3196 - let me know if you can use the (correct) 3 arguments now please.
No, I'm still getting the error message, and I updated my SVN to 3196.
This produces the TypeError message of 4 arguments:
Code:
city.changeCulture(player, unitStr, False)This produces no error message and (apparently) the correct culture adjustment:
Code:
city.changeCulture(unitStr, False)Do you want my module files?
No it's ok - I'll modify some test Python here to see what's going on for now.
Edit - although 'player' is not the rigth value to use in the first arg anyway - should be player.getID() - could you just try that for me before I look into i more (I'm trying to fix some other issues currently)
Eh, that third part of the .def is just a help comment for Python as string, it has no meaning for the actual call.
Ok - thought the interpretor was using it to param check. In that case it's a mystery currently why Volkarya can't use all three params.
Hmm, I think what he is calling is PyCity.changeCulture, not CyCity.changeCulture.
It is a Python function with that signature: def changeCulture(self, iChange, bPlots=True)
Ah yes. That's fine then - it does indeed assume you mean the city owner as the player.
OK, then: should I change my code or leave it the way it is now?
Its fine now I think.
OK. Thank you very much for your help. I'll post The Alamo on my Wonders thread once v25 is released. (I'm trying to at least get the artwork together for some ideas that don't have the code in place yet, so I may be able to post another Wonder or two once the new version is out.)
strategyonly
C2C Supreme Commander
Python problem"
whats the difference between the two and which one or do i change to make it work correctly?
or
?
whats the difference between the two and which one or do i change to make it work correctly?
Spoiler :
or
Spoiler :
Neither of them make sense!
The first one is valid Python but does absolutely nothing (sets player to X, then IF <promotion condition> set it to the same X again, so the conditional is irrelevant).
The second one is invalid Python since the 'if' has no statement to execute due to it havign been commented out
strategyonly
C2C Supreme Commander
OK here is what i have then, pls change it to make it work, thx:
Part 1:
Spoiler :
part 2:
Spoiler :
No idea. What's not working about it?
Similar threads
