1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

I want to help this mod

Discussion in 'Civ4 - Caveman 2 Cosmos' started by strategyonly, Aug 8, 2016.

  1. Dancing Hoskuld

    Dancing Hoskuld Deity

    Joined:
    Jul 5, 2004
    Messages:
    23,518
    Gender:
    Male
    Location:
    Canberra, Australia
    First off, language is not the same as writing. It is possible to forget one but still do the other. Although I believe it is reading of writing that is possible not the writing itself. There are many examples of people forgetting how to speak a language but can still read it. Similarly language is possible without writing. So don't get the two confused.

    See
     
  2. MattCA

    MattCA Warlord

    Joined:
    Jan 25, 2019
    Messages:
    260
    Gender:
    Male
    These gitbhub issues are done.
    Add Remapping code for YieldTypes #83
    Add Remapping code for CommerceTypes #82
     
  3. BlueTemplar

    BlueTemplar Prince

    Joined:
    May 14, 2006
    Messages:
    392
  4. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    27,412
    Gender:
    Male
    Location:
    Las Vegas
    Units are tough to mod but the community was working on tons of them and we've found some sources from other games but the graphics and animations are still something we struggle with that I'm about to have to overcome the challenge of learning how to do efficiently.

    The animated leaders were possibly removed due to some not being animated and to align the rest with them but largely due to memory usage - they are heavy and we didn't want to burden the mod's data load with them as many of us didn't feel the animations brought as much to the table as Firaxis must have felt they did to include them in the first place.

    Otherwise it's all pretty much on point except that AND and C2C have grown so far now in different directions that you can't anymore really say we're a sub-mod of them now. We certainly did grow out of that root though.
     
  5. BlueTemplar

    BlueTemplar Prince

    Joined:
    May 14, 2006
    Messages:
    392
  6. Dancing Hoskuld

    Dancing Hoskuld Deity

    Joined:
    Jul 5, 2004
    Messages:
    23,518
    Gender:
    Male
    Location:
    Canberra, Australia
    Animated leaders were removed mosty because they made the download way too big;). Memory was a lesser consideration. Once the decision was made it allowed the inclusion of all those non-animated leaders and after all C2C is about MORE:lol:.
     
  7. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    27,412
    Gender:
    Male
    Location:
    Las Vegas
    Memory has multiple term applications. That the download was too big is the same as saying they were costing too much memory. Not RAM memory, but overall mod space for the download memory.
     
  8. MattCA

    MattCA Warlord

    Joined:
    Jan 25, 2019
    Messages:
    260
    Gender:
    Male
    Here's copy paste from a current pr. It confused me when I went to switch it.

    Code:
    bool CvSelectionGroup::visibilityRange() const
    {
        int iMaxRange = 0;
    
        for (unit_iterator unitItr = beginUnits(); unitItr != endUnits(); ++unitItr)
        {
            const int iRange = (*unitItr)->visibilityRange();
            if (iRange > iMaxRange)
            {
                iMaxRange = iRange;
            }
        }
    
        return iMaxRange;
    
        // Matt: Why search for max, then return bool?
        return algo::any_of(units(), CvUnit::fn::visibilityRange() > 0);
    }
    
     
  9. Toffer90

    Toffer90 C2C Modder

    Joined:
    Oct 16, 2011
    Messages:
    6,717
    Location:
    Norway
    Yeah, that looks confusing, you gotta look at how other code use the return value of that function, see if you can spot what the other code expects to get from it.
    Maybe the return should be the int max range, but who knows, is it only called within an "if statement" without a comparator (<, >=, ==, !=) . . .? Or is the value used as an int there. . .?
     
    Last edited: Mar 6, 2020
  10. Thunderbrd

    Thunderbrd C2C War Dog

    Joined:
    Jan 2, 2010
    Messages:
    27,412
    Gender:
    Male
    Location:
    Las Vegas
  11. Toffer90

    Toffer90 C2C Modder

    Joined:
    Oct 16, 2011
    Messages:
    6,717
    Location:
    Norway
    The function isn't actually called from anywhere as far as I could see.
    bool CvSelectionGroup::visibilityRange() const
    You could just delete it I think.

    This variant is the only one used in code:
    int CvUnit::visibilityRange(const CvPlot* pPlot) const
     
    MattCA likes this.
  12. Epi3B1rD

    Epi3B1rD Chieftain

    Joined:
    Aug 21, 2011
    Messages:
    71
    Thank you :D. I'll check out the Git and have a look!
     
    Toffer90 and MattCA like this.

Share This Page