Modmodding Q&A Thread

citis · Aug 22, 2014

~~Trying modular (modmod)modding. Is there any schema file I can use?~~

Solved

srpt · Aug 22, 2014

srpt said:
I'm getting these errors (in my Canada DoC mod):

Spoiler :

Traceback (most recent call last):
File "BugEventManager", line 400, in _handleDefaultEvent
File "CvRFCEventHandler", line 184, in onCityAcquired
File "Stability", line 72, in onCityAcquired
AttributeError: 'NoneType' object has no attribute 'changeConqueredCities'
Traceback (most recent call last):
File "BugEventManager", line 400, in _handleDefaultEvent
File "CvRFCEventHandler", line 823, in onChangeWar
File "Stability", line 109, in onChangeWar
File "StoredData", line 253, in removeWarStatus
KeyError: 37
Traceback (most recent call last):
File "BugEventManager", line 400, in _handleDefaultEvent
File "CvRFCEventHandler", line 823, in onChangeWar
File "Stability", line 109, in onChangeWar
File "StoredData", line 253, in removeWarStatus
KeyError: 36

I'm confused because lWarStatus should automatically increment to iNumPlayers right?

Leoreth said:
I feel like I still have a problem maintaining the WarStatus objects in general, so that might not actually be related to your modmod.

still getting lots of these errors. any ideas?

oddly, they don't occur during auto-play, but now I'm getting many of them every turn.

Leoreth · Aug 22, 2014

I haven't had time to take care of that yet.

mrrandomplayer · Aug 24, 2014

Is there already a method for checking colonial owner in the code (I would assume it would be from the Argentina and Brazil spawns), and if so, where is it?

Leoreth · Aug 24, 2014

mrrandomplayer said:
Is there already a method for checking colonial owner in the code (I would assume it would be from the Argentina and Brazil spawns), and if so, where is it?

getColonyPlayer() in RFCUtils.py.

andrewv42 · Aug 24, 2014

Is there any way to remove the hammers granted to religious buildings by the apostolic palace?

Leoreth · Aug 24, 2014

XML\GameInfos\VoteSourceInfos.xml

andrewv42 · Aug 25, 2014

thankyou so much!

srpt · Aug 25, 2014

mispost. had a problem but solved it.

Qiu · Aug 30, 2014

I'm getting these problems.

1. I tried to borrow some code from Catholic URV. But it doesn't work. Did do something wrong?

Code:

				if (self.getGoal(iTatar, 2) == -1):
					iTotalLand = gc.getMap().getLandPlots()
					iIslamicLand = 0

					for iLoopPlayer in range(con.iNumPlayers):
						if gc.getPlayer(iLoopPlayer).isAlive() and gc.getPlayer(iLoopPlayer).getStateReligion() == con.iIslam:
								iIslamicLand += gc.getPlayer(iLoopPlayer).getTotalLand()

					fLandPercent = 100.0 * iIslamicLand / iTotalLand

					if (fLandPercent >= 30.0)
						self.setGoal(iTatar, 2, 1)

2. I also borrowed the code of Viking UP. Every cavalry unit can earn gold after a victorious battle as intended, except new UU. I'm sure there is a "iTatarNoyan" constant in Consts.py. Why?

Code:

#------------------TATAR UP----------------------
	
		if (iOwner == iTatar) and (pWinningUnit.getUnitType() == con.iHorseArcher or pWinningUnit.getUnitType() == con.iKnight or pWinningUnit.getUnitType() == con.iTatarNoyan or pWinningUnit.getUnitType() == con.iCavalry or pWinningUnit.getUnitType() == con.iMongolKeshik):
			if cLosingUnit.getDomainType() == gc.getInfoTypeForString("DOMAIN_LAND"):
				iGold = cLosingUnit.getProductionCost() / 3
				gc.getPlayer(iOwner).changeGold(iGold)
				sAdjective = gc.getPlayer(pLosingUnit.getOwner()).getCivilizationAdjectiveKey()
				CyInterface().addMessage(iOwner, False, con.iDuration, CyTranslator().getText("TXT_KEY_TATAR_YOKE_UP", (iGold, sAdjective, pLosingUnit.getNameKey())), "", 0, "", ColorTypes(con.iWhite), -1, -1, True, True)

Leoreth · Aug 30, 2014

Qiu said:

I'm getting these problems.

1. I tried to borrow some code from Catholic URV. But it doesn't work. Did do something wrong?

Code:

				if (self.getGoal(iTatar, 2) == -1):
					iTotalLand = gc.getMap().getLandPlots()
					iIslamicLand = 0

					for iLoopPlayer in range(con.iNumPlayers):
						if gc.getPlayer(iLoopPlayer).isAlive() and gc.getPlayer(iLoopPlayer).getStateReligion() == con.iIslam:
								iIslamicLand += gc.getPlayer(iLoopPlayer).getTotalLand()

					fLandPercent = 100.0 * iIslamicLand / iTotalLand

					if (fLandPercent >= 30.0)
						self.setGoal(iTatar, 2, 1)

Your code lacks a colon in the last if clause. Please mod with Python exceptions enabled, you would have seen this by yourself then.

2. I also borrowed the code of Viking UP. Every cavalry unit can earn gold after a victorious battle as intended, except new UU. I'm sure there is a "iTatarNoyan" constant in Consts.py. Why?

Code:

#------------------TATAR UP----------------------
	
		if (iOwner == iTatar) and (pWinningUnit.getUnitType() == con.iHorseArcher or pWinningUnit.getUnitType() == con.iKnight or pWinningUnit.getUnitType() == con.iTatarNoyan or pWinningUnit.getUnitType() == con.iCavalry or pWinningUnit.getUnitType() == con.iMongolKeshik):
			if cLosingUnit.getDomainType() == gc.getInfoTypeForString("DOMAIN_LAND"):
				iGold = cLosingUnit.getProductionCost() / 3
				gc.getPlayer(iOwner).changeGold(iGold)
				sAdjective = gc.getPlayer(pLosingUnit.getOwner()).getCivilizationAdjectiveKey()
				CyInterface().addMessage(iOwner, False, con.iDuration, CyTranslator().getText("TXT_KEY_TATAR_YOKE_UP", (iGold, sAdjective, pLosingUnit.getNameKey())), "", 0, "", ColorTypes(con.iWhite), -1, -1, True, True)

Are you sure the constants actually match the XML? Open the Python console and print GC.getInfoTypeForString([the Noyan XML tag]) and con.iTatarNoyan.

Qiu · Aug 30, 2014

Leoreth said:
Your code lacks a colon in the last if clause. Please mod with Python exceptions enabled, you would have seen this by yourself then.

Are you sure the constants actually match the XML? Open the Python console and print GC.getInfoTypeForString([the Noyan XML tag]) and con.iTatarNoyan.

Thank you very much.
Actually I have set Python exceptions enabled, but doesn't understand what it said. It's a colon :eek:

merijn_v1 · Aug 30, 2014

Qiu said:
Thank you very much.
Actually I have set Python exceptions enabled, but doesn't understand what it said. It's a colon

http://forums.civfanatics.com/showthread.php?t=532218

Qiu · Aug 30, 2014

merijn_v1 said:
http://forums.civfanatics.com/showthread.php?t=532218

Oh, yes! That's what I need. Thank you!

citis · Sep 3, 2014

In my modmodmod I noticed that the saves can't be opened with the modmodmod deinstalled. Since my modmodmod is a module and makes only graphical changes the saves should be playable with the modmodmod installed or not. How I can fix this?

Leoreth · Sep 3, 2014

Are you using the same paths for the flags as before?

baseballpie · Sep 3, 2014

citis said:
Since my modmodmod is a module and makes only graphical changes

Does that make it a..... modmodmodule? :mischief:

citis · Sep 4, 2014

Leoreth said:
Are you using the same paths for the flags as before?

No, I use new paths inside the module.

Leoreth · Sep 4, 2014

citis said:
No, I use new paths inside the module.

Then that's causing the incompatibility. Paths to the flag decals are stored inside the savegame file, if the flags at these locations are deleted you are likely to get a crash.

citis · Sep 4, 2014

Leoreth said:
Then that's causing the incompatibility. Paths to the flag decals are stored inside the savegame file, if the flags at these locations are deleted you are likely to get a crash.

Oh, how I can fix it then? I want to avoid replacing the original files.

Modmodding Q&A Thread

Deity

Deist

Bofurin

Hopeless Situation Warrior

Bofurin

Warlord

Bofurin

Warlord

Deist

Warlord

Bofurin

Warlord

Black Belt

Warlord

Deity

Bofurin

Deity

Deity

Bofurin

Deity

Similar threads