1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

More GPs Module

Discussion in 'Community Patch Project' started by Asterix Rage, Dec 2, 2020.

  1. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,449
    Gender:
    Male
    I think the main issue is that there's a lack of clarity about how much memory new GP and associated resources consume, and how to measure it.
     
    Asterix Rage likes this.
  2. Gazebo

    Gazebo Lord of the Community Patch Supporter

    Joined:
    Sep 26, 2010
    Messages:
    18,175
    Gender:
    Male
    Location:
    Little Rock
    I don’t think that references to media content intrinsically increase civ’s memory footprint, since the media content does not directly load into memory, but rather references to the media. For example, if you delete media files in-between saves, those media files will fail to load, which means that the content is being referenced by location, not by instance.
     
    Asterix Rage and Recursive like this.
  3. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,449
    Gender:
    Male
    If that's the case, there's probably room for a lot more Great People :crazyeye:
     
  4. Asterix Rage

    Asterix Rage Warlord

    Joined:
    Jun 6, 2010
    Messages:
    1,486
    It makes sense.

    To be honest, right now, I have enough with this MGPs.
    So, I suggest you or G to integrate this v.3 in the next VP release.
    This version is much more refined than the previous one and the number of GPs in it is already insane.

    090 Great Musicians
    090 Great Artists
    054 Great Writers
    115 Great Generals
    089 Great Admirals
    116 Great Merchants
    085 Great Engineers
    081 Great Scientists
    073 Great Diplomates
     
    Recursive likes this.
  5. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,449
    Gender:
    Male
    Make a pull request or send the files and one of us will be happy to do that, I'm sure. :)
     
  6. Asterix Rage

    Asterix Rage Warlord

    Joined:
    Jun 6, 2010
    Messages:
    1,486
    I don't know how to do it properly :blush: I use to send all the stuff to @Gazebo who does it perfectly :)

    All is here (as a patch. Tree and files)
    This version completely replaces the previous one.
    \(1) Community Patch\Modules\MoreGP must be deleted first
     
  7. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,449
    Gender:
    Male
    @Gazebo I think you'd be more adept at handling this, plus you update your own files locally...
     
    Asterix Rage likes this.
  8. General_Drax

    General_Drax Warlord

    Joined:
    Sep 23, 2019
    Messages:
    253
    Gender:
    Male
    Location:
    Bologna, Italy
    In my current Japan playthrough with the latest version all went fine: no more black background for GA/GM and the quotes from GW are all played as they meant to.

    Going for Culture domination through a Tradition/Authority/Imperialism so I think I'll see a lot more GP, especially with th Japan UA.

    H.P. Lovecraft Call of Cthulu quote is a masterpiece !

    Thank you for the great work !
     
    bigcat88 likes this.
  9. Asterix Rage

    Asterix Rage Warlord

    Joined:
    Jun 6, 2010
    Messages:
    1,486
  10. Stalker0

    Stalker0 Baller Magnus

    Joined:
    Dec 31, 2005
    Messages:
    7,843
    Did you all add Baba Yetu into the mod? Because I just heard it for the first time that I can recall, and its awesome! :)
     
  11. Asterix Rage

    Asterix Rage Warlord

    Joined:
    Jun 6, 2010
    Messages:
    1,486
    I added most of Artists suggested here.
     
    dilophosaur likes this.
  12. gwennog

    gwennog Prince

    Joined:
    May 31, 2015
    Messages:
    309
    Gender:
    Male
    Location:
    France
    A small error in name of Vélazquez

    Spoiler Diego Vélazquez :
    upload_2021-3-26_20-47-14.png
     
  13. Asterix Rage

    Asterix Rage Warlord

    Joined:
    Jun 6, 2010
    Messages:
    1,486
    Thx for the report.

    This is not a typo:
    Code:
        ('TXT_KEY_GREAT_PERSON_A__080', 'Diego Vélasquez'),
    
    It's all about encoding ANSI/UTF-8 and it will be fixed soon.
     
    gwennog and dilophosaur like this.

Share This Page