1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

New Beta Version - December 20th (12/20)

Discussion in 'Community Patch Project' started by Gazebo, Dec 21, 2019.

  1. Kim Dong Un

    Kim Dong Un The One & Unly Supporter

    Joined:
    Dec 17, 2017
    Messages:
    862
    Gender:
    Male
    Location:
    Pyongyang
    You will enjoy - I've been using PDan's unit tweaks since the beginning with great pleasure. The Formation changes are legit as well; I can't recall ever picking that promotion for my units, but now it's my default going Formation II on all my (non-sword) melee.

    I have nothing but love for VP and all involved, but it took me one game to realize this new mounted ranged isn't for me. Why are terrain specific variables being thrown onto a single mounted line, when we don't have general defensive terrain bonus for any mounted (I understand for gameplay, but it makes little sense to say my horses, aside from chariots, have no advantage on high ground, while simultaneously slapping some negative modifier on my ranged cavalry because they're on a hill)?

    Supreme Glorious Leader will not be indoctrinated! :nono:
     
    Rekk likes this.
  2. telelavoro

    telelavoro Chieftain

    Joined:
    Oct 14, 2018
    Messages:
    31
    Gender:
    Male
    Is this a bug? got 2 friends as germany, but no +6 science (I am getting the golden age pts)
     
  3. civplayer33

    civplayer33 King

    Joined:
    Sep 11, 2017
    Messages:
    965
    It doesn't look like you're getting the Golden Age Points as there should be a timer active in the top panel if the sum is positive...so if you're saying that you have 2 City State friends (not major civilizations with Declarations of Friendship) then kindly report to GitHub.
     
  4. crobartie

    crobartie Chieftain

    Joined:
    Dec 19, 2019
    Messages:
    4
    Gender:
    Male
    Zuizgond likes this.
  5. Gazebo

    Gazebo Lord of the Community Patch Supporter

    Joined:
    Sep 26, 2010
    Messages:
    18,087
    Gender:
    Male
    Location:
    Little Rock
    It's a bug, I'm aware, will hotfix today.
     
  6. Gazebo

    Gazebo Lord of the Community Patch Supporter

    Joined:
    Sep 26, 2010
    Messages:
    18,087
    Gender:
    Male
    Location:
    Little Rock
  7. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,386
    Gender:
    Male
    Just as an FYI to everyone, the latest hotfix (due to some merge errors) undoes many of my diplomacy changes. Working on getting this fixed.

    When fixed, it will not be savegame compatible with the -2 hotfix.


    Ignore the above message, see below for explanation.
     
    Last edited: Dec 23, 2019
    JamesNinelives likes this.
  8. telelavoro

    telelavoro Chieftain

    Joined:
    Oct 14, 2018
    Messages:
    31
    Gender:
    Male
    thanks comrades for your continued efforts!
     
    JamesNinelives likes this.
  9. Der_Zorn_gottes

    Der_Zorn_gottes King

    Joined:
    Apr 10, 2003
    Messages:
    758
    Scaling with mapsize, I suppose? :mischief:
     
    JamesNinelives likes this.
  10. BiteInTheMark

    BiteInTheMark Emperor

    Joined:
    Aug 23, 2016
    Messages:
    1,972
    Gender:
    Male
    Location:
    Germany
    To the order change:
    While I like the increased yields for improvements and the reduced maintenance cost for buildings I dislike the free building ideas.
    Its so uncreative, so late in the game you already are able to rush the few comming buildings. Especially in the first 5 cities, which are in most cases the already best developed.
    Except some saved hammers and money, does this really help? I don't think so.

    To Germany:
    I was hoping for more diplomatic power by reducing the ratio for votes from CS from 3 to 2. And something that helps in achieving the alliance status with CS, like a cost decrease for civilian units by half the Hanse modifier. An immunity for sanctions for trade routes would fit too. For that, you could throw away that yields. I would prefer utility UA than pure yields.

    Solar plant:
    Looks for me crappy.
    If your bond in producing units cause of endless wars, when do you want to use that processes? Not even that, it's also the one with the lowest modifier, and I don't see a reason why.
     
  11. Gazebo

    Gazebo Lord of the Community Patch Supporter

    Joined:
    Sep 26, 2010
    Messages:
    18,087
    Gender:
    Male
    Location:
    Little Rock
    I don’t think it does. I have the latest pull in my local repo

    G
     
    JamesNinelives likes this.
  12. adac

    adac Chieftain

    Joined:
    Jun 11, 2014
    Messages:
    74
    Is this why DIPLO_AI_NO_VICTORY_COMPETITION is no longer available in CoreChanges.sql (or anywhere else for that matter)?
     
  13. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,386
    Gender:
    Male
    After taking a closer look at the repository using WinMerge, the DLL seems fine and the deletions seem to be all fixes to merge errors (I mistook deleted duplicate code as being a reversion of changes, but it turns out the fixed merge error had a very large amount of duplicate code - ~3,000 ish changes)

    A few of the SQL files were deleted, however, so I'll send a pull request to restore those to the repository.
    Sorry for being unnecessarily alarmist, everyone. :)

    To correct my previous statement, 12-20-2 will be compatible with any hotfix that is posted, and you can start playing right away.

    However, to play with the full extent of my diplomacy changes (and a number of diplomacy changes from before I came along, too), insert the following attached files into the Community Patch > Core Files > Core Changes folder. The current posted version does not have the correct diplo values for a number of things.

    Savegame compatible. Happy holidays, all!


    UPDATE: Don't bother doing this yet as there is an issue with the changes in the files; fix is incoming.
     

    Attached Files:

    Last edited: Dec 23, 2019
    JamesNinelives, Maxxim69 and Yaviel like this.
  14. adac

    adac Chieftain

    Joined:
    Jun 11, 2014
    Messages:
    74
    Ah, DIPLO_AI_NO_VICTORY_COMPETITION was moved to a new file that was missing. Got it, thanks!
     
    Recursive likes this.
  15. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,386
    Gender:
    Male
    I'm happy to hear that some people do use and enjoy it, I hadn't heard much feedback about it. :)
     
    JamesNinelives likes this.
  16. adac

    adac Chieftain

    Joined:
    Jun 11, 2014
    Messages:
    74
    Oh I definitely like it; it always bothered me how my long term friends would suddenly hate me just because the era changed and I was doing well. Then again, I'm not the most competitive player who is looking for the greatest possible challenge.
     
    JamesNinelives likes this.
  17. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,386
    Gender:
    Male
    There's actually an issue with the new files - it looks like the changes made there are not actually being added to the game; trying to get this fixed ATM.
     
  18. Coffee Monopoly

    Coffee Monopoly Warlord

    Joined:
    Nov 10, 2019
    Messages:
    101
    Gender:
    Male
    Wtf are you doing Recursive... take it easy man, it's Christmas!

    I just had some fun one-shotting a newly settled coastal city with a quinquireme in the very early game.
     
    JamesNinelives, vyyt, JNZS13 and 2 others like this.
  19. Recursive

    Recursive Covets Lands That You Currently Own Moderator

    Joined:
    Dec 19, 2017
    Messages:
    2,386
    Gender:
    Male
    I shall...but I wanted to get my edits in before Christmas. :)
     
  20. Gazebo

    Gazebo Lord of the Community Patch Supporter

    Joined:
    Sep 26, 2010
    Messages:
    18,087
    Gender:
    Male
    Location:
    Little Rock
    12-20-3 uploaded. Savegame compatible. Fixes merge issue from @Recursive's missing SQL update modinfo code.

    G
     

Share This Page