glider1
Deity
@OrionVet
To save you some work, I could wrap up some of the simpler stuff about when you can conduct an inquistion and when you cannot. At the moment there are a few escapee conditions. It is possible to conduct an inquisition under pacifism as it stands now for example . If you like, I can catch these conditions by rewriting the following functions:
CvGameUtils.canTrain()
CvGameUtils.cannotTrain()
Conditions would be:
canTrain: if have state religion AND not pacifism
cannotTrain: if not have state religion OR pacifism (just an inversion of canTrain)
"Free religion" would be autmatically caught that way leaving only "Paganism" as an escapee. Ok with you?
The other condition that I think needs catching is that because inquisitors aren't killed off unless they have conducted an inquistion, they can hang around and possibly conduct inquisitions when they shouldn't if at any point we make some bad AI code. Therefore the proposition is that we make a final catch of the possibility of a rogue inquisition in the function:
CvGameUtils.doHolyCitySeekAndDestroy()
where we make one final ask "can we conduct an inquisition?" before we go do it. The inquisition event is always fired from this function so it's a pretty good place to do it. I could unite that question under one function so that it only ever get's answered in one place. So if you are busy on other things I can write, test and submit:
def CvGameUtils.canTrain()
def CvGameUtils.cannotTrain()
def CvGameUtils.doHolyCitySeekAndDestroy()
def CvGameUtils.canInquisition()
@Dresdon
Thanks on the API docs. Question for you if you have got the time. At the moment inquisitors are invisible. This is an obvious exploit because you can use them as spies abroad. To make them visible is it as simple as toggling this tag in the xml?:
<bInvisible>1</bInvisible>
and does that mean that inquisitors then are subject to all the rules about open borders etc?
Cheers.
To save you some work, I could wrap up some of the simpler stuff about when you can conduct an inquistion and when you cannot. At the moment there are a few escapee conditions. It is possible to conduct an inquisition under pacifism as it stands now for example . If you like, I can catch these conditions by rewriting the following functions:
CvGameUtils.canTrain()
CvGameUtils.cannotTrain()
Conditions would be:
canTrain: if have state religion AND not pacifism
cannotTrain: if not have state religion OR pacifism (just an inversion of canTrain)
"Free religion" would be autmatically caught that way leaving only "Paganism" as an escapee. Ok with you?
The other condition that I think needs catching is that because inquisitors aren't killed off unless they have conducted an inquistion, they can hang around and possibly conduct inquisitions when they shouldn't if at any point we make some bad AI code. Therefore the proposition is that we make a final catch of the possibility of a rogue inquisition in the function:
CvGameUtils.doHolyCitySeekAndDestroy()
where we make one final ask "can we conduct an inquisition?" before we go do it. The inquisition event is always fired from this function so it's a pretty good place to do it. I could unite that question under one function so that it only ever get's answered in one place. So if you are busy on other things I can write, test and submit:
def CvGameUtils.canTrain()
def CvGameUtils.cannotTrain()
def CvGameUtils.doHolyCitySeekAndDestroy()
def CvGameUtils.canInquisition()
@Dresdon
Thanks on the API docs. Question for you if you have got the time. At the moment inquisitors are invisible. This is an obvious exploit because you can use them as spies abroad. To make them visible is it as simple as toggling this tag in the xml?:
<bInvisible>1</bInvisible>
and does that mean that inquisitors then are subject to all the rules about open borders etc?
Cheers.