POLL: Does anyone want/use the achievement/steam stat code?

[Recursive]

There's a bunch of leftover code/memory in the DLL relating to achievements and Steam stats.

Achievements don't work in modded games, but when VP is used as a modpack, it's possible for it to continue to unlock achievements and increment Steam stats.

Is there anyone out there who wants this code to be kept in the VP DLL? I want to delete all of it in the interests of readability and small optimizations (removing as much unnecessary code/memory as possible), but I'd like to confirm that I'm not the only one who doesn't care about it.

 

[InkAxis]

I dunno, I guess I had this idea that maybe when VP Gold releases then a stable modpack can be created and it would be just like playing the game. It does feel a little strange, I am about to hit 1000 hours in the game, yet I only have a handful of achievements.
But ultimately I'm not even sure if I will ever play on a modpack and even if I did I probably wouldn't care about achievements. So I voted "no strong feelings".

 

[looorg]

Cut it.

 

[Grassland Farm]

I voted No but am curious to know if you could estimate how big the performance boost would be by scrapping it. Maybe for the next Beta and see how it feels?
I'm the kind of player that really doesn't give a damn about achievements unless they are suggestions for an interesting playthrough (EU4 has a few good ones for that)

 

[Recursive]

The performance benefits would be minimal, and the memory impact is fairly low. Like I said, small optimizations. I mostly want this for the sake of making the code more readable/relevant.

The next version should include substantial improvements to both memory and performance, by the way, thanks largely to IanE9's solid work.

 

[azum4roll]

I only play in modpacks and the achievements help me keep track of which civ I've used to win.

 

[James Ryle]

I vote terminate, rip or even rend the achievement code.

 

[HungryForFood]

I've yet to get most of the achievements (I started Civ 5 with VP), would be great to have an option to do so.

Usually the achievement code is on an if then block within existing code, so I don't really see the harm of leaving them in.

 

[legoras]

Keep it.

 

[Recursive]

If 15% want to keep it we can. It's low impact anyway.

 

[2506]

If 15% want to keep it we can. It's low impact anyway.

When a super-majority wants to lose it (never mind a consensus) I suggest going along with that opinion.

 

[Recursive]

When a super-majority wants to lose it (never mind a consensus) I suggest going along with that opinion.

I would agree with you if the code had any sizeable impact on performance or memory. To me this is similar to including the diplomacy AI options. The people who want to play one way can, and the others can not.

What I will do is ensure it's all behind an #if defined check so it has no impact on ordinary players.

 

[InkAxis]

Yeah I think in this case we should keep it, the main impact is that it makes the code harder to read but unless we see that nearly nobody uses it, it should stay.

 

[Recursive]

As of the latest version, all achievement code is turned off by default, since most wanted it gone.

To enable it again, go to Community Patch/Core Files/PNM Mods DB/ACHIEVEMENTS/Achievements.xml and set API_ACHIEVEMENTS to 1.

I believe the code still won't work in multiplayer or in a normal modded game, only in modpack mode for singleplayer.

 

[tu_79]

What? Are there achievements?

 

[Recursive]

What? Are there achievements?

Steam achievements.

 

[tu_79]

Steam achievements.

I guess I won't miss them

 

[MEQ]

I dunno, I guess I had this idea that maybe when VP Gold releases then a stable modpack can be created and it would be just like playing the game. It does feel a little strange, I am about to hit 1000 hours in the game, yet I only have a handful of achievements.

I had that same idea, using VP Gold for getting all achievements! I really wish they had left that achievement code .

 

[arievillo]

The next version should include substantial improvements to both memory and performance

 

[Rekk]

Necro'd from July