TPEHEP
Prince
We need a building that will make contact with all civilizations in the modern era+ (for all civilizations, not WW; NW maybe). On my map "two planets" it's very important
Space Colonization modmod
- Thread starter pepper2000
- Start date
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
TPEHEP: I will look into it and see if I can do that. Is there another wonder that I could use as a template?
TPEHEP
Prince
The same time, these functions were at the Ishtar Gate in C2C.
A little thought, I believe that this should even be a miracle, but a technology. Something after the satellites.
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
It looks like the special function of the Ishtar Gate is done through Python code. I haven't yet tried to put any custom python into buildings, and I'm not sure if I can without editing some of the core files. I'll experiment with that, though it could be tricky.
Dancing Hoskuld
Deity
You should not need to edit any core files with the BUG Modular Python we use. Let me know if I can help.
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
Thanks DH. I've been looking at some of the existing files and trying to figure it out. I will ask you if I need help.
Dancing Hoskuld
Deity
Roughly speaking there are four files needed when doing python for a building.
- Config\Init.XML This file tells BUG what configuration files should be used when putting the modular python together
- Config\(name).XML This is the file that tells BUG what the name of the python files are and what events it calls. Events are those normally defined in the EventManager.py which in non BUG systems contains all the python code in one file.
- Python\(modder\module name)\(module name)_EM.py This contains the main python control code. The name is the standard I use but others may use a different naming structure and sometimes we have many of these in one folder so as to show who provided the original code.
- Python\(modder\module name)\(module name).py Completely optional as the code can be put in the _EM file. I usually have it in this separate file because I can have it contain the code from the original here making it easier to keep it up to date if the source modder is actively improving the mod.
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
Thanks a lot, DH. I am working on a Digital Embassy national wonder that I hope will fulfill TPEHEP's request, but for now I am trying to see if I can get python to work at all.
I added the following line to Assets\Config\init.xml:
Also in Assets\Config, I added the following file, Pepper2000Buildings.xml:
Finally, I created the folder Assets\Python\Pepper2000 and added the file Pepper2000Buildings.py with the following content:
That's not the actual intended effect, of course. I wrote some code that I expect to set the player's gold to 12345 upon completion of any building, so it should be easy to see if it's working. But there's no effect. What am I missing?
I added the following line to Assets\Config\init.xml:
Code:
<load mod="Pepper2000Buildings"/>Also in Assets\Config, I added the following file, Pepper2000Buildings.xml:
Code:
<?xml version="1.0" encoding="ISO-8859-1" ?>
<!--
Pepper2000's wonders: python code
-->
<mod id="Pepper2000Buildings" module="Pepper2000Buildings">
<event type="buildingBuilt" function="onBuildingBuilt"/>
<init/>
</mod>Finally, I created the folder Assets\Python\Pepper2000 and added the file Pepper2000Buildings.py with the following content:
Code:
## Buildings for the Space Colonization projects
## by Pepper2000
from CvPythonExtensions import *
import CvUtil
# import CvScreensInterface
import CvDebugTools
# import CvWBPopups
# import PyHelpers
# import Popup as PyPopup
# import CvCameraControls
# import CvTopCivs
# import sys
# import CvWorldBuilderScreen
# import CvAdvisorUtils
# import CvTechChooser
gc = CyGlobalContext()
# globals
###################################################
def onBuildingBuilt(argsList):
'Building Completed'
pCity, iBuildingType = argsList
game = gc.getGame()
iPlayer = pCity.getOwner()
pPlayer = gc.getPlayer(iPlayer)
pPlayer.setGold(12345)That's not the actual intended effect, of course. I wrote some code that I expect to set the player's gold to 12345 upon completion of any building, so it should be easy to see if it's working. But there's no effect. What am I missing?
Dancing Hoskuld
Deity
You do need to "import sys" I think.
Are you getting any Python errors either to screen or in any of the Python Logs? Do you have the logs on plus Python Exceptions on.
edit Also you should do a check for invalid/null pCity and posibely non negative IBuildingType, but they would cause errors.
Are you getting any Python errors either to screen or in any of the Python Logs? Do you have the logs on plus Python Exceptions on.
edit Also you should do a check for invalid/null pCity and posibely non negative IBuildingType, but they would cause errors.
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
No errors coming up. It appears that the python code is not loading at all. I tried inserting some clear bugs and they weren't picked up. Could it be that BUG is failing to find the Pepper2000Buildings.py file? Is there some file naming/placement convention that I might be violating?
Dancing Hoskuld
Deity
If it was loading you would get an error because you have the <init/> in the config XML but no def init: in the code. This suggests the problem is the init.xml. Post it and I will have a look.
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
Here's the init.xml as it is now.
The only change is the line <load mod="Pepper2000Buildings"/> near the end.
Spoiler :
The only change is the line <load mod="Pepper2000Buildings"/> near the end.
Dancing Hoskuld
Deity
OK that looks fine. Give me a copy of the three files and I'll have a look.
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
Most appreciated. The three files are in this zip file.
Dancing Hoskuld
Deity
interesting, so far I have managed to show that it is actually loading the module, now to see if it is calling the buildingBuilt stuff correctly. It mat be that one of the other modules is using that event and instead of doing the same as continue through the code it is exiting the code saying it is all done.
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
Thanks DH. Any more insight into the issue? My understanding is that all modules that want to execute code upon the completion of a building use the buildingBuilt event, and so when a building is built, the buildingBuilt event triggers and calls every function tied to it. The functions then should match whatever I call it in the python module, but seems typically to be called onBuildingBuilt. Is that correct?
Also, does the file structure in the Python directory matter?
Also, does the file structure in the Python directory matter?
Dancing Hoskuld
Deity
No sorry distracted with RL.
Yes but if one of them has return 1 then it will stop any others being run. So we need to look at all the modules that have the buildingEvent and check they are not doing that.
Yes but if one of them has return 1 then it will stop any others being run. So we need to look at all the modules that have the buildingEvent and check they are not doing that.
pepper2000
King
- Joined
- Apr 14, 2013
- Messages
- 899
OK, thanks. I looked through the other modules and didn't find any return statements in an onBuildingBuilt function, but it is possible that I missed it.
If all else fails, I think I could put my code in another module that is loading properly.
If all else fails, I think I could put my code in another module that is loading properly.
Dancing Hoskuld
Deity
I put trace (BUG) prints in and it was initialising fine, I added an init function but it was not doing the onBuildingBuilt function at all.
Faustmouse
Deity
- Joined
- Jan 31, 2012
- Messages
- 3,524
How are you coming along with the python code? 
And will the next version of your modmod be compatible with this one? I.E. if I'd make a map using all your terrrains, will it still be playable in the next version?
And will the next version of your modmod be compatible with this one? I.E. if I'd make a map using all your terrrains, will it still be playable in the next version?
Similar threads
