The Modding Q&A Thread

LuKo · Jul 7, 2011

Negative food consumption works fine. Illegal math operations usually make DLL unable to compile. But the main problem is that I'm a programming noob and I don't know how to debug

(OK, let's say I can make a debug DLL. But I have no idea how to use it).

[EDIT]: Yay! Thanks a lot! AI got negative income (due to costly specialists) and that caused crash

civ-addicted · Jul 16, 2011

Does anyone know how it's enabled (in the code, not the game) that you can build an embassy? It would be sweet if it's in python

Baldyr · Jul 16, 2011

Look in CvGameUtils.py, probably under canBuild() or something.

edit: Nope, it turns out that CvGameUtils isn't even used in RFC. The code has probably been moved to the DLL.

civ-addicted · Jul 16, 2011

Baldyr said:
Look in CvGameUtils.py, probably under canBuild() or something.

edit: Nope, it turns out that CvGameUtils isn't even used in RFC. The code has probably been moved to the DLL.

*shaking fist at the sky*
Drat.

LuKo · Jul 19, 2011

How do I check if a player has won the game? I need it in Python (to make it more than stable) and in C++ (permanent golden era).

Baldyr · Jul 19, 2011

It seems that players don't win games, but rather teams do. So I'd suggest using CyGame.getWinner() which returns the TeamType of the winning team. In RFC this matches the PlayerType of the winning player, which solves your problem. I'm guessing its CvGame.getWinner() in C++ then.

J. pride · Jul 20, 2011

Can somebody please post instruction on making minor changes and recompile because nothing i do is working. I have already tried reading Asafs direction but they are not working for me.

Any help would be appreciated.

LuKo · Jul 20, 2011

@Baldyr: Thanks a lot! But you are a Python wizard so can you post a line of code checking winner? Are you back home? Because captured() in PyScenario awaits

[EDIT]:

Code:

		if iBuildingType == CvUtil.findInfoTypeNum(gc.getBuildingInfo, gc.getNumBuildingInfos(), "BUILDING_ARCOLOGY_SHIELDING"):
			pCity.setNumRealBuilding(CvUtil.findInfoTypeNum(gc.getBuildingInfo, gc.getNumBuildingInfos(), "BUILDING_ARCOLOGY"), False)
		elif iBuildingType == CvUtil.findInfoTypeNum(gc.getBuildingInfo, gc.getNumBuildingInfos(), "BUILDING_DEFLECTOR_SHIELDING"):
			pCity.setNumRealBuilding(CvUtil.findInfoTypeNum(gc.getBuildingInfo, gc.getNumBuildingInfos(), "BUILDING_ARCOLOGY_SHIELDING"), False)

Why the above code (below onBuildingBuilt() at CvEventManager) doesn't work? It's copied from Next War but unluckily doesn't remove arcology (shielding).

Baldyr · Jul 20, 2011

LuKo said:
@Baldyr: Thanks a lot! But you are a Python wizard so can you post a line of code checking winner?

Where/when do you need to run said code? What is the context, so to speak?

LuKo said:
Are you back home? Because captured() in PyScenario awaits

I'm back home, but somewhat pressed on time, still. But keep bugging me. :lol:

LuKo said:
Why the above code (below onBuildingBuilt() at CvEventManager) doesn't work? It's copied from Next War but unluckily doesn't remove arcology (shielding).

Did you try it in CvRFCEventHandler?

LuKo · Jul 21, 2011

I want to set winner's stability to 100. Where and what should I place?

Instead of CvEventManager? I will, thanks! [EDIT]: Doesn't work

Baldyr · Jul 21, 2011

LuKo said:
I want to set winner's stability to 100. Where and what should I place?(

You hack into Stability.py at the end of the beginGameTurn() method (or whatever its called) and put in:

Code:

                        iWinner = gc.getGame().getWinner()
                        if iWinner != -1:
                                self.setStability(iWinner, 100)

You might have to use None instead of -1 in the conditional statement. :dunno:

The above code should override any Stability calculations on that turn for the winner with a 100 value.

It might be more efficient to use the onBeginPlayerTurn() method instead, but then you'd have use iPlayer instead of -1 in the conditional. The potential efficiency would come from putting the script at the top of the method (instead of at the end) and add a return statement. Because then it isn't necessary to go through any of the player specific Stability calculations for the winning player.

Further efficiencies could be gained by adding a new custom stored value, because then the winner would only be checked until this value is set to anything else than -1 (default). Then the actual code would check this value each turn instead of making a call to CyGame.getWinner(). I don't actually know whether this is faster or not however.

LuKo · Jul 21, 2011

"def checkTurn(self, iGameTurn):"?

I've pasted there and it worked... once. When I loaded and ended turn my stability had risen to 100 but since then fallen to 80, and less and less to ~25. Python is very strange, indeed.

Baldyr · Jul 21, 2011

LuKo said:
"def checkTurn(self, iGameTurn):"?

Yeah, that one.

LuKo said:
I've pasted there and it worked... once. When I loaded and ended turn my stability had risen to 100 but since then fallen to 80, and less and less to ~25. Python is very strange, indeed.

There is, of course, a logical explanation. Lets add some debug lines:

Code:

                        iWinner = gc.getGame().getWinner()
[COLOR="Red"]                        print "The winner is... player " + str(iWinner)[/COLOR]
                        if iWinner != -1:
                                self.setStability(iWinner, 100)
[COLOR="Red"]                                print "current Stability: " + str(self.getStability(iWinner)) + " (Gameturn " + str(iGameTurn) + ")"[/COLOR]

Now, make sure that logging is enabled in the main INI file and keep an eye on your Python Debug Log. You, of course, have enabled Python exceptions so that is not an issue. Right?

If it turns out that the CyGame.getWinner() method only returns the winning TeamType on the actual game turn of the victory, then we're forced to make our own custom stored value for keeping track of the winner. No big deal, really.

LuKo · Jul 21, 2011

You, of course, have enabled Python exceptions so that is not an issue. Right?

I was sure I had XD Nevertheless, it's not an issue (but thanks for forcing me to check because you've solved my other problem XD ). What should I set to 1 to enable logging? Just one thing in .ini? (I did it and got nothing interesting, so I guess I need to enable message logging?) I'll check a few things more and hope it works.

BTW: my C++ script works, so I guess winner is working

Baldyr · Jul 21, 2011

I'm not entirely sure what you should do in the INI file, but I guess there is something that enables logging in there. The Python Debug Log can be found at \Documents\Games\Beyond the Sword\Logs\PythonDbg.log

RFC prints a ton of useful stuff in there, and also note that PyScenario has a debug logging setup (disabled by default, but you can find the boolean controlling this at the start of the PyScenario module). The latter is of course mostly for my own personal use, but anyone can enable it and see what some of the code does from turn to turn.

LuKo · Jul 21, 2011

Yeah, I found the log, but I can't find any line that I want to find there:

Spoiler :

Baldyr · Jul 21, 2011

That suggests that the code isn't being run, which in turn suggests that something is interupting it, like a return statement, somewhere within the checkTurn() method.

Lets try using checkPlayerTurn() instead?

Code:

        def checkPlayerTurn(self, iPlayer): #writing from memory, obviously you don't replace the default definition line!

                if gc.getGame().getWinner() == iPlayer:
                        self.setStability(iPlayer, 100)
                        return

LuKo · Jul 21, 2011

There is no such a thing in Stability.py. In checkTurn() htere is something like that:

Code:

                for iPlayer in range(iNumPlayers):
                        
                        if (gc.getPlayer(iPlayer).isAlive()):

but when I tried to paste your piece of code there the exceptions didn't allow me to turn the game on.

Baldyr · Jul 21, 2011

Your right, I actually checked. It seems, instead, that my original code was wrongly indented. This should make more sense (still at the end of the checkTurn() method).

Code:

                iWinner = gc.getGame().getWinner()
                print "The winner is... player " + str(iWinner)
                if iWinner != -1:
                        self.setStability(iWinner, 100)
                        print "current Stability: " + str(self.getStability(iWinner)) + " (Gameturn " + str(iGameTurn) + ")"

LuKo · Jul 21, 2011

I'll check it tomorrow but I've deleted two tabs in previous code and it wasn't working.

The Modding Q&A Thread

The Royal Guard

King

"Hit It"

King

The Royal Guard

"Hit It"

King

The Royal Guard

"Hit It"

The Royal Guard

"Hit It"

The Royal Guard

"Hit It"

The Royal Guard

"Hit It"

The Royal Guard

"Hit It"

The Royal Guard

"Hit It"

The Royal Guard

Similar threads