UI - Map Pins

[whoward69]

...\My Games\Sid Meier's Civilization 5\config.ini

Change

; Enable the logging system
LoggingEnabled = 0

to

; Enable the logging system
LoggingEnabled = 1

 

[bladex]

weird the sob didn't do it this time maybe v4 fixed it? however i did find out something else. if you load a game ALL the pins reappear again even the ones you deleted. after loading a saved game i was surprised to see 20+ pins back again!

 

[whoward69]

weird the sob didn't do it this time maybe v4 fixed it?

Unless it's a timing issue and all the debug prints are slowing it down (and as the UI doesn't seem to be multi-threaded I very much doubt that) the two very minor bug fixes in v4 wouldn't have fixed it ...

however i did find out something else. if you load a game ALL the pins reappear again even the ones you deleted. after loading a saved game i was surprised to see 20+ pins back again!

And I definately can't replicate that (and that was tested extensively before release).

At a guess, the internal table of pins in your game had somehow become corrupted (probably by a memory leak from some other game component), which would stop you editing them and also mean that when they were deleted from screen they wern't deleted from the saved game database. Reloading the game would have fixed the table, but also reloaded the "deleted" pins.

If you stick with v4 and logging on, should it happen again I'd be interested in the lua.log file.

Thanks for the feedback/info

W

 

[bladex]

ok it did it again and it was doing some weird things this game too

1st it did the couldnt right click on a pin and all the pins vanished from the panel. than it did something even weirder later if i right clicked an unelectable pin somewhere else on the map it would select 1 of the pins b4 i couldn't select and i could than delete it so in other words i right click a pin and the menu to delete it etc appeared somewhere else on the map!

than it got really weird the pins i was adding after this most of the time changed colour, were blank text and sometimes they even copied existing pins names i already had on the map...

anyway here's the log

 

[whoward69]

Thanks for that, I've got the log so if it's taking up space on a server you can remove it

 

[whoward69]

Right, I now know what the problem is (my code) so I just need to work out how to fix it, but first I must write out 100 times

"Lua is not Java, nil is not null"

 

[bladex]

great i'll look forward to the fix. this is 1 of my fav and most useful mods

 

[whoward69]

Version 5 now on the ModHub.

Fixes the issue where deleting a pin from the middle of the list caused the pin(s) at the end of the list to be lost, eg, place pin A, B and C, delete pin B and pin C vanished as well

 

[whoward69]

Version 7 now uploaded, no longer modifies WorldView.lua

 

[glider1]

Right, I now know what the problem is (my code) so I just need to work out how to fix it, but first I must write out 100 times

"Lua is not Java, nil is not null"

Well done whoward thanks for the mod and your work will live for a very long time now that it is in VEM mod.

The one I have trouble is that I must write out a hundred times "NULL is not null".

Cheers

 

[bladex]

found another bug

if you use this with the Unofficial Patch and Vanilla Enhanced mod when you go to place a pin it will try to place another right after you have to click esc otherwise wherever you click next the pin place menu appears.

 

[whoward69]

found another bug

if you use this with the Unofficial Patch and Vanilla Enhanced mod ...

Needs reporting in the UP/VEM threds then

 

[Seek]

found another bug

if you use this with the Unofficial Patch and Vanilla Enhanced mod when you go to place a pin it will try to place another right after you have to click esc otherwise wherever you click next the pin place menu appears.

Map Pins is now included in CivUP, so enabling it again is redundant and probably the source of your bug.

 

[bladex]

oh i c

 

[JayeD]

Hi, first off, this is a great mod. I've just decided to start playing Civ 5 again and one thing I miss from Civ 4 is being able to put notes on the map.

I have this mod and the auto pin mod installed and nothing else and I've noticed a couple of things I'm not sure are right.

First, auto pins doesn't seem to pin unworked resources. I've travelled around and a City State has been pinned, as has a natural wonder, but resources are never pinned. From the title I thought they would be.

Second, the move option doesn't seem to work. I right click and select "Move" and the cursor changes to the 4 arrows but nothing I do next works. Left click does nothing, middle click does nothing and right click moves a unit I may have selected rather than the flag.

Third, a couple of maybe improvements, auto pin barbarian camps, be able to toggle the text to visible on the map rather than having to hover over the pin (I realise that this depends on what is capable with Civ 5 modding).

 

[whoward69]

First, auto pins doesn't seem to pin unworked resources. I've travelled around and a City State has been pinned, as has a natural wonder, but resources are never pinned. From the title I thought they would be.

Auto pins only pins unworked resources when they are revealed by researching a tech - so when you reseach Biology and Oil is revealed within your current territory it will "pin" each revealed resource (so you can later find them easily to send a work out to convert that farm into a well)

Second, the move option doesn't seem to work. I right click and select "Move" and the cursor changes to the 4 arrows but nothing I do next works. Left click does nothing, middle click does nothing and right click moves a unit I may have selected rather than the flag.

Ta - I've added this to the list of things I need to investigate between the 511 and 674 patches

Third, a couple of maybe improvements, auto pin barbarian camps, be able to toggle the text to visible on the map rather than having to hover over the pin (I realise that this depends on what is capable with Civ 5 modding).

"UI - Overlay Barbarians" already does a good job of tracking barbarian camps - especially after adopting Honor.

I have a few "improvements" planned that would allow the placing of text instead of a pin (map labels anyone?), but I'm currently swamped with the 674 patch and the impending G&K release, so they may be some time coming.

Thanks for the feedback

W

 

[JayeD]

Cool. Thanks for explaining unworked resources. Is a possible improvement to add the resources at the start too? Also, what happens if you expand into borders over a resource? I'm guessing it isn't auto-pinned right now?

tbh, this adds a much needed feature for me. I can't believe that it was removed between Civ 4 and Civ 5.

 

[bladex]

how do you use auto pin i've never seen that option? resources etc dont autopin for me? i have v10

 

[whoward69]

It's an additional mod - "UI - Auto Map Pins"

 

[whoward69]

Version 12 (just uploaded to Workshop) is now compatible with Gods & Kings (as is the version of Auto Map Pins on the Workshop)