What needs fixing before we release V34

[Singularity125]

Yeah, I have a bit more familiarity with Git (Stash specifically, we use it at work) and I think Github does free hosting for open-source projects too. And has its own bug tracker. On the other hand, that would probably be a pretty big move for a project this size...

 

[olduser]

Sourceforge also has Git.

 

[Singularity125]

Python 2

Frankly speaking, I will suggest the Volcano event.
That stuff is simpler to fix

Hm, I can look at that I suppose. From what I read, it sounds like the issue is that new volcanoes can spawn on top of cities? I think I have found the relevant python code:

##### VOLCANO C2C #####
def canDoNewVolcano(argsList):
  kTriggeredData = argsList[0]
  pPlot = gc.getMap().plot(kTriggeredData.iPlotX, kTriggeredData.iPlotY)
  ft_volcano = gc.getInfoTypeForString('FEATURE_VOLCANO2')
  ft_volcano2 = gc.getInfoTypeForString('FEATURE_VOLCANO')
  
  if pPlot.isCity() or (pPlot.getBonusType(-1) != -1) or (pPlot.getFeatureType() == ft_volcano) or (pPlot.getFeatureType() == ft_volcano2):
    return false
  
  return true

But nothing there really looks out of place. That means I would need to dig into the dll code after all? I don't see any python code that calls this method, though I could be looking in the wrong place. Also, is there a save somewhere that reproduces this issue? Couldn't find it in the big bug thread.

 

[Dancing Hoskuld]

Rightfuture and I are working on this, although I was waiting for a response from him, perhaps our communication got messed up over the holidays.

You have found the right code but I think it may be being called at the wrong time as well. there are four or five events all which call the same bit of python and the python then needs to figure out which event was calling it. I think this is just too complicated and we should split the code into one bit per event. Where the event has the same effect eg eruption then a common function can be called to do the work.

In fact what I think is happening is that the "existing volcano erupts" or "dormant volcano erupts" events are happening when there is no volcano on the plot OR the "new volcano erupts" is happening but a plot for it is not supplied but the city plot is supplied.

 

[Yudishtira]

In this save I had volcanoes spawn on the Hittite (definitely) and Sumerian capitals as well as Lagash (iirc) a Sumerian city of mine. Just click end turn...

 

[Dancing Hoskuld]

Thanks. It is getting too hot to anything today - supposed to be reaching 40 degrees C and I don't have an air conditioner. I think I'll go visit some friends and leave this until it is cooler.

 

[strategyonly]

Thanks. It is getting too hot to anything today - supposed to be reaching 40 degrees C and I don't have an air conditioner. I think I'll go visit some friends and leave this until it is cooler.

Dang we are getting a snow storm right now, YOU can have it!!!!!

 

[Hydromancerx]

Here in Southern California its in the 70's F (20's C). You both live in horrible places

 

[olduser]

I think a tracker could help alot because in the forum many things can get lost.
We already have a bug tracker in the Sourceforge Project but we need the rights to use it. I write a PM to Koshling and ask if he can give all modders the rights to use it.

Also Branches can help alot if you know how to use them right. But i think Branches arent really good in SVN newer version-control like Git has better support for them.

We have now access to the Bug Tracker in the Sourceforge Project. Nobody is forced to use it but it can help to prevent bug reports getting lost.

 

[strategyonly]

We have now access to the Bug Tracker in the Sourceforge Project. Nobody is forced to use it but it can help to prevent bug reports getting lost.

I believe its better for use for the C++ people and python personnel who understand what they are doing or talking about for this. btw thx Koshling for opening this again.

 

[Daedwartin]

Dang we are getting a snow storm right now, YOU can have it!!!!!

We gladly take the Sierra Nevada getting a 2 month snow storm.
that way we can at least get time to implement more methods to get water from non-snow pack sources.

 

[SargontheGreat2]

I'm on the Mid-Atlantic, and we are getting plenty of snow this winter

 

[Sparth]

In Europe there is no winter at all

 

[strategyonly]

In Europe there is no winter at all

I thought i had snow when i lived in Germany

 

[Faustmouse]

Eons ago.... myths say thaat there was snow once in germany.....

Well, normally there is plenty of it at some time in the winter. Last year around the middle of january, we had -18 °C during the night and till -10 °C during the day...

 

[Sparth]

I thought i had snow when i lived in Germany

In this year
Polar Vortex move to N. America and bring hot air to Europe in this year.

 

[SargontheGreat2]

 

[olduser]

I thought i had snow when i lived in Germany

Not this winter at the moment we have only a bit snow in the mountains.

 

[JosEPh_II]

Germany had plenty of snow in the winter of '74-'75 and lots of black ice on the roads too. Maybe that was the "eons ago" timeframe.

We've already had our share of snow and sub zero temps here in western IL. too. This all needs "fixed" for the v34 release you know.

JosEPh

 

[strategyonly]

Germany had plenty of snow in the winter of '74-'75 and lots of black ice on the roads too. Maybe that was the "eons ago" timeframe.

We've already had our share of snow and sub zero temps here in western IL. too. This all needs "fixed" for the v34 release you know.

JosEPh

Yeah i lived there from late '75 to early '79