1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

1.20 bugfix patch

Discussion in '[MAC+WIN] Civ4 - History Rewritten' started by Xyth, Jun 7, 2013.

  1. Xyth

    Xyth History Rewritten

    Joined:
    Jul 14, 2004
    Messages:
    4,054
    Location:
    Aotearoa
    A small patch for 1.20 that fixes the following issues:

    Traits
    • Humane: longer Golden Age bonus reduced to 50% from 100%

    Civics
    • Equal Rights: Golden Age length reverted to 1/2 length
    • Warrior Code: Golden Age length reverted to 1/2 length

    Religions
    • Inquisitors can now properly trigger inquisitions

    Wonders
    • Colosseum: fixed several errors preventing it from working
    • Jetavanramaya: Golden Age length reverted to 1/2 length
    • Nazca Lines: grants a Great Spy instead of a Spy

    Improvements
    • Pollution no longer removed when building one polluting improvement over another
    • Removed a debugging message whenever improvements are built

    Misc
    • Fixed several errors with Golden Age length calculations
    • Fixed an error when placing cities using advanced start
    • Fixed an error that could cause certain civics to not function for some players
    • Fixed an error when playing maps with preselected civics or improvements​



    There are 3 files, replace the existing versions in the following locations:

    1) /History Rewritten/Assets/Python/CvEventManager.py
    2) /History Rewritten/Assets/Python/HR.py
    3) /History Rewritten/Assets/XML/Text/HR_Traits_CIV4GameText.xml

    Applying this patch shouldn't break any games in progress, but let me know if it does.


    EDIT: Patch updated 25th July 2013
     

    Attached Files:

  2. myclan

    myclan Prince

    Joined:
    Feb 26, 2008
    Messages:
    584
    Warrior Code now give me a golden age of 11turns, how does it happen? 4×2(saga speed)×1.5(world wonder)=12turns?
     
  3. platyping

    platyping Sleeping Dragon

    Joined:
    Oct 22, 2010
    Messages:
    4,626
    Location:
    Emerald Dreams
    No issue.
    Warrior Code gives 8 for me.
    8 x 2(Saga) x 50/100 = 8 Turns
    With Humane Trait
    + (8 x 2 x 50/100) = 16 Turns

    Unless you have some buildings which increase GA length.
     
  4. Nightstar

    Nightstar Prince

    Joined:
    Apr 29, 2012
    Messages:
    408
    Gender:
    Male
    I noticed in 1.19 that if you get a Great General via being first to Logistics or from building the Brandenburg Gate wonder, then the Warrior Code GA will be one turn shorter than when you generate one through combat.
     
  5. myclan

    myclan Prince

    Joined:
    Feb 26, 2008
    Messages:
    584
    That's the case! I generate the GG via discovering logistics
     
  6. Xyth

    Xyth History Rewritten

    Joined:
    Jul 14, 2004
    Messages:
    4,054
    Location:
    Aotearoa
    I think it's due to rounding. Will investigate, assuming I don't scrap that bonus.
     
  7. myclan

    myclan Prince

    Joined:
    Feb 26, 2008
    Messages:
    584
    I think the reason maybe we get a GG first before the turn end, and the golden age start, what I see in the next turn is 1 turn of golden age has passes
     
  8. Nightstar

    Nightstar Prince

    Joined:
    Apr 29, 2012
    Messages:
    408
    Gender:
    Male
    Applied the patch and started a new Odyssey-speed game as Sejong (Humane/Progressive). Built the Mausoleum, then the Korean UW to start my first golden age... which will last for 72(!) turns?! I was expecting 36 turns.

    Then, during the AI's turn, I got a Python error (screenshots below), though I think that's unrelated to the golden age.
     

    Attached Files:

  9. Xyth

    Xyth History Rewritten

    Joined:
    Jul 14, 2004
    Messages:
    4,054
    Location:
    Aotearoa
    It should be 60 turns: 24 standard length, another 24 for the Mausoleum (+100%) and then another 12 for the Humane trait (+50%).

    That's another Colosseum bug, triggered whenever you build a unit in the city that doesn't have an Unique equivalent somewhere in game. I neglected to indent a block of code correctly in the bug fix.

    I'll get a fix up for both these issues shortly.
     
  10. Nightstar

    Nightstar Prince

    Joined:
    Apr 29, 2012
    Messages:
    408
    Gender:
    Male
    Unless you've changed it, the Mausoleum should only give +50%.
    This is particularly odd, as I don't believe the Colosseum has been built yet.
     
  11. Xyth

    Xyth History Rewritten

    Joined:
    Jul 14, 2004
    Messages:
    4,054
    Location:
    Aotearoa
    Ah you're right, thought it was +100% for some reason. So yes, in the above situation the total length should have been 48 turns.

    It might be triggering whenever a unit is built. Anyway, the patch in the first post has been updated with fixes for both these issues.
     
  12. Xyth

    Xyth History Rewritten

    Joined:
    Jul 14, 2004
    Messages:
    4,054
    Location:
    Aotearoa
    Patch updated 13th June 2013
     
  13. Nightstar

    Nightstar Prince

    Joined:
    Apr 29, 2012
    Messages:
    408
    Gender:
    Male
    Applied the patch, reloaded from a pre-GA autosave. Upon completing the UW I entered a 60 turn golden age. Shorter, but still longer than it should be.
     
  14. platyping

    platyping Sleeping Dragon

    Joined:
    Oct 22, 2010
    Messages:
    4,626
    Location:
    Emerald Dreams
    pPlayer.getGoldenAgeLength() takes into account XML modifiers from buildings etc
     
  15. Nightstar

    Nightstar Prince

    Joined:
    Apr 29, 2012
    Messages:
    408
    Gender:
    Male
    Same game as previous report, completed the National Sports League quest and took the free golden age reward. This time the length is the correct 48 turns instead of the 60 turns I got for building my UW. Not sure why they produced different results (Python vs XML triggered?).
     

    Attached Files:

  16. Xyth

    Xyth History Rewritten

    Joined:
    Jul 14, 2004
    Messages:
    4,054
    Location:
    Aotearoa
    Pretty sure I know what the problem is, just haven't had a chance to test or fix it due to whole family being ill.
     
  17. Xyth

    Xyth History Rewritten

    Joined:
    Jul 14, 2004
    Messages:
    4,054
    Location:
    Aotearoa
    Try this file and see if it fixes the aforementioned golden age length issues.
     

    Attached Files:

  18. Xyth

    Xyth History Rewritten

    Joined:
    Jul 14, 2004
    Messages:
    4,054
    Location:
    Aotearoa
    Patch updated 24th June 2013
     
  19. AluminumKnight

    AluminumKnight Conquistador

    Joined:
    Nov 7, 2004
    Messages:
    797
    Location:
    WI, USA
    Hi Xyth,

    Not sure if this has been reported already or if it's working as intended, but after updating to 1.20 I cannot give any promotions to my Battering Rams even though they have the XP. I can upload a save later if you need it.
     
  20. myclan

    myclan Prince

    Joined:
    Feb 26, 2008
    Messages:
    584
    The Mausoleum of Maussollos is again useless for short golden age?
     

Share This Page