3UC/4UC for VP: Project Coordination Thread

[pineappledan]

@adan_eslavo do you have any thoughts on the proposed changes to Hacienda, and my proposed change to Etemenanki?

Hacienda:

Spoiler :

Available at Civil Service
Can be built on any tile with no resource features (hills & flat terrain)
Cannot be built adjacent to another Hacienda
1/1/1
+2 on Hacienda for every Adjacent Bonus Resource
+2 on Hacienda for every Adjacent Strategic Resource
+2 on Hacienda for every Adjacent Luxury Resource
+1 on Hacienda if Adjacent to City
+1 on Hacienda if worked by a City with a Mission

+1 at Architecture
+1 / at Fertilizer.

I don't want to touch it if you don't like the changes; it was your UC after all

Etemenanki: Restrict the food and Science on purchase to building investments only (so it ties more directly to

 

[Blue Ghost]

I asked around, and it seems that there is no Lua hook for demanding tribute from major civs.

The current description for the Alti Cur says it gives 50 Science and 100 Gold for demanding tribute. Is that what you want, or would you rather have the +5 happiness? The easiest way to implement the +5 happiness is by an event, but that has the downside of not being stackable (so multiple instances of demanding tribute will not give more than +5 happiness).

The PlayerBullied event seems to work for demanding regular tribute, but not for heavy tribute. @Infixo, would you know anything about this? Is there a separate hook for demanding heavy tribute? Is this a bug in the DLL that needs fixing?

 

[adan_eslavo]

Etemenanki can be done easily by deleting one function from lua.

Hacienda will be more problematic. Idea of adding yields from bonres and strres is good but it would require adding possibility of building hacienda next to them (not only luxres). It is not possible via sql (it uses now column "adjacenttoluxury"). If we not add that then it will be really rare bonus. We can leave luxres adjacency and leave some flat yields.

 

[Hinin]

Hacienda will be more problematic. Idea of adding yields from bonres and strres is good but it would require adding possibility of building hacienda next to them (not only luxres). It is not possible via sql (it uses now column "adjacenttoluxury"). If we not add that then it will be really rare bonus. We can leave luxres adjacency and leave some flat yields.

As always, I am not the one doing the work here, but I think that leaving only a adjacency bonus from luxury resources and scraping the rest would ruin the idea of the UI. The interest behind this UI is that, even if it can be put almost anywhere, the base yields are so poor for a UI at this stage of the game that putting Hacienda without consideration for the adjacencies will hinder your economy in the long run. Increasing the base yields of the UI would be detrimental to its whole concept...
What to do... Finally obtaining a Spanish UI with a proper identity would be a valuable asset for the modmod...

 

[WoodenThrone]

Hi! I know this is incredibly minor but, since America has a UB called a ranch, will it conflict balance with the Industrial Building Pack (which was balanced for VP by Enginseer's Community Balance Patch Mod Compatibility) which also contains a ranch on its own? Both bonuses seem fairly similar to each other.
If not then, just a small suggestion, but IF the mod is installed with 3UC/4UC maybe have America's ranch (and probably rename it to Homestead(?) with the mix in reference to the Homestead Act which gave settlers easy access to American land ) replace the Industrial's ranch instead? The latter is available at the Industrial era (hence the name) but everybody knows America emerged at the time close to it, though maybe it'll ruin the structure of the UB quite a bit and is maybe straining coz the change will technically require 3 mods.

 

[Ziad]

@adan_eslavo

Hey adan

The Tophet issue I reported is from v. 27 so it's possibly not working as intended.

 

[adan_eslavo]

And last update was on 26.18.2 so before releasing v27. I'm checking that.

Found small error. If you want you can copy lua file from beta branch after I will update it.

@Ziad Ready. You can download lua for Tophet from Github. Savegame compatible.

 

[adan_eslavo]

I will check what can be done for inca.

 

[pineappledan]

I asked around, and it seems that there is no Lua hook for demanding tribute from major civs.

Ok... if that could exposed to lua via dll that would be magic; it’s up to the benevolent Infixo now.

The current description for the Alti Cur says it gives 50 Science and 100 Gold for demanding tribute. Is that what you want, or would you rather have the +5 happiness? The easiest way to implement the +5 happiness is by an event, but that has the downside of not being stackable

The happiness fits better thematically; legitimacy as a Xiongnu/Hunnic ruler depended on your ability to distribute wealth to the nobility, either via taxation or tribute. Being the “barbarian”-est civ, huns should probably not be getting a unique source of science

Would demanding tribute at least refresh the timer, and set it back to 30 turns? If it does, I think reducing the turns to 20 would be better; it would give more urgency. To compensate, increase the happiness to 6 on tribute, it is the “six horns council” after all. The six horns were the six chief princes/advisors of the hunnic empire, so 1 happiness for each.

adding possibility of building hacienda next to them (not only luxres). It is not possible via sql

This can be fixed by simply removing the luxury adjacency requirement. If built next to nothing, the hacienda is worse than a triangle farm, so it’s fine

@WoodenThrone, I have no issue with changing the name of the building to homestead, but it’s up to @Blue Ghost. For now, there won't be any mod conflicts

 

[adan_eslavo]

Ok, then I will rework Hacienda that way.

 

[pineappledan]

I can rework hacienda if you could check my work on the kabuki. Can you see if I goofed up on the lua, or see if there’s a way to make it better?

It does two things:
if a kabuki is built in a city with writer/artist/musician guild it replaces them with a unique Japanese guild
If a guild is built in a city with a kabuki in it it is immediately replaced by the unique Japanese equivalent

 

[adan_eslavo]

I did rework of Hacienda on beta branch. I will merge your github work to my branch and check Kabuki.

 

[pineappledan]

@Hinin, nothing seems to be wrong w.r.t. the japan unique guilds icons or the code to implement, that I can detect. The new art assets and the new lua have not been added to the .civ5proj file yet. Is it possible that you forgot to add the art files into your .modinfo file when you tried to test it?

@WoodenThrone I can't seem to find anything wrong with the implementation of the unique zulu names. maybe someone can verify if it all looks ship-shape, but nothing seems off to me. Did you update the !Gametext.xml file when you tried testing out the zulu unique names? You might have been using an old version of the game texts which didn't include entries for the zulu indunas

 

[Infixo]

Re: tribute demand and related
The event PlayerBullied (enabled by EVENTS_MINORS_INTERACTION) is only used for Minor Civs. In first case, when bullied for gold, you get (eBullly, eMinor, iGold, -1, -1, -1). The second case is when bullying for a unit. Then you get (eBully, eMinor, -1, eUnitType, iX, iY).
There is no event for demands from Majors, neither when human makes it nor when AI makes it (because there are 2 separate paths in the code for these).

 

[pineappledan]

It's just really weird that there's an entire lua category for deals, and scant few ways I can imagine you could use them if you can't trigger things off of diplo events

 

[Blue Ghost]

Bullying for a unit? How does that happen? I don’t recall that mechanic existing.
Is there a Lua hook for demanding heavy tribute? It would be weird if the bonus worked for regular tribute but not heavy.
If it’s a compatibility issue, I’d be fine with changing the name of the Ranch. The civillpedia text would have to be rewritten. @pineappledan , could you do that?

 

[adan_eslavo]

Ok, Kabuki is now working. I optimized code a bit. Later on I will look int o it more.

 

[pineappledan]

Yup, I can make the text switch
Switched

 

[adan_eslavo]

Added Inca description to my main post. Modified Celts and China descriptions.

Tomorrow I will look into Coca only probably. Does it work,without showing up in monopoly screen or it doesn't work at all?

 

[pineappledan]

Tomorrow I will look into Coca only probably. Does it work,without showing up in monopoly screen or it doesn't work at all?

It does not work at all, but the problem is with Coca not being recognized as a resource which can have a monopoly, not necessarily with the lua (though the lua might not work either, we don't know yet).

The lua is set to trigger if the boolean value for (1 - "has monopoly"/0 - "doesn't have monopoly"). The lua could simply calculate whether or not a monopoly exists itself: if(2*GetNumResourcesOwned(RES_COCA)=>GetNumResource(RES_COCA), but I thought it would be better if the lua worked using the existing sql.