PlayerTypes CyPlayer::getID() const
{
return m_pPlayer ? m_pPlayer->getID() : NO_PLAYER;
}
int CyPlayer::getID()
{
return m_pPlayer ? m_pPlayer->getID() : -1;
}
Fixed. Ironically it was an unneeded change, which was intended to catch bugs rather than cause them. I'm still not quite sure why it failed, but it looks like we better not change the return types of existing functions. It seems safe to do in C++ though and will catch certain types of bugs at compile time. I added a bunch of compile time tests as well as startup tests (non-release version) to the DLL and here it works as intended and they do catch bugs from time to time (usually before anybody has a chance to test something new manually). I figured if it's a success in the DLL, why not do the same to python? Well now we know why it shouldn't be done to python. Oh well. Most code is in the DLL anyway, with GUI code being the biggest exception and yes this was GUI code breaking.Could you please check what happened, fix it and let me know?
(I will then attach the corrected DLLs again.)
I could change and fix it myself but you seem to have changed it on purpose .
(I do not want to mess up something else, e.g. some other code you have coded for Domestic Advisor.)
Yes please.... but it looks like we better not change the return types of existing functions.
Nothing to apologize for.I apologize for causing such a panic ...
I would likely have panicked too because I changed the native advisor and nobody predicted this causing problems in other screens. Ok maybe not panicked, but it wouldn't have been fun.I apologize for causing such a panic))
Good point. It's the newest revision in the Challenge branch at the time of upload. Not the greatest versioning number. Makes me wonder if we can compile the revision into the DLL. I think I coded something like that for Medieval Conquest, but then it has the sideeffect of not compiling without having git installed. There are however ways around that as well. It would make sense to add the revision string to DLL, log at startup and savegames, particularly if it can be done automatically.We need to version these releases somehow. I hope we at least tagged the commit they were built from.
It is not an "exploit" in my opinion.I figured out an trader exploit.
I know that.Choose a Nation/Leader with an enterprising perk and established a trade post in an settlement (of a Native Leader) which has the trader perk ...
Confirmed.( Please confirm )