C2C SVN Changelog

[CIVPlayer8]

Updates:
-Mind Control gives slave specialist +1 gold
-Post Scarcity gives slave specialist -1 gold
-Changed the civic free buildings to the "Civic (Monarchy)" format

 

[Dancing Hoskuld]

Update

Disabled the capture of slaves and other captives until AI is written. If you already have them you can still use them you just wont be able to get more.

 

[ls612]

Updates:

-Added the Dai Chui and the Saxon Raider.

 

[Hydromancerx]

Updates
- Fixed Replicator Plant and Sculptors Workshop.

 

[Thunderbrd]

Major Traits update
Does not change trait details but does:

• Add Leader Levelups Game Option
• Add Start with No Positive Traits Game Option
• Adds New Buttons to traits
• Adds Flavor tags and applies initial values to traits for use in Leader Levelup AI

Also: Reverts previous addition of bfirstfreeprophet tag use on Animism.

Now as this updates, I'm off to go explain these new options in a new thread in the main forum!

 

[Dancing Hoskuld]

Update

- fix spelling of HadrianWall.bik in the XML so that the movie plays.

 

[ls612]

Update:

-Fixed the Imperial Guards.

Edit:

-Also changed some Era soundtracks.

This is three things. First there was quite a lot of diplomatic music being used as came soundtracks, which IMO is a bad thing, the two should be separate for the most part. The second was things being misplaced (UN music in the Classical Era for instance). The third reason was that some tracks didn't really fit thematically with the rest.

 

[Hydromancerx]

Updates
- Added Sculpture Factory, Soda Factory, Cheese Factory, Sausage Factory and Potato Chip Factory.

 

[olduser]

I found some small errors in the C++ code.

CvUnit.cpp missing (eIndex)

bool CvUnit::hasExtraFlankingStrikebyUnitCombatType(UnitCombatTypes eIndex) const
{
	return (getExtraFlankingStrengthbyUnitCombatType[COLOR="Red"][B](eIndex)[/B][/COLOR] != 0);
}

CvPlayer.cpp lines 12632 and 12683 missing ()

	//TB Traits begin
	if (getCivicAnarchyModifier[B][COLOR="Red"]()[/COLOR][/B] !=0)
	{
		iAnarchyLength += ((iAnarchyLength * getCivicAnarchyModifier())/100);
	}
	//TB Traits end

	//TB Traits begin
	if (getReligiousAnarchyModifier[B][COLOR="Red"]()[/COLOR][/B] !=0)
	{
		iAnarchyLength += ((iAnarchyLength * getReligiousAnarchyModifier())/100);
	}
	//TB Traits end

 

[Thunderbrd]

That would explain a few odd bugs being vaguely reported. I'll make sure to fix those up right away! Thanks for the spotting there.

 

[Dancing Hoskuld]

Update
- Allow cities to be built on plots with caves and reduce cost of moving through plots with caves.

 

[ls612]

That would explain a few odd bugs being vaguely reported. I'll make sure to fix those up right away! Thanks for the spotting there.

I've fixed those now on the SVN.

 

[Thunderbrd]

I've fixed those now on the SVN.

You got to it just before I did Thanks for helping there.

 

[Hydromancerx]

Updates
- Guilds civic now builds all Guild National Wonders 25% faster.
- Apprenticeship civic gives all Guild National Wonders +10% science to the city they are built in.

 

[ls612]

Update:

-Tweaked the Police Dog and the Canis Superior units.

 

[Dancing Hoskuld]

Update - sort of

- Update Story Teller line so that they do not remove all anarchy in one go. Not actually working. so basically it does remove the Story Teller function if not the unit.

@AIAndy, can you look at this as it looks like the same problem I am having elsewhere with setting up missions on units.

 

[Hydromancerx]

Updates
- Moved Forest Preserve improvement to Wilderness Conservation tech.
- Fixed Sages Hut.
- Fieldsman I now gives Double movement on Grassland terrain.
- Fieldsman II now gives Double movement on Plains terrain.

 

[Thunderbrd]

Bugfix round:

Updates
-repaired all detected issues with the Pure Traits option
-repaired issue with promotions being lost
-repaired numerous tag display issues, mostly regarding traits tags
-repaired city trade mechanism (wasn't working at all!)
-edited the Blitz tag filter on promos so that it will enable blitz for units that have extra move from sources other than their base infos.

Having some trouble with the internet committing these though...

 

[Koshling]

Bugfix round:

Updates
-repaired all detected issues with the Pure Traits option
-repaired issue with promotions being lost
-repaired numerous tag display issues, mostly regarding traits tags
-repaired city trade mechanism (wasn't working at all!)
-edited the Blitz tag filter on promos so that it will enable blitz for units that have extra move from sources other than their base infos.

Having some trouble with the internet committing these though...

I think there are some issues in here (I haven't studied it all but I was looking to see what you did with trade routes so I looked at CvCity.cpp):

No longer capping base yield modifier at 0 below. New code (in CvCity::getBaseYieldRateModifier()) is:

	// TB Note: The following was capped at a minimum of 0 but negative traits, etc... should create a negative potential.
	return iModifier + 100;

This used to be std:max'd with 0, and it needs to be. The number this returns is NOT the modifier - it is the actual percentage yield of the raw number that you get. So if you allow it to go negative you're effectively allowing a modifier below -100. The result will be that working tiles for 10 commerce vs 9 commerce (say) SUBTRACTS gold and SCIENCE instead of just adding less, which I can't believe is intended. This also applies to the changed assertion in setBaseYieldRate() and also in changeYieldRateModifier() - it may not be needed (probably redundant anyway) but what you have changed it to makes no real sense (if eIndex was negative it would already have crashed from using it BEFORE the assertion since it's a parameter in the previous call)

 

[ls612]

Bugfix round:

Updates
-repaired all detected issues with the Pure Traits option
-repaired issue with promotions being lost
-repaired numerous tag display issues, mostly regarding traits tags
-repaired city trade mechanism (wasn't working at all!)
-edited the Blitz tag filter on promos so that it will enable blitz for units that have extra move from sources other than their base infos.

Having some trouble with the internet committing these though...

You also did some other stuff like deleting old comments by other people and changing several assertions. What were those things for?