C2C SVN Changelog

[ls612]

Updates:

-Tweaked many Cannons and Siege Weapons
-Renamed the Atl-Atl
-Tweaked the Police Car.

 

[Thunderbrd]

I think there are some issues in here (I haven't studied it all but I was looking to see what you did with trade routes so I looked at CvCity.cpp):

No longer capping base yield modifier at 0 below. New code (in CvCity::getBaseYieldRateModifier()) is:

	// TB Note: The following was capped at a minimum of 0 but negative traits, etc... should create a negative potential.
	return iModifier + 100;

This used to be std:max'd with 0, and it needs to be. The number this returns is NOT the modifier - it is the actual percentage yield of the raw number that you get. So if you allow it to go negative you're effectively allowing a modifier below -100. The result will be that working tiles for 10 commerce vs 9 commerce (say) SUBTRACTS gold and SCIENCE instead of just adding less, which I can't believe is intended. This also applies to the changed assertion in setBaseYieldRate() and also in changeYieldRateModifier() - it may not be needed (probably redundant anyway) but what you have changed it to makes no real sense (if eIndex was negative it would already have crashed from using it BEFORE the assertion since it's a parameter in the previous call)

Well... OK, point taken about the main point there (particularly AFTER the 100 is added, yes. Should not go below that - you're right I was thinking it was a positive/negative scale modifier and I see how that was incorrect. I will gladly reverse that then.

On the others... the assertions were changed due to the fact that in many cases our civics and traits are in fact making those values negative and its more than annoying to have an unnecessary assertion popping up, particularly where they are allowed to go negative without any error (and I think in most of those cases they should be).

I checked the indexes because on rare occasion those will catch a crash scenario that got accidentally setup somewhere. True, I wasn't looking for any suspected current problems, but I figured they could help come to conclusions as to what a crash problem was due to faster if one were encountered after a future coding endeavor. You make a good point as to how ineffective those are though

Comments were taken out due to the buildup of clutter making it harder to follow the coding. I've stopped commenting as often due to the same and according to what Koshling has expressed, and I do agree, if we can cut down on some of it or at least minimize it some, then it'll make things easier for us. Afforess's comments are often a particularly aggressive form of comment that really makes it tough to read the code at times so usually that's where I might trim those a bit. No disrespect to the author. I think we all know most of this dll is his handiwork still.

 

[Dancing Hoskuld]

Update

- More Italian translations. Thanks to Hale_9204

 

[Thunderbrd]

Update
-Quickfix to traits infos to remove the test traits that shouldn't have been included in the last update.

 

[ls612]

Update:

-Fix for internal handling of promotions with Blitz. The AI is also aware of this fix.

 

[CIVPlayer8]

Updates:
-Changed many early civics maintenance and instability
-Added Gold Vault and Money Press Civic buildings
-Garbage to Sea gives more , but Garbage Dock gives more
-Banknote gives + with bank, Paper Money gives more
-Anarchism doesn't give with taxes, should help with barbarian cities not growing

 

[Dancing Hoskuld]

Update done yesterday I think

- can now build cities on caves
- almond gives health like all food resources should

 

[Hydromancerx]

Updates

- Added Agroforest, Algae Farm, Aquafarm, Coastal Preserve and Tree Nursery.

 

[Dancing Hoskuld]

Updates

- Added Agroforest, Algae Farm, Aquafarm, Coastal Preserve and Tree Nursery.

We already have an improvement called Tree Nursery iirc.

 

[Hydromancerx]

We already have an improvement called Tree Nursery iirc.

That's why I added it just like we have a Seed Camp Improvement and a Seed Camp building.

 

[strategyonly]

That's why I added it just like we have a Seed Camp Improvement and a Seed Camp building.

Whats he's trying to say is that YOU cant have 2 things named exactly the "same." It messes with the Civlopedia, and when checking through it, it will sometimes take the first "Tree Nursery" in the line and use that one, no matter if that one is the correct on or not. Because all it reads is "Tree Nursery." Just add something to the end of the name, or change it all together.

 

[ls612]

That's why I added it just like we have a Seed Camp Improvement and a Seed Camp building.

I really don't like that. It just seems like lazyness to me to make two things with the same name and description. I agree with SO that it can also mess up the pedia at times.

 

[Hydromancerx]

Updates:
-Garbage to Sea gives more , but Garbage Dock gives more

I am no sure if I like what you did with the Garbage Dock. The no unhealthiness from buildings was what made that building what it is. Now it just some health building. Its not really a special civic building anymore.

 

[Dancing Hoskuld]

Update
- Fix clone builds.
- Add art for vanilla but not the resource yet.

 

[Hydromancerx]

Updates
- Unscrambled the code for SO.
- Pushed Water and Air Pollution triggers back. Light Smog and Minor Ground Water Pollution do not start until 400 instead of 100. Minor Global Warming was moved back to 500. Which means no Global Warming triggers until 500 and over rather than 250.

 

[Dancing Hoskuld]

Updates
- Fix Temple of An. It should not require a state religion.
- Added map resource Vanilla. Something is wrong somewhere as it is not showing in the pedia but it is working in game.
- Added building Crab Nets but subdued crabs can't build it yet. I forgot that bit.

 

[ls612]

Updates:

-Added an option to scale City Limits by Mapsize.
-Fixed the Pirate Galley artdefine.
-Fixed the Airbase recalc issue reported by God-Emperor.

NOTE: Due to my incompetence I had to commit this in 2 parts, so make sure you update to the latest revision otherwise you will have a broken revision. Sorry.

 

[strategyonly]

Dont update, the current dll does NOT work, it crashes. . . SO

 

[ls612]

Dont update, the current dll does NOT work, it crashes. . . SO

Are you on revision 4565?

 

[strategyonly]

Are you on revision 4565?

Yes . . . .