Corrects a promotion update issue on upgrading units - in the process I've found a place that really needs streamlining, CvUnit::doSetFreePromotions... wow that's not efficient at all. I did not correct that but just the inaccuracy of how it was potentially overridden later in the upgrade process, which is another major timing inefficiency that I should probably do something to keep from happening - this free promo is assigned on init, removed because the original doesn't have it, and then re-assigned on convert. Ugh. 2 time improving projects to tackle at some point soon.
Reworked part of the modular loading system. Modular loading control features such as Dependency Types, Replacement Classes, and Force Overwrite are rewritten in clearer, concise code.
Through testing I separated items from TB Complex Traits that are dependent on custom religion modules into a new file. Note that you need to keep all of the replacement condition, replacement ID, and dependency type tags to fully qualify the xml data.
CvInfos codes are much cleaner without all the legacy partially dysfunctional copyNonDefaults methods to maintain. You just keep in mind that the anyInfo::read() functions are to be called twice, or however many times, to add more definition to an info object. Existing values should not be overwritten unless an optional tag is found in a modular xml data. This is the rule of thumb.
Also in CvInfos: Vectors utilizing the Delayed Resolution system can now be expanded to accommodate more values; My previous attempt was a failure but now it's bug proof.
A LOT are modified in this update. Some parts of my modifications are just makeshift code to make it work. They can be more refined later.
@ All
The removal of the multithreading from C2C should speed up the turn processing a bit. If this updates causes any issues please report them and maybe go back to 10920.
Fixed a counter not resetting when it should when filling the wonder tab with different types of wonders, which could cause lineshifts to happen even though the row is not filled and there hasn't been a category change (WW -> NW -> TW -> Project).
Bug was introduced when alberts fixed the potential for an un-initialized variable error in rev.10929.
10933
Adjust Chief's hut maintenance cost to be a Bonus again. Just not as much as before though, 7% instead of 10%. Have to keep the Old song "Too Much Gold" from being sung again and again.....and again....
This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.