FfH2 0.30 Bug Thread

[Joebasalt13]

Alright I am not sure if this is a bug or a feature. But in my current hotseat game I built Saverous like I always do (he's my favourite hero) Through the hero upgrading aswell as fighting I got up to 100 exp points. (the limit for the hero free points) Then Magdelene (Huge Monkey) popped up right beside my Saverous, so I clubbed him but never gained any exp, I have since killed many more people and still no more exp, I am stuck at 100...WHY?

Also Hyborem still gets points past 100, so why not Saverous?

 

[xienwolf]

Barbarian units cannot grant exp past 100. You have to kill the units belonging to another Civ to gain any more.

 

[Joebasalt13]

Really even Barbarian heros?

How bout the 4 horsemen? Are they considered barbarians?

 

[Kael]

So after poring over this for a while trying to figure out what I was doing wrong (I forgot to give the other civ knowledge of the ether so they could actually USE entropy mana nodes) here's some code to fix entropy mana so it uses the enemy's entropy bonus and not yours:

Original:

iTotalHeal += GET_PLAYER(getOwnerINLINE()).getHealChangeEnemy();

Changed to:

iTotalHeal += GET_PLAYER(pPlot->getOwnerINLINE()).getHealChangeEnemy();

in CvUnit::healRate

Good catch, I'll get it added.

 

[Kael]

Spoiler :

Are they supposed to be the same?

Nope, I'll fix it.

 

[BeefontheBone]

Really even Barbarian heros?

How bout the 4 horsemen? Are they considered barbarians?

Some of them grant bonus XP which applies over the 100 cap, but apparently not all.

 

[Kael]

Some of them grant bonus XP which applies over the 100 cap, but apparently not all.

No barbarian controlled unit will grant xp over 100. Be it an orc warrior, acheron or the avatar of wrath himself. You can occisionally get xp abvoe 100 from defeating these units but it is coming from another source (like the raider trait or an attached great commander).

 

[xienwolf]

Or them actually being a HN unit from another Civ.

 

[BeefontheBone]

No barbarian controlled unit will grant xp over 100. Be it an orc warrior, acheron or the avatar of wrath himself. You can occisionally get xp abvoe 100 from defeating these units but it is coming from another source (like the raider trait or an attached great commander).

Really? Looks like I imagined a change you made then

 

[Saien]

Upgrading the Nightwatch granted by founding Council to an assassin strips that unit of it's religion. I believe this is true for all unit upgrades and all religions.

Also, suggestion, allow recon units without religion to adopt the Council if they're in a city where it is present.

Suggestion 2: Allow the same for assassins and their upgrades for Aeron's Bounty.

Bug 2: The Guild page (Shift-F7) says "Wolf" under each icon.

 

[xienwolf]

Circle of Gaelan

Finally spotted why you get 2 Gaelan Hero units when you complete this sequence properly. Events/CIV4EventInfos.xml/Gaelan_3_2 has <UnitClass>UNITCLASS_GAELAN</UnitClass> <iNumFreeUnits>1</iNumFreeUnits>, while Gameinfo/CIV4CorporationInfo also has <FreeUnitClass>UNITCLASS_GAELAN</FreeUnitClass>. Should only grant you the free unit on one or the other of the two.

 

[Opferlamm]

No barbarian controlled unit will grant xp over 100. Be it an orc warrior, acheron or the avatar of wrath himself. You can occisionally get xp abvoe 100 from defeating these units but it is coming from another source (like the raider trait or an attached great commander).

ahh thats why my Lanun get XP from barbarian fights, cool

 

[Victorvanwavere]

I was checking the GlobalDefinesAlt.xml file in "Sid Meier's Civilization 4\Beyond the Sword\Mods\Fall from Heaven 2 030\Assets\XML"

and found these two entrees:
<Define>
<DefineName>ALIGNMENT_ATTITUDE_GOOD_TO_EVIL</DefineName>
<iDefineIntVal>-4</iDefineIntVal>
</Define>

<Define>
<DefineName>ALIGNMENT_ATTITUDE_EVIL_TO_GOOD</DefineName>
<iDefineIntVal>-2</iDefineIntVal>
</Define>

Good to Evil is -4, but Evil to Good only -2.

Is that correct?

 

[Gutentag]

I have a couple of questions
1. are immortals actually immortal? I've never had one die, but I've noticed they don't have the immortal promotion or anything.
2. I thought the mechanic with Hyborem was that after being killed he would respawn in the capital and next turn get the immortal promotion again. I was controlling him, he got killed, then next turn I moved him to a different city to try and protect myself against Buboes and he was killed again and permanently.
3. After the person dissenting in your city, has anyone ever not had the city revolt if you chose one of the events where there was a revolt chance?

Finally I had a CTD after choosing the option to send one of my conjurers to a different civ to get experience. Nothing happened if I chose not to send him.

I'm running .30 patch g

 

[Sto]

line 1803 in CvEventManager :

                    pUnit = pPlot2.getVisibleEnemyDefender(iPlayer)

CyPlot has no attribute getVisibleEnemyDefender

fixed and tested with :

						if pPlot2.isVisibleEnemyUnit(iPlayer):
                                                        for iUnitIndex in range(pPlot2.getNumUnits()):
                                                                pLoopUnit = pPlot2.getUnit(iUnitIndex)
                                                                if not pPlot.isEnemyCity(pLoopUnit) : continue
                                                                if pLoopUnit.isInvisible(eTeam, False) : continue
                                                                if pUnit == -1 :
                                                                        pUnit = pLoopUnit
                                                                elif pLoopUnit.isBetterDefenderThan(pUnit, pUnit) :
                                                                        pUnit = pLoopUnit

Note : i've tested with isBetterDefenderThan(pUnit, None) that should work but got some C++ exceptions sometimes .

Tcho !

 

[xienwolf]

@Victorvanwavere: Yes, that is correct. Also both good and evil have a -2 to Neutral, and neutral has no opinion about either of the others.

@Gutentag:
1. Yes, the promotion is for semi-immortality. See #2
2. Promotion means semi-immortal. 1 time shot. You can also get this promotion from a Ritual on all units you currently have (living ones anyway). The promotion is removed on death and will not come back (except in the case of Donal Lugh once he starts working properly, he should get the promotion whenever he kills undead/demon units)
3. Haven't actually played a game since that event was put in, so can't comment.

 

[MagisterCultuum]

Immortals will be resurrected (actually, in BtS resurrection works by having them withdraw and cast Escape just before it would otherwise die, instead of dieing and being recreated like in vanilla FfH) only once per turn; if you kill an immortal twice in one turn then it can be truly killed)

 

[Kael]

Circle of Gaelan

Finally spotted why you get 2 Gaelan Hero units when you complete this sequence properly. Events/CIV4EventInfos.xml/Gaelan_3_2 has <UnitClass>UNITCLASS_GAELAN</UnitClass> <iNumFreeUnits>1</iNumFreeUnits>, while Gameinfo/CIV4CorporationInfo also has <FreeUnitClass>UNITCLASS_GAELAN</FreeUnitClass>. Should only grant you the free unit on one or the other of the two.

Good call, I'll fix it.

 

[Arwon]

Cities captured by the Infernals don't get the Demonic Citizens building free.

 

[Gutentag]

This is probably to prevent other civs from capturing an infernal city and getting demonic citizens, much like getting the Khazad's unique building.

Also(referring to my post #1514) I understand the units getting the immortal promotion through the ritual only getting it once, but I thought the point of immortals and Hyborem is that they keep getting the immortal promotion, at least that's how it is described, but now they just have to be killed twice whenever, not just on the same turn. If that's been changed, fine, but I never saw any indication in logs or elsewhere to change this mechanic.