Heroes

Did i ever show you the civs i am going to add? Its like 100 of them??

Heroes bind to cultures, not to civs. Check the list I posted a month or so ago, which indicates a bunch of currently heroless cultures. I'd suggest taking any you fancy/can find good candidates for from those.
 
Heroes bind to cultures, not to civs. Check the list I posted a month or so ago, which indicates a bunch of currently heroless cultures. I'd suggest taking any you fancy/can find good candidates for from those.

Ok, here goes

Italian:
  • Caesar Borgia (Rennaisance)
  • Giuseppe Garibaldi (Industrial)

Franks:
  • Pepin the Great (Medieval)
  • Clovis I (Classical)

Can anyone think of good graphics for these, or should I just use generic graphics from other units for them?
 
Ok, here goes

Italian:
  • Caesar Borgia (Rennaisance)
  • Giuseppe Garibaldi (Industrial)

Franks:
  • Pepin the Great (Medieval)
  • Clovis I (Classical)

Can anyone think of good graphics for these, or should I just use generic graphics from other units for them?

Best thing to do is, first see if one exists in the units we already have, no need to have two units of the same thing, if not then add what is needed, best to Check some of FfH2 stuff also. And Warhammer.
 
StrategyOnly would it be possible to link some of the non-achievement heroes to the Great Commander option. In my last game I had 52 GGs settled in my military city. I do not play with Great Commanders on.

If you use
Code:
		<UnitInfo>
			<Class>UNITCLASS_....</Class>
			<Type>UNIT_....</Type>
			<PrereqGameOption>GAMEOPTION_GREAT_COMMANDERS</PrereqGameOption>

		...
		</UnitInfo>

on some of the hero units then people who don't play with Great Commanders on wil not get so many GGs settled in their cities.
 
StrategyOnly would it be possible to link some of the non-achievement heroes to the Great Commander option. In my last game I had 52 GGs settled in my military city. I do not play with Great Commanders on.

If you use
Code:
		<UnitInfo>
			<Class>UNITCLASS_....</Class>
			<Type>UNIT_....</Type>
			<PrereqGameOption>GAMEOPTION_GREAT_COMMANDERS</PrereqGameOption>

		...
		</UnitInfo>

on some of the hero units then people who don't play with Great Commanders on will not get so many GGs settled in their cities.

I would really want to know how the HECK you play, i dont use but maybe 2 for a whole game. Just like you said about Heroes, i am lucky if i get 3-5 per game??
But i haven't in the last 2 months made it past Industrial either (well actually hardly to the end of Classical really). Too many changes i need to keep up on.

Well i tell you what, you pick out the so called "loners" and have at it (actually never seen nor heard of that tag:blush: there before) , that might bring another enhancement then to the Heroes flight. . . (yes i meant FLIGHT) as in continuing saga. . . ;) You know you are one of the ones i do trust here on C2C.

Anyone can actually do anything to any of the stuff that i "supposedly" do, EXCEPT i dont want anyone touching the FPK's is all.
 
I have not gotten to Industrial recently. When I conquer someone, I build their culture building in one of their cities then look at all my cities to see if any "new" cultures are available and then build them. Once I have I give back the city that built the culture to my vassal.

I should work on the vassal wonder so that it gives you the base culture of your vassal as well as giving money to your vassal each time to keep it in the game.
 
DH brought up a thought. Perhaps some Heroes could be defaulted AS Great Commanders (and only appear if the option is on.) In some cases this would be incredibly appropriate. I'm also wondering... is it possible for a Great Commander to also be a combat unit themselves?

Oh, and this:
I should work on the vassal wonder so that it gives you the base culture of your vassal as well as giving money to your vassal each time to keep it in the game.
is a GREAT idea!
 
OK, I have tidied up the code a bit including moving the speed stuff into the init part of the code. When writing code it is better to use one variable for a value rather than three. So instead of iGoldStollen, iGoldMax and iGoldMin. Just use iGoldStollen and give it the min and max values when needed. Similarly it makes it easier to maintain the code if you don't then use iGoldMax to mean maximum espionage or maximum research. Anyway I have tidied up the gold and espionage code to make it a bit clearer what is going on. Please test these changes and if they work put it on the SVN.

The research bit is complete rubbish. It refers to two different values getCurrentResearch() and calculateBaseNetResearch () does tests on one but calculations on the other. Then it ignores these tests and calculations and it adds the winner's value to the winner and subtracts the loser's value from the loser, so that the winner may get more or less than what the loser looses.:crazyeye: I miss read this part. I get back to you on it.

Edit Attached includes a research fix and tidy up. Basically it now is based on the looser's current research now.
 
OK, I have tidied up the code a bit including moving the speed stuff into the init part of the code. When writing code it is better to use one variable for a value rather than three. So instead of iGoldStollen, iGoldMax and iGoldMin. Just use iGoldStollen and give it the min and max values when needed. Similarly it makes it easier to maintain the code if you don't then use iGoldMax to mean maximum espionage or maximum research. Anyway I have tidied up the gold and espionage code to make it a bit clearer what is going on. Please test these changes and if they work put it on the SVN.

The research bit is complete rubbish. It refers to two different values getCurrentResearch() and calculateBaseNetResearch () does tests on one but calculations on the other. Then it ignores these tests and calculations and it adds the winner's value to the winner and subtracts the loser's value from the loser, so that the winner may get more or less than what the loser looses.:crazyeye: I miss read this part. I get back to you on it.

Edit Attached includes a research fix and tidy up. Basically it now is based on the looser's current research now.


Thx a million:

What does these lines actually do??

Spoiler :
Code:
## Sneak initialization
	global giSneakPromotion
	giSneakPromotion = gc.getInfoTypeForString('PROMOTION_SNEAK1')

## Marauder initialization
	global giMarauderPromotion
	giMarauderPromotion = gc.getInfoTypeForString('PROMOTION_MARAUDER1'):

## Marauder initialization
	global giIndusPromo
	giIndusPromo = gc.getInfoTypeForString('PROMOTION_INDUSTRYESPIONAGE1')
 
They store the information from the getInfoType... in a variable that can then be used later. That way you only do the call once rather than every combat. It is a very small saving in time.
Dang there is a : on the end of the middle one and there should not be.
 
They store the information from the getInfoType... in a variable that can then be used later. That way you only do the call once rather than every combat. It is a very small saving in time.
Dang there is a : on the end of the middle one and there should not be.

I took out the : but i now get this:

Traceback (most recent call last):
File "BugConfig", line 110, in unknown_endtag
File "BugConfig", line 334, in endChild
File "BugConfig", line 337, in end
File "BugConfig", line 318, in process
File "BugConfig", line 565, in handle
File "BugUtil", line 643, in getFunction
File "BugUtil", line 630, in lookupFunction
File "BugUtil", line 622, in lookupModule
File "<string>", line 35, in load_module
File "<string>", line 13, in _get_code
File "Heroes", line 124

elif

^

SyntaxError: invalid syntax
 
This is th problem when I can't test stuff :(. I'll try and get c2C working and then give you a tested version, or put it on the SVN.

Whats going on with your PC??
 
Still got this error, sorry:

Traceback (most recent call last):
File "BugEventManager", line 363, in _handleDefaultEvent
File "Heroes", line 195, in onUnitPromoted
NameError: global name 'iMarauderPromo' is not defined
 
Try this. I still don't have c2c working so I can't do even the simplest test. :(

No offense but is it just that you cant get YOUR copy working, like trying an export of the SVN to your PC?? See i am not understanding your point is all.:crazyeye:
 
Try this. I still don't have c2c working so I can't do even the simplest test. :(

Now my MAIN PC is down also, cant get it to work, so i have to revert back to my XP PC, YUCK!!:sad:
 
Back
Top Bottom