Alright, stuck again. Long post to show what I already did (not much
).
The tags have a lot in common with the DamageTypeCombat tags, so I'm basically trying to follow them as much as possible (e.g. up untill the functional part). Goal is to make the tag a promotion effect as well as a base unit parameter, I've started with the latter.
In the UnitInfos XML, it looks like this:
Code:
<DivineCombats>
<DivineCombat>
<DamageType>DAMAGE_HOLY</DamageType>
<iCombatDivine>1</iCombatDivine>
</DivineCombat>
</DivineCombats>
Which, when all is said and done, would mean that the unit gets a +1 to its combat (both defense and offense, seperate tags hopefully coming in the future
), for each Civ that follows the unit's owner's state religion (including the owner himself).
For completeness sake, the Civ4UnitSchema.XML:
Code:
...
<ElementType name="iCombatDivine" content="textOnly" dt:type="int"/>
<ElementType name="DivineCombat" content="eltOnly">
<element type="DamageType" />
<element type="iCombatDivine" />
</ElementType>
<ElementType name="DivineCombats" content="eltOnly">
<element type="DivineCombat" minOccurs="0"/>
</ElementType>
...
<ElementType name="UnitInfo" content="eltOnly">
...
<element type="DamageTypeCombats" minOccurs="0"/>
<element type="BonusAffinities" minOccurs="0"/>
<element type="DivineCombats" minOccurs="0"/>
<element type="AllowPromotions" minOccurs="0"/>
...
</ElementType>
All of this looks ok to me, and everything loads without errors (added the tag to the Monk to check that).
Now to the DLL. I was going step by step here. First, CvInfos.h (I normally use Xienwolf's Huge Commentblocks (tm), but left them out for clarity's sake).
Code:
class CvUnitInfo : public CvHotkeyInfo
{
//---------------------------------------PUBLIC INTERFACE---------------------------------
public:
...
int getDivineCombat(int i) const;
...
protected:
...
int* m_piDivineCombat;
...
And in CvInfos.cpp:
Code:
CvUnitInfo::CvUnitInfo() :
...
m_piDivineCombat(NULL),
...
CvUnitInfo::~CvUnitInfo()
{
...
SAFE_DELETE_ARRAY(m_piDivineCombat);
...
}
int CvUnitInfo::getDivineCombat(int i) const
{
return m_piDivineCombat ? m_piDivineCombat[i] : -1;
}
void CvUnitInfo::read(FDataStreamBase* stream)
{
...
stream->ReadString(m_iNumImages, m_paszImages);
SAFE_DELETE_ARRAY(m_piDivineCombat);
m_piDivineCombat = new int[GC.getNumDamageTypeInfos()];
stream->Read(GC.getNumDamageTypeInfos(), m_piDivineCombat);
//FfH Units: Added by Kael 08/04/2007
stream->Read(&m_bAbandon);
...
}
void CvUnitInfo::write(FDataStreamBase* stream)
{
...
stream->WriteString(m_iNumImages, m_paszImages);
stream->Write(GC.getNumDamageTypeInfos(), m_piDivineCombat);
//FfH Units: Added by Kael 08/04/2007
stream->Write(m_bAbandon);
...
}
bool CvUnitInfo::read(CvXMLLoadUtility* pXML)
{
...
pXML->SetVariableListTagPair(&m_piDivineCombat, "DivineCombats", sizeof(GC.getDamageTypeInfo((DamageTypes)0)), GC.getNumDamageTypeInfos());
...
}
All of this compiled and loaded without any errors. I could start a new game, worldbuilder myself a monk (with tag) and quicksave and quickload.
--- Problems start here ---
Now onto CvUnit.h/cpp. In the header-file I put:
Code:
protected:
...
int* m_paiDivineCombat;
(As an aside, what does the "a" stand for. I presumed p was for arrays (or pointers to arrays, anyway the arrays in CvInfos all start with m_p), the i is for integer, but I'm lost on the a).
And in CvUnit.cpp:
Code:
CvUnit::CvUnit()
{
...
m_paiDivineCombat = NULL;
...
}
void CvUnit::uninit()
{
SAFE_DELETE_ARRAY(m_paiDivineCombat);
...
}
void CvUnit::read(FDataStreamBase* pStream)
{
...
pStream->Read(&m_bSuppressImage);
pStream->Read(GC.getNumDamageTypeInfos(), m_paiDivineCombat);
//FfH Spell System: Added by Kael 07/23/2007
pStream->Read(&m_bFleeWithdrawl);
...
}
void CvUnit::write(FDataStreamBase* pStream)
{
...
pStream->Write(m_bSuppressImage);
pStream->Write(GC.getNumDamageTypeInfos(), m_paiDivineCombat);
//FfH Spell System: Added by Kael 07/23/2007
pStream->Write(m_bFleeWithdrawl);
...
}
That's it. So nothing functional yet, just (un)initializing and reading and writing of the array. Build, run, try to start a new game => CtD.
And that's before I started trying to figure out where in the code I should apply the combat bonus (I piggyback on DamageTypeCombat, so I guess it's in reset()) and how to update the bonus any time a civ changes its state religion...
Any and all help is greatly appreciated
