[Extension] [POLL] More Wonders for VP

[AndreyK]

I am playing Epic on large map

 

[AndreyK]

I have built St. Peter's Basilica, it gives happiness from churches, but when Ethiopia converted my city and I built kongmiao and atash, they don't

 

[adan_eslavo]

Kongmiao and atash? What is that?
I used universal function from Infixo's code:

INSERT INTO Building_BuildingClassHappiness (BuildingType,                BuildingClassType,    Happiness)
    SELECT DISTINCT                                'BUILDING_ST_PETERS_DUMMY',    BuildingClass,        1
    FROM Buildings WHERE Cost = -1 and FaithCost > 0 AND WonderSplashImage IS NULL;

so it automatically checks for all buildings. If these are some modmod buildings you should check if your modmod load after of before MWfVP. If after, then it will not count them.

 

[SolutionIt]

Kongmiao and atash? What is that?
I used universal function from Infixo's code:

INSERT INTO Building_BuildingClassHappiness (BuildingType,                BuildingClassType,    Happiness)
    SELECT DISTINCT                                'BUILDING_ST_PETERS_DUMMY',    BuildingClass,        1
    FROM Buildings WHERE Cost = -1 and FaithCost > 0 AND WonderSplashImage IS NULL;

so it automatically checks for all buildings. If these are some modmod buildings you should check if your modmod load after of before MWfVP. If after, then it will not count them.

It is from VP bare components. It is likely Audrey didn't do the fix to the religious buildings for it? Or it is something else.

 

[AndreyK]

I see, those are from Bare Necessities mod from Enginseer

 

[AndreyK]

Seems it loads after this modmod

 

[adan_eslavo]

You can add dependency manually and try it again. Post the link to that mod. I will try publish some update for that in next iteration.

 

[AndreyK]

https://forums.civfanatics.com/threads/bare-necessities.645157/

 

[gwennog]

I think there is still a small problem with the function "Building_ResourcePlotsToPlace".
I play a game and I need Wine for WLTKD. The only two sources of wine come for Lavaux built by Ethiopia. But this civilization doesn't seem to have the resource. If I look at the terrain the two wines appeared under GP improvements. I guess but I don't know how to verify that in this case the resource is not available.

 

[adan_eslavo]

Hover over the resource to see in tooltip how many copies it provides on a tile. It should have 1 after the VP fix. Earlier it had 0 so it couldn't be improved. Rest thing is about VP. My part is only to place them correctly. Provide screens for further analysis please. Maybe it is another thing with vP improvements?

 

[gwennog]

Provide screens for further analysis please.

Spoiler Wine is well under Town :

Spoiler 0% resource on Monopolies sceen :

On my territory, I have Copper from Falun Mine. I will test to improve it with a GP.

Spoiler Copper from Falun Mine :

Spoiler 200% from India company but copper is well here :

I test to place a GP improvement (manufactory) on Copper from Falun Mine

Spoiler Place a manufactory on copper :

Spoiler Copper is always OK :

The resource is always counted. I'm pretty sure that the problem occurs when the resource appears under an improvement but otherwise, it works.

 

[adan_eslavo]

So I cannot do much. Post this to VP Github. I can only declare values and he automatically searches through tiles.

 

[AndreyK]

I have a question about Notre Dame - it's not clear from definition. Does it require finishing the tradition tree?

 

[adan_eslavo]

Yes. All policy wonders required and still require finishing mentioned branch.

 

[gwennog]

So I cannot do much. Post this to VP Github. I can only declare values and he automatically searches through tiles.

OK, I test it an other time and if I confirm, I will post.

 

[HungryForFood]

OK, I test it an other time and if I confirm, I will post.

I'll investigate, I'm working on some resource related stuff in the DLL right now anyway.

 

[gwennog]

I'll investigate, I'm working on some resource related stuff in the DLL right now anyway.

Thank you

Do you want to post this on Github ?

 

[gwennog]

Adan_eslavo,

I encountered two other problems while playing

First is with ST. PETER'S BASILICA which gives 3 inquisitors instead of 3 missionaries

Spoiler SQL Code :

INSERT INTO Building_FreeUnits
(BuildingType, UnitType, NumUnits)
VALUES ('BUILDING_ST_PETERS', 'UNIT_INQUISITOR', 3);

And the second, more difficult because I think it comes from the functionality that doesn't work. There isn't experience gained in the city with the Marae Arahurahu according to the greatworks.
I saw that WARTBURG uses the same functionality but I have not tested.

Spoiler SQL Database :

If you confirm, I can post on Github.
Do you think the table could be changed to add the type of greatwork? that would specify the music for Marae and the literature for Wartburg.

 

[HungryForFood]

Thank you

Do you want to post this on Github ?

Everything seems fine on my end, there's nothing wrong with the code. The player's resource count updates correctly.

For the monopoly screen, it doesn't update immediately, but going to the next turn will fix it.

I'll try and see if I can make the game check immediately, but this is not a big deal, as it is working mostly correctly now.

 

[gwennog]

For the monopoly screen, it doesn't update immediately, but going to the next turn will fix it.

In my post, the screen exemple is long time ago after the wine appear.

Everything seems fine on my end, there's nothing wrong with the code. The player's resource count updates correctly.

OK, I will try to reproduce the problem but on my territory to analyze where it comes from.

Thanks for watching the code.