Right, I'll start.
Bug: Slave Market resurfaces on rebuilding despite being out of the Slavery Civic. So far that's the only Civic specific building I've seen it happen with.
Question: What happens if it's even possible on rebuild in MP games? Does it work at all, or does it only do it for the one player and thus cause OOS all the time?
Cheers
I changed it to using a message some time ago so if one player uses Ctrl-Alt-T it will rebuild on all computers at the same time. As Koshling said it is deterministic so all computers should end up in the same state which means no OOS.Question: What happens if it's even possible on rebuild in MP games? Does it work at all, or does it only do it for the one player and thus cause OOS all the time?
It replays all events so it should keep the +2 health in all cities. If not, then that is a bug.I am not sure if recalculation takes into consideration bonuses from previous event like +2 health in all cities.
I think it just removes them.
It replays all events so it should keep the +2 health in all cities. If not, then that is a bug.
Unless the event relies on Python to set the health instead of using the relevant tags (in which case its an issue with that specific event). If you have a save game that illustrates it (and know what the evnt was) please post it.
Well, I can say for sure that the event that gives the option of doing herbal experiments does not survive recalcs. The first save I have attached is a save before the recalc, and the second is a save after recalc, as well as about a hundred turns later, but you can still probably see the problem.
After recalculating modifiers in SVN 2134 I don't get any food from buildings. Newly built buildings work fine.
Well, I can say for sure that the event that gives the option of doing herbal experiments does not survive recalcs. The first save I have attached is a save before the recalc, and the second is a save after recalc, as well as about a hundred turns later, but you can still probably see the problem.
Fixed the recalculation of event effects (though it will only work for events that happen after the upgrade to the fixed version - anything prior is lost I'm afraid). In testing I also that event health/unhealth was showing up as civic health/unhealth in the hover text, so I fixed that too.
Thanks alot for this! I have suspected that something was amiss for a while, as it seemed that none of the events that fired were having any effect on me! Turns out it wasn't my imagination.
Does this also address the problem of Wonders using Python not being able to have their one-time effects survive recalcs? Or is that a seperate issue?
Alternatively we can add a Recalc event.Separate issue. One time effects from Python (that change modifiers) are just not regeneratable. If we have such wonders (laregly we don't but there may be a few exceptions) we need to move their functionality into tags somehow.
Saved games attached.
If it doesn't do it for you on recalc then you can see the result in my saved game after recalculating.
This is actually a little bit of a pain as I can't recalculate again without having it pop up every time I do it, and there are several reasons and times when recalculating is necessary to remove bugs. Bugs which I should post elsewhere in fact... *ponders* Unless I already did. *laugh* Can't remember.
Actually think I did but it was never really looked at as I was then playing with the folder C2C. I am not now and the problems persist so I'll post them again.
Cheers