3rd and 4th Unique Components for VP - Official thread 88.10

[pineappledan]

It already IS a global effect. I modified it specifically to make it global. The wonder puts a horse dummy building in all cities in your empire, like how CN tower gave you a broadcast tower in all cities

It uses the FreeBuilding (global) entry in SQL to add the horse dummy, not the FreeBuildingThisCity (local).

 

[adan_eslavo]

So is it not better to swap that? Put one dummy with global effect instead of million dummies with local? It would be big simplification. It can be done with global effect unlike Broadcast Tower.

 

[pineappledan]

There is no global table for resources, only improvements. If you wanted to add a global bonus to pastures there’s a way to do that, but you would be giving bonuses to sheep and cattle as well. If you want to boost a single resource, like horses, you have to do it locally.

 

[adan_eslavo]

Huh, I was sure that everything has local and global, but seems you're right it is only local. Sorry, but at least we have this explained
But, nevertheless, restore that part of code if you can and analyse all buildings with NeverCapture value = 1 and using dummies. Rome shouldn;t get those dummies if no ucs is captured.

 

[pineappledan]

No issues with Rome, since they are never capture. I’ve got an old version of the code on my local instal, so I can restore that myself

 

[adan_eslavo]

Ok. It is on master github too Now I uderstand why you put that code only for Hippo.

 

[pineappledan]

I reuse that code for the solomon’s Temple in the port I did for Leugi’s Israel as well.

 

[pineappledan]

Okay, so with the hippodrome code reversed, I guess we can push v37.

I'll try to compose a list of all the unit codes that cycle through all units every turn. That's what is hurting us the most.

• Austrian Landwehr (culture every turn if in a garrison)
• Byzantium Dromon (searches for greek fire DoT effect)
• Carthage Shophet (applies ZOC ignoring promotion if next to shophet)
• China Xiafan Guanjun (increases influence for every unit with Kowtow promotion in CS territory)
• Denmark Lanskib (checks for embarked units stacked on the viking exploration promotion)
• Ethiopian Shotelai (checks for maim debuff and removes movement)
• Huns 2 promotions:
  • Tarkhan (checks units stacked with migration and adds movement)
  • Horse archer (checks all units for last shot)
• Inca Chasqui (heals 15 hp if in friendly territory)
• Maya Holkan (heals 30 hp every 20 turns)
• Dutch Goedendag (checks for units to add golden spurs boost to)
• Persian Qizilbash (adds resources for every qizilbash in enemy territory)
• Polynesian Koa (searches for bleeding DoT effect)
• Roman Ballista & Legion (adds unique bonuses for being near a GGeneral)
• Siam Seir Mord (just... all of it. on unit turn, and cycles through all units at beginning of turn. It's intense)
• Songhai Sofa (Mounted units gain bonus if within 2 tiles of Sofa)
• Spain Armada (cycles through units, changes combat strength if at full HP)

 

[adan_eslavo]

Tarkhan is already simplified to minimum. I think we can do smth with the rest too. But please do not rush me. I do what I can . For now it's time for people to test v37. Maybe some bug sneaked in.

 

[adan_eslavo]

v37 out! Good job guys!
Now to the tests...

 

[Hinin]

Before that, I just wanted to thank you, @adan_eslavo and @pineappledan : you have put so much work into that new version (and most of it was about making the mod lighter, so not the most glorious/noticable kind of update), and I'm very happy to be able to help, at my level, talented and motivated creators like you.

Now, some tests...

 

[FoxOfWar]

I will be able to put this to a test tomorrow. Looking forward to it, 'cause I've certainly seen a decrease in performance as this mod has gotten heavier.

I'll also echo Hinin here and thank you for these efforts.

 

[Edaka]

For real, this is God's work right here. Humongous kudos to everyone involved in this project.

 

[adan_eslavo]

I planned lua revision many updates ago, but really had no time for that. I'm glad we managed to do at least half of it for now.

I also plan to merge compatibility patch for EE and do one for ENW to this mod to not to use any additional mod.

 

[Guynemer]

Just echoing the last few posts here--this is marvelous work, a truly worthy addition to VP. Thanks to you all.

 

[pineappledan]

Looking at Siam... The Seir Morb looks like the single worst offender for the amount of computation, and I think we could make it easier.

Could we change the current way it works so that the lua fires on attack, like the klepht lua, instead of every time the unit moves/sits/is created, etc? Maybe you would have to make it a flat damage modifier, like "does 5 more damage on attack for every full movement point remaining on the unit."

For the rest that iterate through a ton of units every turn, and not just on specific actions, we could disable their availability as City-state gifts, and lock their luas to turns with that specific civ. It's a really inelegant solution, but ya'll seem pretty determined to have this mod run on super-large, 43 civ maps on 10 year old computers, so I don't know if there's a way to do that without cutting corners.

Not trying to rush anything, or push work on v38 immediately. I'm just spitballing, thinking of ways that people might want to proceed from here.

 

[adan_eslavo]

We can definitely start some works from Siam. For now I try to merge compatibility patch for VPEE to MUCfVP mod, then do new small ENW compatibility patch and then make some corrections to VPEE during @Infixo absence. Then I could start v38 work.

 

[FoxOfWar]

For the rest that iterate through a ton of units every turn, and not just on specific actions, we could disable their availability as City-state gifts, and lock their luas to turns with that specific civ. It's a really inelegant solution, but ya'll seem pretty determined to have this mod run on super-large, 43 civ maps on 10 year old computers, so I don't know if there's a way to do that without cutting corners.

Well... I'd settle for being able to do 12 civs on Large on a two-year-old computer, on Marathon. Problem is, Civ V just can't use 75% of the power I have available, old as the engine is. There's no use having 16GB RAM for this game, sadly. (Didn't test yet with the latest set though, so I might be going on about nothing already.)

However, I don't know if that's just me. Anyone else been having performance problems with MUCfVP?

 

[Edaka]

Can't comment much regarding performance. However, I've just discovered that I can pick the Prize Ships promotion on my triremes. Doesn't seem intentional, as in pure VP you can only pick either Boarding Party or Coastal Raider.

By the way, where do you prefer bugs to be reported? Is here okay, or perhaps you'rr more into Github?

 

[pineappledan]

GitHub is preferable. That way it doesn’t get lost/forgotten. I also was able to pick prize ships from levelling. Is that not possible with base VP?