3UC/4UC for VP: Project Coordination Thread

[infidel88]

OK, I thought it will give only bonus for those mountains nearby. In that case - nevermind.

 

[pineappledan]

shall i go ahead and write up intihuatana on the 4UC spreadsheet then?

Intihuatana has been added to the spreadsheet.
Intihuatana SQL and lua is complete.
Just need art assets and text now.

Are people happy with the bonuses to Intihuatana?
Are people happy with the bonuses Intihuatana recieves from Scientific revolution?
Do people agree/disagree with changing the Incan UA to give gold on mountains instead of food?

 

[Hinin]

I'm happy with what you proposed (UB + UA modification).
For the picture, I'll go look for a book on the Machu Pichu in the local libraries (maybe we can find a picture of the same kind as the one you used for the Tophet).

Good job, as always.

 

[Hinin]

hey can you help me on civ 5 brave new world i want a large detail earth map to avoid crashes

This is not the part of the forum where you ask that kind of service. Go in the "map scripts" section pls.

Have a good week.

 

[adan_eslavo]

@pineappledan I done first art for Intihuatana and reworked and fixed slighlty lua. After quick test I will add it on github.

 

[pineappledan]

Oh, okay. I also made a possible icon for the Intihuatana. I'll post mine here, and you post your and we can decide which one we like better

Spoiler :

 

[adan_eslavo]

It is temporary for testing purpose.

 

[adan_eslavo]

Ok I added changes to Github. Please @pineappledan, add texts, modify notification text and add colors to them (according to pattern VP uses) and check if it is all right. It's late and I have no time to test it deeply. I managed to make it work in my game. Substitute art if necessary.

 

[adan_eslavo]

I plan to relese v28 tomorrow afternoon. Any important fixes needed which cannot wait for v29?

 

[pineappledan]

I have added help and strategy text for intihuatana. I'll do civilopedia entry later.

In your amendment to the intihuatana lua you added a lua notification for if an intihuatana is built after Scientific Revolution has already been adopted. I don't think this is necessary. The player will already be aware of the upgrade and the building is not substantially changed, unlike with the Kabuki. I think it is fair to silence this notification; it's just clutter.
For an example, consider if the game notified you every time you built a castle after having constructed Neuschwanstein, or adopted the Nobility policy.

Updates that should be added before publishing:
- Horse archer unique promotion lua has not been incorporated into the civ5proj file, so it has never been tested. The dummy promotion is already on the unit, but doesn't do anything right now
- The Tarkhan heal on pillage lua seems like it should be a quick fix. It should be very doable to get that working before v 28 is live. With those 2 fixes, Huns will be complete.

Updates that we will probably save for v29.
- Portugal - none of the lua is working as intended for this civ.

@Blue Ghost - I Guess Zulu and Huns are finished now, right? Does anything more need to be done w.r.t. the alti cur tribute?

Tentatively, I would say you can mark Huns and Zulu as Code complete, but I would edit Portugal as "in progress"

 

[Blue Ghost]

Yes, Zulu and Huns are complete. There’s still the issue that Alti Cur doesn’t trigger when demanding heavy tribute, but I don’t know if there’s anything I can do about that. @Infixo do you know?

 

[Infixo]

@Blue Ghost I need more details to find out if problem is with dll or lua. How do you know it doesn’t trigger? You sure you have a building? Does it trigger under any other conditions or never?

 

[Infixo]

@Blue Ghost OK, I've tracked the problem down. The DLL simply doesn't invoke the event in any other case than gold tribute. I'll fix it.

 

[adan_eslavo]

Strange thing with that tabbing n sql files. I saw you edited (read celeaned) it and it looks good in browser but in modbuddy I got this :

Spoiler tabbing :

@pineappledan why do you add same icon 2 times? There's no need for that. As you could see, I reduced rows and columns to 1 and 1 and added same icon for both versions of Intihutatana and it worked well.

 

[pineappledan]

Strange thing with that tabbing n sql files. I saw you edited (read celeaned) it and it looks good in browser but in modbuddy I got this :

I figured it was more important to have the code "clean" in the version of it where people are likely to be looking at each other's work, which wold be the browser.

@pineappledan why do you add same icon 2 times? There's no need for that. As you could see, I reduced rows and columns to 1 and 1 and added same icon for both versions of Intihutatana and it worked well.

I didn't want to take any chances. I did the same thing with the Shofet for when we were playing around with having it be a unique Great Admiral too. At the very least it could allow us to do some minor changes, like make one brighter/darker, flip, etc. if we want to
I also made separate help/strategy/civil entries for each of the inti buildings. are those not necessary?

 

[adan_eslavo]

• Nope. They can be the same.
  
• I reduced shophet art many ptches ago also to be one icon. There was no problem with that.
• There's no need of differentating it especially if you decided to not put notification.
  
• You can use text or art as many times as you want. There's no point in adding 2 times same civilopedia or other text if it is exact same building (only one yield is different).

 

[adan_eslavo]

Ok, pushed v28 version on Github and civfanatics. Enjoy.

When I have some time I will try to make portugal working.

 

[Infixo]

Re: Huns/AltiCur.
Here's the fix.
I've also added a new parameter to the event to detect different yields. You may use it e.g. to grant different yields depending on what the actual tribute was.

GameEvents.PlayerBullied.Add(function(iPlayer, iCS, iValue, eUnitType, iPlotX, iPlotY, eYield) end)

 

[adan_eslavo]

I figured it was more important to have the code "clean" in the version of it where people are likely to be looking at each other's work, which wold be the browser.

I don't want to be rude, but only you are working with browser? I sometimes use Notepad++ instead of Modbuddy, but there are also broken tabs.

@Infixo Next patch I suppose. After checking and VP update. But thanks a lot.

 

[pineappledan]

You can use text or art as many times as you want. There's no point in adding 2 times same civilopedia or other text if it is exact same building (only one yield is different).

Okay, well I'll know for next time. I was just concerned with having things work.
It will be nice not having 2 entries for the Inti

I don't want to be rude, but only you are working with browser? I sometimes use Notepad++ instead of Modbuddy, but there are also broken tabs.

I'm guessing you use the github desktop application then. I do all the initial files in Notepad++ before uploading them, but I don't really like the desktop github app, so if there are only minor tweaks to be made to files, I prefer to just use the browser.