scribbler
Warlord
Don't worry, those Brits are just jealous of our success.
Well, yeah. Plus they're still peeved about getting the Most Successful title taken away from them by way of Germany and Japan
A New Dawn Beta Builds
- Thread starter 45°38'N-13°47'E
- Start date
Well, yeah. Plus they're still peeved about getting the Most Successful title taken away from them by way of Germany and Japan
Hydromancerx
C2C Modder
@Afforess
Awesome! However I would still like it to stay as an option in AND rather than self distributing since AND was ment to be a RoM community mod.
Anywho which mods of yours can I combine into my "uber mod"? So far I have ...
- Misc Mod
- Water Mod
- Military Mod
- Health Mod
- Domestic Animals Mod
- Science Mod
- Transportation Mod
- Garbage Mod
- disabled buildings from Early Buildings
- disabled Buildings from Civic Buildings
- Towers and Walls Mod
I would like to add the following ...
- Firestorm Mod
- Zoological Buildings Mod
- Farming Mod
- Education Mod (Gladiator School, Drama School, Music School, etc)
- Public Pool (from the Sports Mod)
- Misc Mod (Cryogenic Prison, Saloon, etc)
- NIMBY Mod
- GeneralStaff's Vacation Mod (National Parks, Cruse Ship Port, etc)
- All of Early Buildings (or at least some key buildings like the weaver, tailor, apiary, candlemaker, etc)
In short which can I use of these?
Once combined you can take them out of the installation, thus making far fewer choice for custom installation.
Awesome! However I would still like it to stay as an option in AND rather than self distributing since AND was ment to be a RoM community mod.
Anywho which mods of yours can I combine into my "uber mod"? So far I have ...
- Misc Mod
- Water Mod
- Military Mod
- Health Mod
- Domestic Animals Mod
- Science Mod
- Transportation Mod
- Garbage Mod
- disabled buildings from Early Buildings
- disabled Buildings from Civic Buildings
- Towers and Walls Mod
I would like to add the following ...
- Firestorm Mod
- Zoological Buildings Mod
- Farming Mod
- Education Mod (Gladiator School, Drama School, Music School, etc)
- Public Pool (from the Sports Mod)
- Misc Mod (Cryogenic Prison, Saloon, etc)
- NIMBY Mod
- GeneralStaff's Vacation Mod (National Parks, Cruse Ship Port, etc)
- All of Early Buildings (or at least some key buildings like the weaver, tailor, apiary, candlemaker, etc)
In short which can I use of these?
Once combined you can take them out of the installation, thus making far fewer choice for custom installation.
Afforess
The White Wizard
All of them. You have permission to modify and take over over all of those you listed. To be specific, you can have:
- Firestorm Mod
- Zoological Buildings Mod
- Farming Mod
- Education Mod
- Public Pool
- Misc Mod
- NIMBY Mod
- GeneralStaff's Vacation Mod
- The Buildings I cut from the Early Buildings.
By the way, I never delete perfectly good buildings. You will find I just commented out the buildings, so you should find it easy to turn them back on.
Hydromancerx
C2C Modder
1. Thank you. I shall add all of the ones you approved then.
2. Aw darn I was hoping for some more of the early buildings (like the apiary, weaver's hut, wheelwright and stonemaker's hut. Sure you don't want to disable some more?
3. That's what i mean when i say "disabled". Not that you deleted them.
4. So once I get is all combined into one and uploaded you are going to take out the other mods that are completely combined right?
Afforess
The White Wizard
Nothing stops you from using the bForceOverwrite tag, and re-creating the building the way you see fit.
Yes. Unless you have something else in mind.
Hydromancerx
C2C Modder
Nothing stops you from using the bForceOverwrite tag, and re-creating the building the way you see fit.
Yes. Unless you have something else in mind.
1. Yeah I know. Just was trying to keep things simpler. For instance I wanted the wheelwright so I would not have to have overriding code for it to fit into the transportation mod. Its too bad I did not learn how to mod sooner or I could have made those ideas myself rather than you or generalstaff making them for me.
2. Nope. Just wanted to make sure we were on the same page.
strategyonly
C2C Supreme Commander
Anything on my crashes yet?
lichen8566
Warlord
About the bug of stoneworker's hut, I found the problem, but I'm sorry for that it's hard to fix by me.
The building's extra yields bonus is calculated by the vicinity resourece in the city's plots.
This function is called by the game's plots updating every turn. Then it will call processBonus() (red text) to calculate the city's yield of all buildings. The real problem is here, in the hasVicinityBonus() function. (blue text). It can not determine whether or not there is vicinity resources in the city's plots.
Then in the function CvCity:
rocessBonus() Line start from 4677, it will subtract city's yield by the count bonus from vicinity resource, in every turn. (red text)
Maybe you will ask me why? Just read the code in these functions:
Do you remember that you changed the calculation method of city's culture radius? I guess this old way will not get the city's real working plots. To avoid this bug without modify many codes, I suggest you simply disable this feature temporarily.
The building's extra yields bonus is calculated by the vicinity resourece in the city's plots.
Code:
> CvGameCoreDLL.dll!CvCity::hasVicinityBonus(BonusTypes eBonus=8) 行18993 C++
CvGameCoreDLL.dll!CvCity::changeNumBonuses(BonusTypes eIndex=8, int iChange=-2) 行12112 + 0xc 字节 C++
CvGameCoreDLL.dll!CvPlot::setPlotGroup(PlayerTypes ePlayer=0, CvPlotGroup * pNewValue=0x00000000) 行7691 C++
CvGameCoreDLL.dll!CvPlotGroup::recalculatePlots() 行164 C++
CvGameCoreDLL.dll!CvPlayer::updatePlotGroups() 行4581 C++
CvGameCoreDLL.dll!CvGame::updatePlotGroups() 行2431 C++This function is called by the game's plots updating every turn. Then it will call processBonus() (red text) to calculate the city's yield of all buildings. The real problem is here, in the hasVicinityBonus() function. (blue text). It can not determine whether or not there is vicinity resources in the city's plots.
Code:
void CvCity::changeNumBonuses(BonusTypes eIndex, int iChange)
{
FAssertMsg(eIndex >= 0, "eIndex expected to be >= 0");
FAssertMsg(eIndex < GC.getNumBonusInfos(), "eIndex expected to be < GC.getNumBonusInfos()");
if (iChange != 0)
{
bool bOldHasBonus = hasBonus(eIndex);
/************************************************************************************************/
/* Afforess Start 04/23/10 */
/* */
/* */
/************************************************************************************************/
bool bHadVicinityBonus = hasVicinityBonus(eIndex);
/************************************************************************************************/
/* Afforess END */
/************************************************************************************************/
m_paiNumBonuses[eIndex] += iChange;
/************************************************************************************************/
/* Afforess Start 04/23/10 */
/* */
/* */
/************************************************************************************************/
[COLOR="Blue"]bool bHasVicinityBonus = hasVicinityBonus(eIndex);[/COLOR]
if (bOldHasBonus != hasBonus(eIndex))
{
if (hasBonus(eIndex))
{
[COLOR="red"]processBonus(eIndex, 1, bHadVicinityBonus != bHasVicinityBonus);[/COLOR]
}
else
{
[COLOR="Red"]processBonus(eIndex, -1, bHadVicinityBonus != bHasVicinityBonus);[/COLOR]
}
}
/************************************************************************************************/
/* Afforess END */
/************************************************************************************************/
if (isCorporationBonus(eIndex))
{
updateCorporation();
}
}
}Then in the function CvCity:
rocessBonus() Line start from 4677, it will subtract city's yield by the count bonus from vicinity resource, in every turn. (red text)
Code:
/************************************************************************************************/
/* Afforess Start 12/7/09 */
/* */
/* */
/************************************************************************************************/
for (iI = 0; iI < NUM_COMMERCE_TYPES; iI++)
{
changeBonusCommerceRateModifier(((CommerceTypes)iI), (getBonusCommerceRateModifier(((CommerceTypes)iI), eBonus) * iChange));
}
for (iI = 0; iI < GC.getNumBuildingInfos(); iI++)
{
if (getNumActiveBuilding((BuildingTypes)iI) > 0)
{
for (int iJ = 0; iJ < NUM_YIELD_TYPES; iJ++)
{
updateYieldRate((BuildingTypes)iI, (YieldTypes)iJ, ((getBuildingYieldChange((BuildingClassTypes)(GC.getBuildingInfo((BuildingTypes)iI).getBuildingClassType()), (YieldTypes)iJ)) + (GC.getBuildingInfo((BuildingTypes)iI).getBonusYieldChanges(eBonus, iJ) * getNumActiveBuilding((BuildingTypes)iI) * iChange)));
if (bLostVicinityBonus)
{
[COLOR="Red"]updateYieldRate((BuildingTypes)iI, (YieldTypes)iJ, ((getBuildingYieldChange((BuildingClassTypes)(GC.getBuildingInfo((BuildingTypes)iI).getBuildingClassType()), (YieldTypes)iJ)) + (GC.getBuildingInfo((BuildingTypes)iI).getVicinityBonusYieldChanges(eBonus, iJ) * iChange)));[/COLOR]
}
}
}
}
/************************************************************************************************/
/* Afforess END */
/************************************************************************************************/
}Maybe you will ask me why? Just read the code in these functions:
Code:
bool CvCity::hasVicinityBonus(BonusTypes eBonus) const
{
//No sense in checking...
if (!hasBonus(eBonus))
{
return false;
}
bool bHasVicinityBonus = false;
for (int iI = 0; iI < [COLOR="red"]getNumCityPlots(); [/COLOR]iI++)
{
CvPlot* pLoopPlot = plotCity(getX_INLINE(), getY_INLINE(), iI);
if (pLoopPlot != NULL)
{
if (pLoopPlot->getBonusType() == eBonus)
{
if (pLoopPlot->getOwnerINLINE() == getOwnerINLINE())
{
if (pLoopPlot->isHasValidBonus() && pLoopPlot->isConnectedTo(this))
{
bHasVicinityBonus = true;
break;
}
}
}
}
}
if (!bHasVicinityBonus)
{
return false;
}
return true;
}
Code:
int CvCity::getNumCityPlots() const
{
int iRadius;
int var_city_plots;
if (getCultureLevel() == -1)
{
return NUM_CITY_PLOTS_1;
}
iRadius = GC.getCultureLevelInfo(getCultureLevel()).getCityRadius();
switch (iRadius)
{
case 3:
var_city_plots = NUM_CITY_PLOTS;
break;
case 2:
var_city_plots = NUM_CITY_PLOTS_2;
break;
case 1:
var_city_plots = NUM_CITY_PLOTS_1;
break;
default:
var_city_plots = NUM_CITY_PLOTS_2;
break;
}
return (var_city_plots);
}Do you remember that you changed the calculation method of city's culture radius? I guess this old way will not get the city's real working plots. To avoid this bug without modify many codes, I suggest you simply disable this feature temporarily.
lichen8566
Warlord
There is my save for debugging, and some helpful informations to debug it. Wish this can help you. ( the first turn after end the current turn will construct the stoneworker's hut. the second turn and next, the bug comes. )
x 32 y 31 The plot of stone resource.
x 31 y 33 city plot.
"BUILDING_STONEWORKER" BuildingTypes 378 BuildingClassTypes 339
Stone Resource eBonus == 8
source revision 133.
A New Dawn.log:
P.S. A little advice: Do not call other functions in a function, and use their returned values as parameters. That's will be hard to read or debug. Define some variables and pass them instead.
x 32 y 31 The plot of stone resource.
x 31 y 33 city plot.
"BUILDING_STONEWORKER" BuildingTypes 378 BuildingClassTypes 339
Stone Resource eBonus == 8
source revision 133.
A New Dawn.log:
Spoiler :
P.S. A little advice: Do not call other functions in a function, and use their returned values as parameters. That's will be hard to read or debug. Define some variables and pass them instead.
Afforess
The White Wizard
Unless I'm missing something, I'm not sure that is the problem. CvCity::hasVicinityBonus() does check that you own the plot's:
Code:
bool CvCity::hasVicinityBonus(BonusTypes eBonus) const
{
//No sense in checking...
if (!hasBonus(eBonus))
{
return false;
}
bool bHasVicinityBonus = false;
for (int iI = 0; iI < [COLOR="red"]getNumCityPlots(); [/COLOR]iI++)
{
CvPlot* pLoopPlot = plotCity(getX_INLINE(), getY_INLINE(), iI);
if (pLoopPlot != NULL)
{
if (pLoopPlot->getBonusType() == eBonus)
{
[COLOR="Blue"]if (pLoopPlot->getOwnerINLINE() == getOwnerINLINE())[/COLOR]
{
if (pLoopPlot->isHasValidBonus() && pLoopPlot->isConnectedTo(this))
{
bHasVicinityBonus = true;
break;
}
}
}
}
}
if (!bHasVicinityBonus)
{
return false;
}
return true;
}scribbler
Warlord
Wouldn't it be easiest to change the count for worked tiles to a city resource count? Sure, it would include resources outside of the city radius, but at least it would work.
lichen8566
Warlord
Yes, you're right. I checked the count of plots owned by my city, it's 17. And the getNumCityPlots() returns 21. So the resource plot must be checked. I just think that is it any chance of this function returns a plots count which less than actual count?
And for the reason of losing bonus resource, I found this:
Spoiler :
lichen8566
Warlord
I found a new clue about this bug: when the function recalculatePlots() is called, it refreshes all plot groups of the player. And for every plots in a group, its owner will be set to null and restored by function CvPlot::setPlotGroup(PlayerTypes ePlayer, CvPlotGroup* pNewValue).
When set the owner plot group of the city's plot ( x 31 y 33 in my save ) to null, the group pointer of the plot which has bonus resource is valid, so it knows there is vicinity bonus.
But after all plots of this group was removed from its group ( set to null ), and then the owner group of vicinity bonus plot ( x 32 y 31 in my save ) was restored by the CvPlot::setPlotGroup function, the plot instance use its m_plotCity member to find the city which need to restore the yields. But, unfortunately, the value of the m_plotCity member always is -1, even before the plot was removed from its group.
They are the code details below:
I guess there are some bugs of calculating the city's plots.
Edited:
Interesting, I missed the updatePlotGroupBonus(true); function call at the end of setPlotGroup() function. This function iterate all plots in the group, it will change the city's bonus by the city's plot. Though the bonus' plot has the right group value this time, but the bonus of the city already has been added, so the processBonus(eIndex, 1, bHadVicinityBonus != bHasVicinityBonus); function will be ignored.
When set the owner plot group of the city's plot ( x 31 y 33 in my save ) to null, the group pointer of the plot which has bonus resource is valid, so it knows there is vicinity bonus.
But after all plots of this group was removed from its group ( set to null ), and then the owner group of vicinity bonus plot ( x 32 y 31 in my save ) was restored by the CvPlot::setPlotGroup function, the plot instance use its m_plotCity member to find the city which need to restore the yields. But, unfortunately, the value of the m_plotCity member always is -1, even before the plot was removed from its group.
They are the code details below:
Spoiler :
I guess there are some bugs of calculating the city's plots.
Edited:
Interesting, I missed the updatePlotGroupBonus(true); function call at the end of setPlotGroup() function. This function iterate all plots in the group, it will change the city's bonus by the city's plot. Though the bonus' plot has the right group value this time, but the bonus of the city already has been added, so the processBonus(eIndex, 1, bHadVicinityBonus != bHasVicinityBonus); function will be ignored.
scribbler
Warlord
Hi Afforess,
Found a small bug (especially compared to the problem you're talking over with lichen) in ver.133. Put it on sourceforge, but not sure if you saw it. Has to do with Great Commanders not receiving any xp. Improved XP on/off doesn't change it.
Found a small bug (especially compared to the problem you're talking over with lichen) in ver.133. Put it on sourceforge, but not sure if you saw it. Has to do with Great Commanders not receiving any xp. Improved XP on/off doesn't change it.
Hashishim
Prince
Not to sure wether its a bug or on my side, but yeah was running a clean version of a New Dawn, and in the diplomacy screen, for vote for me in the U.N. when i click on it i get no response or no reaction in the diplomacy screen from the AI player, tried most of them. Any idea?
scribbler
Warlord
I've noticed this with the Apostolic Palace. You ask them to vote for you - it's either available or not. They don't ask for anything for voting for you.
Hashishim
Prince
but do they still vote for you?
gramcrkr103
Warlord
Its the same for the UN as well. Except if you ask what a civ wants for its vote, it will be happy trading it for nothing. If you ask 2 or 3 more civs and repeat the process, the game crashes
Afforess
The White Wizard
Yeah, I am going to disable those until I have time to fix them. Thanks for the reminder.
Afforess
The White Wizard
Just a teaser: this is what I have been working on the last day; A new Civilopedia tab, "Building Upgrades"
Useful for people who want to see the big picture.
Spoiler :
Useful for people who want to see the big picture.
Similar threads
