AND2 and SVN Bug Reports - A New Dawn 2 ONLY

[valergrad]

I'm checking the code and Imperium might be responsible, although I am not sure how and I haven't reproduced the bug yet.

Finally I got it! If you need the save to reproduce - here it is.
Just finish the current turn, and Lenin will convert to Imperium.
And this will cause that
1. My science slider move from 100% to 95%
2. All espionage weights in espionage screen will be filled by some numbers ( currently all 0 except Hatshepsut).

I have tried this 3 times and it always happens.

 

[valergrad]

Continue.
Debug of this save shows that:

void CvPlayer::updateSeizedForeignConnectednessPercent() calls GET_PLAYER((PlayerTypes)iI).AI_doCommerce(); -> this doCommerce is what calculating sliders for sci, cult, esp

And it calls this function for another player ( in this case Lenin calls it for human player ).

And in this function first what we see is:
FAssertMsg(!isHuman(), "isHuman did not return false as expected");
this assert of course fails in our case - bad symptom.

So, first idea would be just don't call this function here if player which we are trying to seize commerce is human.
But then we could probably will face someday issue that somebody don't have money for seizedCommerce and we actually should move his slider but we won't.
Probably we should write in this case some special shortcut logic to process special case for human.
Let's think about it.

UPD: Looks like we have special function for this.
So, I've just added into this function this code:

if (isHuman())
{
verifyGoldCommercePercent();
return;
}

and it looks like it solves the issue! ( will play with this fix for some amount of time tomorrow )

 

[valergrad]

 

[45°38'N-13°47'E]

Don't bother with the other languages. Just tag them out using <!-- and --> so the translators will see that they have work with these lines - again.

Are you sure it works like that? I never looked into how translation works because that was dbkblk's job.

 

[<Nexus>]

Are you sure it works like that? I never looked into how translation works because that was dbkblk's job.

If they play the mod they will see that what they have translated before is now in English only again. If they play it...

I think not translated texts are still better then misleading ones.

 

[45°38'N-13°47'E]

If they play the mod they will see that what they have translated before is now in English only again. If they play it...

I think not translated texts are still better then misleading ones.

Oh, I see, I thought you meant some kind of automated process. If I'm not mistaken dbkblk's translation platform is not RAND-specific; I mean, I think many people translated the mod but never played with it, they just translated some strings off that platform. So I wouldn't count on that. But I agree that not translated text is better than misleading text.

 

[<Nexus>]

I mean, I think many people translated the mod but never played with it, they just translated some strings off that platform.

That explains many inaccuracies
You cannot correctly translate a book without reading the whole thing.

 

[45°38'N-13°47'E]

That explains many inaccuracies
You cannot correctly translate a book without reading the whole thing.

I know what you mean, especially because my wife's an interpreter and she always tells me so that's why when I asked her to apply for a translator's job 10 years ago for Ship Simulator, she got the job and I got her free copy of the game (only for translation testing purposes, of course )

 

[valergrad]

Zepolak, if you'll send me your save with "Leonardo Workshop" science skyrocketing bug - I can look at evening. Can't promise anything as I am still newbie, but I can look.
In my current game, Leonardo was built by AI... and I haven't noticed it got huge boost in science for now.

 

[rtt4a]

Zepolak, if you'll send me your save with "Leonardo Workshop" science skyrocketing bug - I can look at evening. Can't promise anything as I am still newbie, but I can look.
In my current game, Leonardo was built by AI... and I haven't noticed it got huge boost in science for now.

@velergrad , I understand that this long shot but worth to ask anyway since we have you around now

Theres mysterious MAFs that only happens to some players. They started around 10-15 revisions ago (or something like that).
They cant be because real memory issues, can happend on any size of map and any point of game. My self see them often after opening WB due map modding..
Typical situation is that I have opened WB and stayed there for while and after I close is MAF happens.

So maybe you know where to check If I remember corret it was 1067 rev when these started to happend. Before that I coul play any size of maps without any problems. If needed I can go through old postings and find out exact revision when reports started.

Megaciv pack and 100civ dll has been suspected but since players who dont use neither of those have reported MAFs it cant be them..

 

[valergrad]

@velergrad , I understand that this long shot but worth to ask anyway since we have you around now

Theres mysterious MAFs that only happens to some players. They started around 10-15 revisions ago (or something like that).
They cant be because real memory issues, can happend on any size of map and any point of game. My self see them often after opening WB due map modding..
Typical situation is that I have opened WB and stayed there for while and after I close is MAF happens.

So maybe you know where to check If I remember corret it was 1067 rev when these started to happend. Before that I coul play any size of maps without any problems. If needed I can go through old postings and find out exact revision when reports started.

Megaciv pack and 100civ dll has been suspected but since players who dont use neither of those have reported MAFs it cant be them..

How to reproduce it? Like open WB , wait 15 minutes and close it?

 

[rtt4a]

How to reproduce it? Like open WB , wait 15 minutes and close it?

Dont know can you reproduce it.. I have strong feeling that it needs some special compilation of options, civilizations in game maybe? computer etc..

You can try this, it works ~85% for me. Start game (I use huge map) as many civs as you can. Then turn on bonus flags and open WB and reveal whole world for you. After this spend some time scrolling map etc.. then close WB and if you see that map is still revealed then you know you have got MAF. Sometimes I got error report and sometimes just crash on desktop..

Edit: forgot to say that before all do one turn so all civs have their capitals on map.. not needed for MAF but i get it easier like this
Edi2: also forgot to say that opening and closing WB often do the trick. It wont usually happen after first time visiting in WB.. When i mod map i can easily open and close WB many times, it seems to be tricker for MAFs..

 

[rtt4a]

https://forums.civfanatics.com/thre...new-dawn-2-only.474185/page-346#post-15535195

check this @velengrad

 

[steven77]

the latest update crashes the game! i click on the lancher,it loads for a bit,then....nothing!

 

[steven77]

fixed it.... i reset the mod to the default state,set again the civ exe...and somehow it worked.

 

[steven77]

ok.....now my old save crashes.....something is rong with the new revision guys.

 

[<Nexus>]

ok.....now my old save crashes.....something is rong with the new revision guys.

Don't take it granted that saves are compatible between revisions. Actually, this is normal behaviour but AND2 is improved and usually it doesn't happen.
Start a new game to see if it really is wrong or not.

 

[45°38'N-13°47'E]

ok.....now my old save crashes.....something is rong with the new revision guys.

That depends on how old your savegame is in terms of revisions. Nothing fundamental has been changed in the latest updates and I have no problem in loading older saves. Usually compatibility is broken only sometimes when new tags are added without proper coding, but this is definitely not the case now. The updater/launcher is broken again somehow, so I suggest using the offline patcher for now. Or using the updater a couple of times while deleting the file "updating" which is created inside RAND folder because for some reason it should be automatically deleted but it's not and this prevents the launcher from actually working, pushing it in a loop when you start it. Careful if you use MCP or other modmods because you'll probably have to reinstall them.

 

[steven77]

Don't take it granted that saves are compatible between revisions. Actually, this is normal behaviour but AND2 is improved and usually it doesn't happen.
Start a new game to see if it really is wrong or not.

the save was from the previous rev.

 

[steven77]

That depends on how old your savegame is in terms of revisions. Nothing fundamental has been changed in the latest updates and I have no problem in loading older saves. Usually compatibility is broken only sometimes when new tags are added without proper coding, but this is definitely not the case now. The updater/launcher is broken again somehow, so I suggest using the offline patcher for now. Or using the updater a couple of times while deleting the file "updating" which is created inside RAND folder because for some reason it should be automatically deleted but it's not and this prevents the launcher from actually working, pushing it in a loop when you start it. Careful if you use MCP or other modmods because you'll probably have to reinstall them.

the save was from the previous rev. guys....