Seems that was the only issue
good, solved it on my side too
I have a question regarding adding civs. Is it hard to convert civs so that they work as in Diversica WoC structure? I am thinking of converting Civ GOLD civs for example. I do not really know where to start except for the basics that I need to add info for BBAI, RebelTypes, Inquisitions etc.
Converting civs is easy, in fact any Civ Gold civ should work right out of the box, as they are modular. Converting them to WoC format makes them somewhat more modular (most of which I do not even use, other than optional leaderhead packs), but is not really needed.
As you said, you have to / should add them to the RebelTypes, I don't think you need to add them anywhere else (at least I did not...).
You will need some of the new RevDCM tags however (BBAI for leaderheads), maybe that is what you meant.
On top of that, you might want to use some of the unit artstyles / citystyles I added / included, instead of using the Civ Gold ones.
Finally, you need to change the MLF info, to include the directory you are putting the new civ in and a separate MLF file for every directory in the civ that includes sub-directories, see e.g. Assets\Modules\Civilizations\Poland.
If you keep everything in one dir (also an option), you obviously only have to change the MLF of the dir to which you add your civ
Also if you could point me in some direction regarding the Domestic Advisor not working maybe I can help out.
Not really, it definitely is in the way I modularized RevDCM, not any of the stuff I added on top of that. Other than that I did not manage to take a closer look yet.
So if you want to take a look, simply delete all Assets\Modules dirs, other than Assets\Modules\RevDCM and Assets\Modules\CIVFixes, as these two contain RevDCM data I changed from Assets\XML to a modular format.
Whatever the error is, it is in how I modularized it or the fact that I did it at all (i.e. it cannot be modularized).