Mod-Modders Guide to Fall Further

WarKirby · Apr 21, 2009

ok, having more problems

the spells to take the sword aren't working. My spellinfos.xml

Spoiler :

All the references in there are correct, no xml errors on startup. The spells just don't appear for other units in his tile, to take Justice.
I just copied the spells from War and changed some references.
What am I doing wrong?

Valkrionn · Apr 21, 2009

Trying to block Duin from being built if a new Doviello leader (Baron Duin

) is in game, and currently alive. Does this block of code accomplish that, or am I doing it horribly wrong? Don't have time to test it just now. :lol:

Put the relevant text in bold.

Code:

if eUnit == gc.getInfoTypeForString('UNIT_DUIN'):
	if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_NO_DUIN):
		return True
[B]	iDuin = gc.getInfoTypeForString('LEADER_DUIN')
	for iPlayer in range(gc.getMAX_PLAYERS()):
		pLoopPlayer = gc.getPlayer(iPlayer)
		if pLoopPlayer.getLeaderType() == iDuin and pLoopPlayer.isAlive():
			return True[/B]

Edit: Never mind, just tested it. Works exactly as intended... Duin cannot be built if he is in game as a leader, but if he does not start as a leader or if he is killed, he becomes available as a hero. :goodjob:

RogueThunder · Apr 21, 2009

Hm. A quick question. How would one go about adding a trait to a leader... preferably through an event.

Valkrionn · Apr 21, 2009

I can't speak from personal experience, but from looking at how the Elohim do it, create an event in the xml, and in the python portion have something along the lines of

Code:

def doRemnantsOfPatria(argsList):
	iEvent = argsList[0]
	kTriggeredData = argsList[1]
	iPlayer = kTriggeredData.ePlayer
	pPlayer = gc.getPlayer(iPlayer)
	CyMessageControl().sendApplyEvent(5013, EventContextTypes.EVENTCONTEXT_ALL, (iPlayer,gc.getInfoTypeForString('TRAIT_INDUSTRIOUS'),True))

Although, I can't tell why pPlayer is necessary... it's not used at all.

xienwolf · Apr 21, 2009

Valkrionn said:
Trying to block Duin from being built if a new Doviello leader (Baron Duin ) is in game, and currently alive. Does this block of code accomplish that, or am I doing it horribly wrong? Don't have time to test it just now. Put the relevant text in bold.

Code:

if eUnit == gc.getInfoTypeForString('UNIT_DUIN'): if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_NO_DUIN): return True [B] iDuin = gc.getInfoTypeForString('LEADER_DUIN') for iPlayer in range(gc.getMAX_PLAYERS()): pLoopPlayer = gc.getPlayer(iPlayer) if pLoopPlayer.getLeaderType() == iDuin and pLoopPlayer.isAlive(): return True[/B]

Edit: Never mind, just tested it. Works exactly as intended... Duin cannot be built if he is in game as a leader, but if he does not start as a leader or if he is killed, he becomes available as a hero.

You could actually do this a lot quicker by checking for the Civ Duin can lead first:

Code:

if eUnit == gc.getInfoTypeForString('UNIT_DUIN'):
	if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_NO_DUIN):
		return True
	iDuin = gc.getInfoTypeForString('LEADER_DUIN')
	iDoviello = gc.getInfoTypeForString('CIVILIZATION_DOVIELLO')
	iNumDoviello = CyGame().getNumCivActive(iDoviello)
	for iLoop in range(iNumDoviello):
		pLoopPlayer = CyGame().getCivActivePlayer(iDoviello, iLoop)
		if pLoopPlayer.getLeaderType() == iDuin:
			return True

This way if there aren't any Doviello in the game (and alive), nothing is checked at all. If there ARE any Doviello, then we ONLY check the leaders of the Doviello Civs to see if any are Duin. Now instead of looping over 50 players, many of whom aren't alive and never had been, you only loop over the number of actual Doviello civs, most likely just one, if any.

Valkrionn · Apr 21, 2009

Ah, very nice. That'll work much better, thank you. :goodjob:

MagisterCultuum · Apr 21, 2009

It would probably be a good idea to make Angel/Manes gifting work like that too, and probably to make them only go to one random player of that civ instead of to all of them.

xienwolf · Apr 21, 2009

Aparently you haven't looked at our code in a while, it DOES work this way already. I've left it to grant units to all civilizations of that type for now though as I don't know of it being used for anything where such an issue comes up, so don't particularly need it fixed.

Valkrionn · Apr 21, 2009

It probably won't need to only give it to one civilization randomly until Notque incorporates his modmod. :lol:

WarKirby · Apr 21, 2009

don't suppose anyone can help with my issue? *points a few posts up*

Valkrionn · Apr 21, 2009

I would, but I've never messed with equipment before. Would be rather difficult to go through it all and find out... Think this is one for Xienwolf.

xienwolf · Apr 21, 2009

Your python command says EQUIPMENT_JUSTICE, but your prereq in stack is PROMOTION_JUSTICE. Since you don't get an XML error, I would assume that the first one is wrong, so that needs changed.

WarKirby · Apr 21, 2009

It seems you're right, xien Looking though the python, it seems to be expecting a promotion, and I've referenced a unit.
The promotion is called PROMOTION_JUSTICE, the unit is EQUIPMENT_JUSTICE

However, in my defence,it's kael's mistake, not mine. I just copied the template from War and altered a few things. In fact, all of the equipment taking spells are like this, as far as I can see. Referencing a unit where it should be a promotion. Why do any of them work at all, and why doesn't mine if this is the case ?

On another note, it's decided it no longer wants to load, anyways. And is now throwing generic xml errors. What could cause an "xml load call failed for civ4spellinfos.xml" The file is exactly as I posted above, unchanged, but it just refuses to load now. I'm not running any other modules with it atm, which seemed to be the problem before.

WarKirby · Apr 21, 2009

Oh, I misread what you said. The FIRST one.

Well, I don't think that is wrong either. War Does that too, look:

Spoiler :

Important part bolded.

Having a closer look at the spells, it seems that reqTakeEquipmentPromotion takes the name of the equipment unit, and gets the promotion from that. Seems like an odd way to do it. Wouldn't the logical method just be to directly pass the promotion name into the promotion version?

xienwolf · Apr 22, 2009

We have the units alphabetical, with equipment first, and promotions alphabetical with equipment first. Lucky coincidence that they happen to match up on index because of that.

EDIT: Or if you just looked at the python with your second post maybe it does account for things decently. Anyway.... Equipment has a huge overhaul planned as well, one day it'll be REAL easy to add new equipment, just a single boolean in the promotion(and possibly building too) instead of a promotion/unit/spell/spell(and possibly building/spell too)

sylvain5477 · Apr 22, 2009

Hi,

I'm back with another question:

I intended to use the following part of the promotion infos to gain beakers when killing a unit:

<CommercesFromWin>
<iCommerce>0</iCommerce> 
<iCommerce>10</iCommerce> 
<iCommerce>0</iCommerce> 
</CommercesFromWin>

However, while my unit does have the promotion and it indeed specifies in the promotion text ingame that it will give 10 beakers per kill, no beaker are added when winning from defense combat or offense ones.

Any idea whether it is broken at the moment ? (seemed used for gold only in FF in the Bounty Hunter promo).

Valkrionn · Apr 22, 2009

xienwolf said:

Code:

if eUnit == gc.getInfoTypeForString('UNIT_DUIN'):
	if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_NO_DUIN):
		return True
	iDuin = gc.getInfoTypeForString('LEADER_DUIN')
	iDoviello = gc.getInfoTypeForString('CIVILIZATION_DOVIELLO')
	iNumDoviello = CyGame().getNumCivActive(iDoviello)
	for iLoop in range(iNumDoviello):
		pLoopPlayer = CyGame().getCivActivePlayer(iDoviello, iLoop)
		if pLoopPlayer.getLeaderType() == iDuin:
			return True

Doesn't appear to be working...Duin is in game, and I'm still able to construct him. :confused:

WarKirby · Apr 22, 2009

Ok, I'm stumped. And probably going to go bald from tearing my hair out.

I just keep getting generic xml errors for the spellinfos file. No linenumber or source of the problem. just "xml load call failed". It refuses to tell me why.

My current progress is attached to this post. Could anyone have a look and possibly try to figure out what's wrong?

One thing I can think of, do pyreqs and effects work in modules? I'm only referencing stuff that's already in FF, so I don't see why not. but perhaps that's yet another shortcoming of this frustrating module system.

Sephi · Apr 22, 2009

The sabathiel_CIV4UnitSpellSchema file is missing. I added it and it worked.

xienwolf · Apr 22, 2009

sylvain5477 said:
Hi,

I'm back with another question:

I intended to use the following part of the promotion infos to gain beakers when killing a unit:

<CommercesFromWin>
<iCommerce>0</iCommerce> 
<iCommerce>10</iCommerce> 
<iCommerce>0</iCommerce> 
</CommercesFromWin>

However, while my unit does have the promotion and it indeed specifies in the promotion text ingame that it will give 10 beakers per kill, no beaker are added when winning from defense combat or offense ones.

Any idea whether it is broken at the moment ? (seemed used for gold only in FF in the Bounty Hunter promo).

The research you gain will be toward the TechPrereq of the unit you killed or any promotions on the unit. It is meant as a "reverse engineering" concept, so you won't wind up learning Omniscience after killing a warrior.

Valkrionn said:
Doesn't appear to be working...Duin is in game, and I'm still able to construct him.

I would say at this point to add some text output so that you can debug the values and where the code is stopping at. Or possibly a spelling error in one of the getInfoType settings.

Mod-Modders Guide to Fall Further

Arty person

The Hamster King

Warlord

The Hamster King

Deity

The Hamster King

Great Sage

Deity

The Hamster King

Arty person

The Hamster King

Deity

Arty person

Arty person

Deity

Cerebrus father

The Hamster King

Arty person

Attachments

Deity

Deity

Similar threads