Platyping's Python

[platyping]

	def onCityAcquiredAndKept(self, argsList):
		'City Acquired and Kept'
		iOwner,pCity = argsList
## Test ##
		pPlayer1 = gc.getPlayer(pCity.getOwner())
		pPlayer2 = gc.getPlayer(iOwner)
		pPlayer2.changeGoldenAgeTurns(8)
		pPlayer1.changeGoldenAgeTurns(5)
## Test ##
		CvUtil.pyPrint('City Acquired and Kept Event: %s' %(pCity.getName()))

Some simple tests:
1) AI takes AI City
2) Human takes AI City
3) AI takes Human City

Results:
1) iOwner is always human NOT previous owner as Jamie stated.
Even when AI takes another AI City, GA(8) is triggered for human.
2) pCity.getOwner() always refer to the new owner correctly.
3) onCityAcquiredAndKept is only triggered for Conquer by Force.
Not triggered by Trade, useless function.

 

[j_mie6]

Wait.. you are saying that the variable iOwner, in ALL cases refers to the human?! what is the point in that?!

Are you also saying that getOwner() in all cases gives the correct value?

And as I didn't test AI vs AI I presumed that it was previous owner as the human was the previous owner.

I might have to take a wander into the SDK later and see if I can't find the route of the event and track down why the human is used...

edit: well, now I know how the Events in python work now I can now define my own for my mod. That was productive. Anyway, looking in the SDK the python event is triggered within the method CvPlayer::aquireCity(), but it passes into it getID() which will get the CvPlayer instance's ID. ie: it should work fine so I have no clue why it doesn't work properly

 

[platyping]

Those 2 packs are mainly there for newbie modders to double check whether they have merged 2 or more wonders together, mainly the python codes.
Of course, they are playable but I doubt anyone actually played them on their own since most pple will just take some and add to their own mods.

Too lazy to make this kind of options, and either way, it is not gonna help in reducing the number of python codes in those 2 packs, since when you train a new unit, it will still ask does the player has Brandenburg for instance, even if Brandenburg is not built or disabled.
It will just reduce the number you can build, but does not reduce the number of codes activated, which is actually the main problem with those 2 packs, as running a mod with 200 python wonders is definitely taxing in late game big maps, so not much point though.

 

[AbsintheRed]

Looked through all your wonders once again, mostly checking the building art
It's a wonderful compilation! Most of them look absolutely great and realistic

Do you still have wonder art to be used?
I ran through my mod, and have a couple there if you need some ideas
St. Sophia, Dome of the Rock, La Mezquita and All Saints' Church (Wittenberg) have realistic buildings directly based on the wonders
Also the Kazimierz, which is the Old Synagogue of Krakow
La Lanterna, Krak de Chevaliers, Tower of London, Westminster Abbey and Temple Mount are also close enough to their real-life counterparts, worthy enough to be represented by them IMO
You might find some useable building art in some of the other wonders too

PS: Some medieval project ideas: Golden Bull and King Richard's Crusade
PS2: The art you use for JS Bach Cathedral is supposed to be Stephansdom AFAIK
PS3: There is a very nice castle graphics under Chateau de Fontainebleau, which is currently unused here

 

[platyping]

Thanks, most of my wonder art are taken from Hrochland or dacubz's thread directly, and some from database from old artists like Refar or asioasioasio.

I checked RFCE before, there are quite a number of wonder names I have not done, but those with nice artwork unused are mostly religious ones.
There are still quite alot of religious ones made by Hrochland which I have not used and well, it is hard to keep thinking of benefits that fit religious ones, after all it is mostly about, temples, monastries, spread religion etc.

Crusade has been made by tsentom1 before, which I simplified its effects, although you are right. Come to think of it, it does fit a project more than a wonder.
Yeah, Bach Cathedral is definitely not Bach's own model, since I doubt there is one real one, just like Leonardo's Workshop or Newton's university.

 

[platyping]

Edits:

Palacio de Pena
Uses getHeadSelectedCity() to replace usage of a loop.
Benefits still same, just more efficient codes.

Crusade
Changed to Project from Wonder
Since it is now a project, benefits applied to whole team rather than just player.

Spoiler :

@Golden Bull
I looked at it, it is something like how to select the king?
Not sure what kind of benefits suitable for it...

 

[AbsintheRed]

@Golden Bull
I looked at it, it is something like how to select the king?
Not sure what kind of benefits suitable for it...

It's similar to the Magna Carta, one of the earliest edicts of this kind.
Magna Carta 1215, Golden Bull 1222
Also, the hungarian king wasn't forced into it as King John

Bonus can be tied to the king if you like that
I don't know, maybe extra gold/culture from every "we love the king day"?

Also, wanted to point out that the art you use for the Cairo Citadel is not the Blue Mosque of Cairo, but the Blue Mosque of Istanbul (Sultan Ahmed Mosque)

 

[platyping]

Independence Day

Spoiler :

Not sure if this sounds like a project... but whatever
Team Project
Useful if you are forced to be a vassal and you wanna break free.
Master cannot declare war on you for 10 turns, so enjoy your golden age.

@AbsintheRed
Yeah I know there are some wonders using artwork that are actually artwork of some other real buildings.
Nalanda University is using an Indian Mosque by Hrochland (forgot whats the name), since it is long destroyed and god knows how it looks like.
Cairo Citadel, well there isn't any artwork made specially for it, so I just picked one that resembles it. At least I didn't pick a temple
Catacombs is another one. Although it is in the list of 7 medieval wonders, nobody ever bothered about it, so there wasn't any artwork either.
I think there are more in the list...

 

[AbsintheRed]

I guessed it was more or less intentional
And of course understand that perfectly suitable art is hard to find
In this case though the difference was way too obvious and significant - but maybe just for me...

If I were you I would add some kind of middle eastern castle art for the Cairo Citadel (as the effects only suits a military building)
I saw one in Walter Hawkwood's pack which is unused here. Mideast fort 2 or 3
Also I would add the Sultan Ahmed Mosque separately
The art is way too good for that wonder to misuse it

PS: Don't you have 181 wonders right now?
Crusade was changed to be a project

 

[platyping]

Well, seeing that the real Cairo Citadel looks like this in the movie screenshot, actually this mosque is not such a bad substitute for it lol, since both got those round tops and pillars + a squarish base.

Spoiler :

Yeah, -1 wonder, +1 project

P.S.
Hoover Dam is something i wanna make next, but I doubt there is any artwork available again

 

[AbsintheRed]

Yeah, the 2 mosques are rather close in appearance
What I meant that you use the Citadel as the wonder, not the mosque in it (which is only a small part of the complex)
Bonuses are for a fortification, not for a cathedral
Thus I would split it:
- Something more military-looking for the Citadel, some sort of mideastern castle to represent it. This is Walter's fort pack I mentioned
- The Sultan Ahmed Mosque as a separate wonder, with a perfect art for it. I can try to come up with a cool bonus if that's the problem

No pressure though, I will leave it there if you don't like my idea

 

[Alrik2002]

Hi platyping,

for the trait philosophical you wrote in onCityAcquired:

## Philosophical Trait Start ##
		if pCity.getNumBuilding(gc.getInfoTypeForString("BUILDING_DORMITORY")):
			pCity.setNumRealBuilding(gc.getInfoTypeForString("BUILDING_DORMITORY"), 0)
			pPlayer.getCapitalCity().setNumRealBuilding(gc.getInfoTypeForString("BUILDING_DORMITORY"), 1)

All the others traits have a check to see if the new or the previous owner has some of this, f.e. the aggressive trait:

## Aggressive Trait ##
		if pCity.getNumActiveBuilding(gc.getInfoTypeForString("BUILDING_MILITARY_ACADEMY")):
			if pPlayer.hasTrait(gc.getInfoTypeForString("TRAIT_AGGRESSIVE")):
				pCity.changeFreeSpecialistCount(gc.getInfoTypeForString("SPECIALIST_GREAT_GENERAL"), -1)
			if pPlayer2.hasTrait(gc.getInfoTypeForString("TRAIT_AGGRESSIVE")):
				pCity.changeFreeSpecialistCount(gc.getInfoTypeForString("SPECIALIST_GREAT_GENERAL"), 1)

I believe this is missing for the philosophical trait. Could you please check that, since you´re the python god.

 

[platyping]

Yeah I can use one of the fort artwork, though not at the top of priority list.
Because like I said, there are too many unused religious wonder artwork lying around, both in RFCE as well as Hrochland's thread.
If one day I come up with a bonus fitting for a religious wonder, chances are it can fit any of them, rather than to a specific one. Thus, I will rather choose a new unused artwork instead of using the Mosque itself.

 

[PixelStrategist]

Does Independence day work if they vassal has capitulated?

 

[platyping]

Domitory is the building that provides the specialist bonus.
It will only be present if the player has Philosophy Trait.

Thus, if the city itself has the building, the previous player obviously has the trait, why bother to check if he has the trait.
And since the previous player has the trait, and he just lost the building, a new one is given to him.

As for the new player, whether he has the trait or not does not matter.
If he has the trait, he already had one, he definitely should not get a 2nd one.
If he does not have the trait, then he definitely should not get one either.

@Independence
Yes

 

[Alrik2002]

Ok. Thank you.

 

[platyping]

Hoover Dam

Spoiler :

Don't ask me why it looks like Three Gorges Dam...

It is just too famous to give it a miss

Edits:
Summer Palace
Codes moved from CityAcquiredAndKept to CityAcquired
Gigapack
Modern Era still too crowded, open up a 8th slot in Tech Screen

Megapack and Gigapack updated

I am also considering converting Marco Polo's Embassy to a Project rather than a Wonder.
1) Marco Polo never had an embassy, might as well call it MP's Expeditions or something
2) The benefits of "meeting all teams" is pretty much one-off effects, capturing it has no use, might as well set it as a project

@AbsintheRed
I was thinking of converting PO Box 1142 to Tower of London, since the capture Great People effect suits ToL pretty well, and PO Box was chosen at that time since, can't really find a prison/dungeon type of wonder.
However, the artwork in RFCE which is the same as the one I used for PO Box does not really fit ToL since ToL is white and the 4 pillars are pretty obvious.

 

[The_J]

The considerations about Marco Polo sound good .

 

[AbsintheRed]

I am also considering converting Marco Polo's Embassy to a Project rather than a Wonder.
1) Marco Polo never had an embassy, might as well call it MP's Expeditions or something
2) The benefits of "meeting all teams" is pretty much one-off effects, capturing it has no use, might as well set it as a project

@AbsintheRed
I was thinking of converting PO Box 1142 to Tower of London, since the capture Great People effect suits ToL pretty well, and PO Box was chosen at that time since, can't really find a prison/dungeon type of wonder.
However, the artwork in RFCE which is the same as the one I used for PO Box does not really fit ToL since ToL is white and the 4 pillars are pretty obvious.

I second both changes!
The art for the Tower of London is not perfect, I agree
But still much better than using the building as PO Box

 

[platyping]

Something Simple so that I can post the following updates:
Petronas Towers

Spoiler :

Most of the time, depending on gamespeed I guess, you actually gain gold rather than lose gold for spreading corporations with this.
I was thinking whether to reduce the gold so that you still lose abit rather than gain, but since it is a late game wonder, I guess it deserves some perks.

Artwork by Hrochland

Fixed Logic Error in Petronas. Sorry for whoever downloaded first

Marco Polo's Embassy:
Renamed to Marco Polo's Expeditions
Changed to Project
New Button

Spoiler :

PO Box 1142
Renamed to Tower of London
Changed to World Wonder
New Artwork by Walter Hawkwood
Python codes modified, but same effect

Spoiler :