[Extension] [POLL] More Wonders for VP

[adan_eslavo]

All wonders requiring Lake have busted requirements.
"Water = 1, MinAreaSize = 1" doesn't work anymore as Lake requirement. Better substitute with Lua.

It was always supported with lua.

-- checks if city is between River and Sea and adds this condition (normally it would be treated like city with Lake)
-- Sea and Lake        =    FreshWater == true,     Water>=1 == true            true
-- Lake and River    =    FreshWater == true,     Water>=1 == true            true
-- Sea and River    =    FreshWater == true,     Water>=1 == true            true? (should be false)
-- Sea                =    FreshWater == false,     Water>=1 == true            false
-- Lake                =    FreshWater == true,     Water>=1 == true            true
-- River            =    FreshWater == true,     Water>=1 == false            false
function IsLakeWithOcean(ePlayer, eCity, eBuilding)
    if not tValidIsNearLake[eBuilding] then return true end
    if bReachedMaxEra then return false end

    local pPlayer = Players[ePlayer]
 
    if not pPlayer:IsAlive() then return false end

    local pCity = pPlayer:GetCityByID(eCity)
    local iCityX = pCity:GetX()
    local iCityY = pCity:GetY()

    if pCity:IsCoastal(1) then -- city is adjacent to at least one water tile
        for dir = 0, DirectionTypes.NUM_DIRECTION_TYPES - 1 do
            if Map.PlotDirection(iCityX, iCityY, dir):IsLake() then
                return true
            end
        end
    end

    return false
end
GameEvents.CityCanConstruct.Add(IsLakeWithOcean)

-- IsNearLake
    -- add lake buildings ==> lake is when: FreshWater = 1, Water = 1, MinAreaSize = 1
    for building in GameInfo.Buildings() do 
        if building.FreshWater and building.Water and building.MinAreaSize == 1 and building.IsCorporation == 0 then
            local eBuilding = GameInfoTypes[building.Type]
          
            --dprint("...adding (id,building,requirement)", building.ID, building.Type, "(IsNearLake)")
            tValidIsNearLake[building.ID] = true
        end
    end

Question is, why it is not working. Any lua errors @gwennog?
How about other "lake" wonders?

 

[adan_eslavo]

Ok, found it. There's an error caused by VP cleanup.
This works:

-- IsNearLake
    -- add lake buildings ==> lake is when: FreshWater = 1, Water = 1, MinAreaSize = 1
    for building in GameInfo.Buildings() do
        if building.FreshWater and building.Water and building.MinAreaSize == 1 and not building.IsCorporation then
            local eBuilding = GameInfoTypes[building.Type]
         
            --dprint("...adding (id,building,requirement)", building.ID, building.Type, "(IsNearLake)")
            tValidIsNearLake[building.ID] = true
        end
    end

It was

building.IsCorporation == 0

and should be

not building.IsCorporation

You must paste it into UniqueWorldWonderRequirements.lua. Find similar function (look to post above).
Sorry for inconvienience.

 

[adan_eslavo]

"King Solomon's Mines" in neutral territory grants "For the King" promotion to adjacent workers despite the description mentioning this effect should only be applied for the wonder's owner.

Fixed. Also OnTile promotions like in Bermuda Triangle will be fixed in new version.

 

[gwennog]

Ok, found it. There's an error caused by VP cleanup.

Thank you very much Adan

 

[adan_eslavo]

Thank you very much Adan

No problem. If you find anything else, let me know. Is there anything I missed or forgot to resolve? Do you have smth in mind?

 

[gwennog]

No problem. If you find anything else, let me know. Is there anything I missed or forgot to resolve? Do you have smth in mind?

No, not at the moment, but I'll let you know when I see something in my games.

 

[radziu93]

Would you consider changing requirements for Malwiya Minaret? For now it has "Building: Stone Works", but I believe better option would be "Improvement: Quarry". As it is now, it gives unfair advantage to Songhay, because they have unique building that replaces Stone Works and can be built regardless of having any Quarries in the city.

 

[adan_eslavo]

Would you consider changing requirements for Malwiya Minaret? For now it has "Building: Stone Works", but I believe better option would be "Improvement: Quarry". As it is now, it gives unfair advantage to Songhay, because they have unique building that replaces Stone Works and can be built regardless of having any Quarries in the city.

I will look ast this.

 

[adan_eslavo]

Would you consider changing requirements for Malwiya Minaret? For now it has "Building: Stone Works", but I believe better option would be "Improvement: Quarry". As it is now, it gives unfair advantage to Songhay, because they have unique building that replaces Stone Works and can be built regardless of having any Quarries in the city.

Done.

 

[why7at]

can i get v24 beta?

 

[adan_eslavo]

can i get v24 beta?

It's not completed and compatible with current VP.

 

[enchi]

I get this missing text when I activate the mod using vp 4.22 with eui, TEXT_KEY_BUILDING_STONEHEDGE_HELP_CUT same with hanging garden, error is gone when I disable the mod.

 

[notaspambot]

Several random notes:
- Ggantija's requirements are missing a pair of brackets. Correct version:

UPDATE Buildings SET NearbyTerrainRequired = 'TERRAIN_GRASS' WHERE Type = 'BUILDING_GGANTIJA' AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='MW-SETTING-REQUIREMENT' AND (Value=1 OR Value=2));

- The mod could do with updating the resources table for the resources that spawn from wonders. It's technically a VP issue, as the VP team hasn't updated the table with the new requirements in AssignStartingPlots.lua, but it wouldn't hurt to keep things consistent in the mod in the meantime. Relevant code:

UPDATE Resources SET Hills = 1  WHERE Type = 'RESOURCE_SALT';
UPDATE Resources SET Hills = 1  WHERE Type = 'RESOURCE_COPPER';
UPDATE Resources SET Flatlands = 1  WHERE Type = 'RESOURCE_COAL';

- I noted this in a different thread, but since it also applies here: Line 88 in WonderPopup.lua has a faulty check; an undefined text key returns itself, not nil. Correct version:

if Locale.ConvertTextKey(strGameInfoCut) ~= strGameInfoCut then