Hi, I tested your mod few times and have some things to point out:
1. As i noticed all (or almost all) bonuses from CS are infinite. I tested declaring of war, waiting for influence to pass down the alliance threshold or signing some resolution about open borders with CS. When I changed value of line (bold) from 5 to 1 bonuses lasted only one turn:
majorPlayer:SetEventChoiceCooldown(GameInfoTypes["PLAYER_EVENT_CHOICE_" .. GameInfo.MinorCivilizations[minorPlayer:GetMinorCivType()].Type], 5).
When I set it to "2" some of the states worked correctly f. i. Valetta, Brussels.
2. Because of point 1 some of the bonuses (f. e. Zanzibar +1g to luxuries) lasted forever and stacked when I left the alliance and then created it again. Even changing code did nothing to it.
3. Some of the bonuses seem to not work (Wittenberg's +1f for GWAM, Monaco's 50% discount for banks (+4c for banks worked, but lasted forever).
4. When I played once and allied Kabul, EUI descriptions had wrong tooltips (natural wonder should have bonus +2c, but had +4c and at the same time mountains had no tooltip but got +2c.
5. I tested your mod with few latest versions of VP and no other mod in addition to avoid some conflict. Can VP make such problems?
I really like your idea of mod and want it to work, but when I try I got some bug everytime.
A