[MOD] v41 SVN and GithubDesktop Bugs and Crashes Single player

Ok, I opened those events, and I see some issues with one of them, there is no check on whether there actually is an improvement on the plot or not before it adds the button for the improvement with the message about it being destroyed.

Edit: nah it was there after all, in an indirect form, but I'll look over those events for other issues in any case.
 
Toffer90 said:
Ok, I opened those events, and I see some issues with one of them, there is no check on whether there actually is an improvement on the plot or not before it adds the button for the improvement with the message about it being destroyed.
Click to expand...
So mistimed code then?
 
Not sure if new, but City Raider 3 is unavailable for Mounted (and Melee or something), yet CR4 is again available.
I found it when building a Chariot next to a Chariot Archer.
The latter could go all the way to Multi-Attacking of CR5, but the former stopped at CR2.
I say it's a bug.
 
Somebody613 said:
Not sure if new, but City Raider 3 is unavailable for Mounted (and Melee or something), yet CR4 is again available.
I found it when building a Chariot next to a Chariot Archer.
The latter could go all the way to Multi-Attacking of CR5, but the former stopped at CR2.
I say it's a bug.
Click to expand...
If CR 3 isn't available, CR 4 is naturally unavailable as well so why specify that it is unavailable? Is there a display bug somewhere that doesn't understand that promotionline assumable inherited unavailability still? You could never get CR4 if you can't get CR 3. Clearly.

It's not a bug to deny CR3+ from mounted because much city fighting is done inside buildings, where a mounted unit is definitely not working as it is designed. Mounted too easily become able to abandon the use of foot units otherwise. They are intended to dominate in the open field usually and can take advantage of faster movement and mobility. If also allowed to be as capable of capturing cities, then early city capturing armies can too easily be made extremely fast, which is something we're trying to avoid until mechanical forces. That said, they should be used in city captures to wear down defenders with hit and run tactics or to run down highly weakened defending units.

IIRC, they still get access to Blitz through basic combat promos building up to the actual Blitz promo. I'm not 100% sure of that.
 
Thunderbrd said:
If CR 3 isn't available, CR 4 is naturally unavailable as well so why specify that it is unavailable? Is there a display bug somewhere that doesn't understand that promotionline assumable inherited unavailability still? You could never get CR4 if you can't get CR 3. Clearly.

It's not a bug to deny CR3+ from mounted because much city fighting is done inside buildings, where a mounted unit is definitely not working as it is designed. Mounted too easily become able to abandon the use of foot units otherwise. They are intended to dominate in the open field usually and can take advantage of faster movement and mobility. If also allowed to be as capable of capturing cities, then early city capturing armies can too easily be made extremely fast, which is something we're trying to avoid until mechanical forces. That said, they should be used in city captures to wear down defenders with hit and run tactics or to run down highly weakened defending units.

IIRC, they still get access to Blitz through basic combat promos building up to the actual Blitz promo. I'm not 100% sure of that.
Click to expand...
By "available" I meant that Pedia lists CR4 with Mounted, but like you said, it's unattainable by those Mounted due to CR3 not listing it.
So the bug is either CR3 or CR4, since the two contradict each other.
If you state that CR3 is correctly blocked off fom Mounted, then CR4 shouldn't list Mounted as an option, obviously.
 
Somebody613 said:
If you state that CR3 is correctly blocked off fom Mounted, then CR4 shouldn't list Mounted as an option, obviously.
Click to expand...
I have a hard time seeing a mere information display issue as a real bug worthy of addressing - at least with much priority. However, that said, I've known for a while that the way that the pedia displays what should be available to a unit has been ignoring the rules established by promotionlines and I honestly don't know where to fix that. I could probably chase it down but... again, less important than many more serious issues so I just haven't and don't plan to worry about it soon. Still, thanks for the reminder because it will probably be forgotten for a while again as it waits to be addressed.
 
Thunderbrd said:
I have a hard time seeing a mere information display issue as a real bug worthy of addressing - at least with much priority. However, that said, I've known for a while that the way that the pedia displays what should be available to a unit has been ignoring the rules established by promotionlines and I honestly don't know where to fix that. I could probably chase it down but... again, less important than many more serious issues so I just haven't and don't plan to worry about it soon. Still, thanks for the reminder because it will probably be forgotten for a while again as it waits to be addressed.
Click to expand...
Dude, sometimes the SIMPLEST solution is also the CORRECT one.
Code: 
        <PromotionInfo>
            <Type>PROMOTION_CITY_RAIDER4</Type>
            <Description>TXT_KEY_PROMOTION_CITYRAIDER4</Description>
            <Sound>AS2D_IF_LEVELUP</Sound>
            <PromotionPrereq>PROMOTION_CITY_RAIDER3</PromotionPrereq>
            <PromotionLine>PROMOTIONLINE_CITYRAIDER</PromotionLine>
            <iLinePriority>4</iLinePriority>
            <iCityAttack>25</iCityAttack>
            <UnitCombats>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_ARCHER</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MELEE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MOUNTED</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
Just remove the one(s) that aren't supposed to get it - ya know, the OLD "manual" STYLE.
LOL!
Though, yes, this does require a CHECK of all Promotions - but, hey, that's both quite simple and straightforward, and is needed in the end anyways.
 
Somebody613 said:
Dude, sometimes the SIMPLEST solution is also the CORRECT one.
Code: 
        <PromotionInfo>
            <Type>PROMOTION_CITY_RAIDER4</Type>
            <Description>TXT_KEY_PROMOTION_CITYRAIDER4</Description>
            <Sound>AS2D_IF_LEVELUP</Sound>
            <PromotionPrereq>PROMOTION_CITY_RAIDER3</PromotionPrereq>
            <PromotionLine>PROMOTIONLINE_CITYRAIDER</PromotionLine>
            <iLinePriority>4</iLinePriority>
            <iCityAttack>25</iCityAttack>
            <UnitCombats>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_ARCHER</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MELEE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MOUNTED</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
Just remove the one(s) that aren't supposed to get it - ya know, the OLD "manual" STYLE.
LOL!
Though, yes, this does require a CHECK of all Promotions - but, hey, that's both quite simple and straightforward, and is needed in the end anyways.
Click to expand...
Now I wonder how broken are those promotions....

Code: 
        <PromotionInfo>
            <Type>PROMOTION_CITY_RAIDER2</Type>
            <Description>TXT_KEY_PROMOTION_CITYRAIDER2</Description>
            <Sound>AS2D_IF_LEVELUP</Sound>
            <PromotionPrereq>PROMOTION_CITY_RAIDER1</PromotionPrereq>
            <TechPrereq>TECH_SEDENTARY_LIFESTYLE</TechPrereq>
            <PromotionLine>PROMOTIONLINE_CITYRAIDER</PromotionLine>
            <iLinePriority>2</iLinePriority>
            <iCityAttack>15</iCityAttack>
            <UnitCombats>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_ARCHER</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MELEE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MOUNTED</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_SIEGE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_GUN</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_HITECH</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_WHEELED</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_TRACKED</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_DREADNOUGHT</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
            </UnitCombats>
            <Button>,Art/Interface/Buttons/Promotions/CityRaider2.dds,Art/Interface/Buttons/Promotions_Atlas.dds,6,2</Button>
            <iCaptureProbabilityModifierChange>5</iCaptureProbabilityModifierChange>
        </PromotionInfo>
        <PromotionInfo>
            <Type>PROMOTION_CITY_RAIDER3</Type>
            <Description>TXT_KEY_PROMOTION_CITYRAIDER3</Description>
            <Sound>AS2D_IF_LEVELUP</Sound>
            <PromotionPrereq>PROMOTION_CITY_RAIDER2</PromotionPrereq>
            <PromotionLine>PROMOTIONLINE_CITYRAIDER</PromotionLine>
            <iLinePriority>3</iLinePriority>
            <iCityAttack>20</iCityAttack>
            <UnitCombatMods>
                <UnitCombatMod>
                    <UnitCombatType>UNITCOMBAT_GUN</UnitCombatType>
                    <iUnitCombatMod>10</iUnitCombatMod>
                </UnitCombatMod>
            </UnitCombatMods>
            <UnitCombats>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_ARCHER</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MELEE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_SIEGE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_GUN</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_HITECH</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_DREADNOUGHT</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
            </UnitCombats>
            <Button>,Art/Interface/Buttons/Promotions/CityRaider3.dds,Art/Interface/Buttons/Promotions_Atlas.dds,7,2</Button>
            <iCaptureProbabilityModifierChange>5</iCaptureProbabilityModifierChange>
        </PromotionInfo>
        <PromotionInfo>
            <Type>PROMOTION_CITY_RAIDER4</Type>
            <Description>TXT_KEY_PROMOTION_CITYRAIDER4</Description>
            <Sound>AS2D_IF_LEVELUP</Sound>
            <PromotionPrereq>PROMOTION_CITY_RAIDER3</PromotionPrereq>
            <PromotionLine>PROMOTIONLINE_CITYRAIDER</PromotionLine>
            <iLinePriority>4</iLinePriority>
            <iCityAttack>25</iCityAttack>
            <UnitCombats>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_ARCHER</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MELEE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MOUNTED</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_SIEGE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_GUN</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_HITECH</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_DREADNOUGHT</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
            </UnitCombats>
            <Button>,Art/Interface/Buttons/Promotions/CityRaider4.dds,Art/Interface/Buttons/RoM_Promotion_Atlas2.dds,4,3</Button>
            <iCaptureProbabilityModifierChange>5</iCaptureProbabilityModifierChange>
        </PromotionInfo>

As if someone didn't check promotionlines unitcombats or something.

This case is now fixed on github.
 
Wouldn't it be better to enforce that rule by switching key and value - that is, specifying for each combat type which promotion line they had access to and up to which point?
 
tmv said:
Wouldn't it be better to enforce that rule by switching key and value - that is, specifying for each combat type which promotion line they had access to and up to which point?
Click to expand...
Definitely BETTER, but probably much HARDER as well.
Tag-wise, that is.
Again, hard-coded limitations exist in order to annoy the modders, loool!
 
tmv said:
Wouldn't it be better to enforce that rule by switching key and value - that is, specifying for each combat type which promotion line they had access to and up to which point?
Click to expand...
That's what is happening in the rules but not in the display code. I've never been too arsed to go in and fix it on the display coding since I don't see why its necessary we're trying to show ever promo a unit could possibly get in the pedia anyhow.
 
Thunderbrd said:
That's what is happening in the rules but not in the display code. I've never been too arsed to go in and fix it on the display coding since I don't see why its necessary we're trying to show ever promo a unit could possibly get in the pedia anyhow.
Click to expand...
This is irrelevant.

What he meant is this:
Spoiler :

Civ4BeyondSword 2021-04-18 18-26-08-89.png

Civ4BeyondSword 2021-04-18 18-26-01-13.png
Civ4BeyondSword 2021-04-18 18-26-02-22.png


As promotion line rank increases it should never gain new unitcombat.
Otherwise you are just adding promotion to unitcombats, that they can't get at first place.
City Raider III didn't have Mounted unitcombat, and I fixed it.
 
raxo2222 said:
As promotion line rank increases it should never gain new unitcombat.
Otherwise you are just adding promotion to unitcombats, that they can't get at first place.
City Raider III didn't have Mounted unitcombat, and I fixed it.
Click to expand...
THANKS!

Yeah, that was what I pointed out in the first place, when my own units bumped into it.
TECHICALLY, though, it's not impossible for a unit to UPGRADE to a different UnitCombat in some wonky way.
So you could eventually "force" units to have Promotions that they "officially" shouldn't be able to have.
But this is very RANDOM and impractical, to say the least.
In this (unfixed) case, a Mounted unit with CR2 could *somehow* upgrade to a Melee one, get CR3, then upgrade back to a Mounted one, and get the bugged CR4.
But this is pretty much "bugging out the bugs", lol, and absolutely NOT a normal "tactic" whatsoever.
On the other hand, you COULD (in a very FAR future) employ this TRICK for, dunno, Equipment and similar stuff.
Still, normal Promotions should NEVER work this way, period.
 
Somebody613 said:
THANKS!

Yeah, that was what I pointed out in the first place, when my own units bumped into it.
TECHICALLY, though, it's not impossible for a unit to UPGRADE to a different UnitCombat in some wonky way.
So you could eventually "force" units to have Promotions that they "officially" shouldn't be able to have.
But this is very RANDOM and impractical, to say the least.
In this (unfixed) case, a Mounted unit with CR2 could *somehow* upgrade to a Melee one, get CR3, then upgrade back to a Mounted one, and get the bugged CR4.
But this is pretty much "bugging out the bugs", lol, and absolutely NOT a normal "tactic" whatsoever.
On the other hand, you COULD (in a very FAR future) employ this TRICK for, dunno, Equipment and similar stuff.
Still, normal Promotions should NEVER work this way, period.
Click to expand...
Apparently Mounted weren't meant to get City Raider III, IV and V.

There are two systems mixed, causing bugs to appear.
 
Somebody613 said:
In this (unfixed) case, a Mounted unit with CR2 could *somehow* upgrade to a Melee one, get CR3, then upgrade back to a Mounted one, and get the bugged CR4.
Click to expand...
OH, I see why that becomes a problem... for this reason. lol. Except that SHOULD invalidate the CR3 when they then later lose the melee Unitcombat, leading to a retraining of both 4 and 3, though it might hang on to 4 since it would then think, since it's specified incorrectly in the xml directly on the CR 4 promo, that THAT should be valid so keeps it despite CR3 being made invalid. A loop was removed in the invalidation checks that was intended to fix that - the modder who removed it I think just thought it was an unnecessary redundancy.
 
Is the forest fire feature supposed to destroy lumbermill improvements? I have 3 lumbermills that randomly disappear at times, I get no notification about being pillaged. They are just are gone.

Edit: Never mind, figured out it is burglars pillaging. I forgot there is no notification for some criminal units pillaging.
Click to expand...
This would be beneficial to note on a bug log on git.
 
You must log in or register to reply here.

Similar threads

raxo2222
  • Sticky
Single Player bugs and crashes v43 plus (SVN) - After January 2023
33 34 35
Replies
683
Views
33K
jherek79
J
raxo2222
  • Sticky
Single Player bugs and crashes v43 download - After January 2023
2 3 4
Replies
73
Views
6K
JosEPh_II
JosEPh_II
raxo2222
  • Sticky
Multi-Player Bugs and Crashes, v43 & SVN after January 2023
Replies
4
Views
994
Thunderbrd
Thunderbrd
raxo2222
Single Player bugs and crashes v42 plus (SVN) - After April 2022
30 31 32
Replies
628
Views
35K
Somebody613
S
raxo2222
Single Player bugs and crashes v42 download - After April 2022
2 3
Replies
51
Views
5K
ATARi144kHz
ATARi144kHz
Top Bottom