It worked for me, I've attached a save with one turn later.
Use Windows vista SP2 compatibility if using Windows 7.
Thanks! Made it a couple more turns from that, hope it stays that way. Looks like a "me" problem all along then.
Using Linux, with Steam+proton. Never had issues with repeatable crashes on v42.
You are using the Beta Steam version I hope. It is the Unaltered version that this Mod is compatible with. Steam's main version has been altered by Steam. Can and will cause weird problems.
Fixed on git, since we are breaking saves on git we do not plan to update SVN in the immediate future unless people call for it and are ok with SVN breaking saves in two or more consecutive versions.
I am now, thanks!
Ok, fixed in v43.1.1 patch: https://forums.civfanatics.com/threads/v43-1-patch-changelog.681675/
void CvPlot::setCulture(PlayerTypes eIndex, int iNewValue, bool bUpdate, bool bUpdatePlotGroups)
{
PROFILE_FUNC();
FASSERT_BOUNDS(0, MAX_PLAYERS, eIndex);
if (iNewValue == 0 && getPlotCity() && getOwner() == eIndex)
{
FErrorMsg("Trace: Attempting to set plot culture to zero for player that owns the city on the plot");
iNewValue = 1;
}
if (getCulture(eIndex) != iNewValue)
{
std::vector<std::pair<PlayerTypes, int> >::iterator itr;
// Blaze - 24.8.22 - This overflow protection shouldn't be needed with change to make culture
// in equilibrium states, rather than rising infinitely.
// Toffer - 08.08.20
// 4 byte integer overflow protection
if (iNewValue > 1000000000) // trigger reduction at a billion
{
// This player may not yet be in the vector if it goes from 0 to a billion in one go through worldbuilder or something.
iNewValue /= 10; // So we do this outside the vector loop.
// Reduce culture by same factor for all players
for (itr = m_aiCulture.begin(); itr != m_aiCulture.end(); ++itr)
{
if ((*itr).first != eIndex)
{
(*itr).second /= 10;
}
}
// This overflow protection will start to break down if a plot is getting 900 million+ culture from a specific player per turn.
// it reduce 1 billion+ down to 100 million+, this should be an adequate overflow protection in this case.
}
// ! Toffer
[...]
That bit you found is probably not responsible (divides by 10 not 100, and should impact all), but I believe there is another setCulture100 style code used elsewhere that could be responsible. My comment is outdated too lol because equilibrium is now an option.
Thanks for pointing me at the developer guide.
decayCulture() method.void CvPlot::decayCulture()
[...]
setCulture(
ePlayerX,
std::max(
getPlotCity() && getOwner() == ePlayerX ? 1 : 0,
// default: current culture * 90% then - 1
getCulture(ePlayerX) * (1000 - decayPermille) / 1000 - decayFlat
),
// Don't need to update borders, update culture is called next in doCulture
false, false
);getCulture(ePlayerX) / 1000 * (1000 - decayPermille) - decayFlatdecayCulture() method was removed, but I assume it's still affected by the same problem:void CvPlot::doCulture()
[...]
if (getCulture(ePlayerX) > 0)
{
if (GC.getGame().isOption(GAMEOPTION_CULTURE_EQUILIBRIUM))
{
// By limiting decay to avoid 2+ -> 0, we can ensure that putting 2 culture on a tile will always be above 1 turn decay
const int iIsOverOne = getCulture(ePlayerX) > 1;
if (isInCultureRangeOfCityByPlayer(ePlayerX))
{
setCulture(ePlayerX, std::max(iIsOverOne, getCulture(ePlayerX) * (1000 - decayPermille) / 1000), false, false, true);
}
// Decay 15x faster (to 45% at default speeds) if outside of city control in equilibrium, since we can't immediately set to unowned when negative
else
{
setCulture(ePlayerX, std::max(iIsOverOne, getCulture(ePlayerX) * (1000 - 15 * decayPermille) / 1000), false, false, true);
}
}
else if (getCultureRateThisTurn(ePlayerX) < 1 && (!getPlotCity() || getOwner() != ePlayerX))
{
setCulture(ePlayerX, std::max(0, getCulture(ePlayerX) * (1000 - decayPermille) / 1000), false, false, true);
}
}Tl;dr: Civ4 was written before stackoverflow was a thing, did not have a good codebase to begin with, then add on a decade and a half of hobbyist coders.... don't necessarily take any structure here as 'good'. See the bolded text here lol... https://github.com/caveman2cosmos/Caveman2Cosmos/wiki/CPP-Style-Guide
github.com
{
const int decayPermille = GC.getTILE_CULTURE_DECAY_PERCENT() * 1000 / GC.getGameSpeedInfo(GC.getGame().getGameSpeedType()).getSpeedPercent();
for (int i = 0; i < MAX_PLAYERS; i++)
{
const PlayerTypes ePlayerX = static_cast<PlayerTypes>(i);
if (getCulture(ePlayerX) > 0)
{
if (GC.getGame().isOption(GAMEOPTION_CULTURE_EQUILIBRIUM))
{
// By limiting decay to avoid 2+ -> 0, we can ensure that putting 2 culture on a tile will always be above 1 turn decay
const int iIsOverOne = getCulture(ePlayerX) > 1;
if (isInCultureRangeOfCityByPlayer(ePlayerX))
{
int64_t iCulture64 = getCulture(ePlayerX);
setCulture(ePlayerX, std::max(iIsOverOne, static_cast<int>(int64_t(getCulture(ePlayerX)) * (1000 - decayPermille) / 1000)), false, false, true);
}
// Decay 15x faster (to 45% at default speeds) if outside of city control in equilibrium, since we can't immediately set to unowned when negative
else
{
setCulture(ePlayerX, std::max(iIsOverOne, static_cast<int>(int64_t(getCulture(ePlayerX)) * (1000 - 15 * decayPermille) / 1000)), false, false, true);
}
}
else if (getCultureRateThisTurn(ePlayerX) < 1 && (!getPlotCity() || getOwner() != ePlayerX))
{
setCulture(ePlayerX, std::max(0, static_cast<int>(int64_t(getCulture(ePlayerX)) * (1000 - decayPermille) / 1000)), false, false, true);
}
}
}
}
