1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

YnAMP sub-project: True location corresponding city names

Discussion in 'Yet (not) Another Maps Pack' started by rock_and_ride, Nov 23, 2016.

  1. Gedemon

    Gedemon Modder Moderator

    Joined:
    Oct 4, 2004
    Messages:
    9,271
    Location:
    France
    Thanks, merged :)
     
  2. SeelingCat

    SeelingCat Warlord

    Joined:
    Oct 27, 2016
    Messages:
    107
    Gender:
    Male
    Location:
    US
    Play Europe Again should be finished now!
     
    Gedemon likes this.
  3. Gedemon

    Gedemon Modder Moderator

    Joined:
    Oct 4, 2004
    Messages:
    9,271
    Location:
    France
    many thanks !
     
  4. Gedemon

    Gedemon Modder Moderator

    Joined:
    Oct 4, 2004
    Messages:
    9,271
    Location:
    France
    Project Status edited, feels great to write 'complete" there, twice :goodjob:
     
    Giffica and SeelingCat like this.
  5. Giffica

    Giffica Chieftain

    Joined:
    Oct 27, 2014
    Messages:
    32
    Wow great work on this, come far.
     
  6. Xefjord

    Xefjord Prince

    Joined:
    Jul 17, 2015
    Messages:
    310
    Gender:
    Male
    I would love to see The Greatest Earth Map covered, as right now it seems to be the most stable version to play on. But as said, it is pretty much a whole new project. What do we need to get started? Is anyone willing to volunteer to help with it here? I would be willing to potentially help cover East Asia (although I only have experience doing the alternate city names for East Asian civs, not the original city names)
     
  7. SeelingCat

    SeelingCat Warlord

    Joined:
    Oct 27, 2016
    Messages:
    107
    Gender:
    Male
    Location:
    US
    We're currently waiting on some changes to the map to go through before doing names for the Greatest Earth map but feel free to take whatever area you'd like!
     
  8. krmarci

    krmarci Chieftain

    Joined:
    May 1, 2019
    Messages:
    56
    Gender:
    Male
    Location:
    Hungary
    Where can I find the files? I have registered to GitHub as asked in the first post, but the link of the original project is missing.

    EDIT: found the link on page 18.
    EDIT2: I want to add city name translations for Hungary. Do I have to add for example:
    <Replace Tag="LOC_CITY_NAME_BAIA_MARE_HUNGARY" Text="Nagybánya" Language="en_US" />
    to the GamePlayText.xml? Is that correct? Do I have to add anything else to make it work?
    EDIT3: I would also like to add Turkish names for some cities (limited to historical Hungary). Should I use the ending tag _TURKEY or _OTTOMAN or something else?
    EDIT4: I see that some city names overlap. How is it determined which one is used?
     
    Last edited: Jun 2, 2020
  9. krmarci

    krmarci Chieftain

    Joined:
    May 1, 2019
    Messages:
    56
    Gender:
    Male
    Location:
    Hungary
    @Gedemon I have made a pull request. I added many Hungarian names for cities, and changed some tiles in and around Hungary. However, I could not get the game to display the Hungarian names when playing as Hungary.
     
    AbsintheRed likes this.
  10. SeelingCat

    SeelingCat Warlord

    Joined:
    Oct 27, 2016
    Messages:
    107
    Gender:
    Male
    Location:
    US
    Sorry for the delay in responding! That should be the correct format. The Ottoman ending should be _OTTOMAN i believe - it needs to match whatever the civilization is called in the game files. I'll take a look at the pull request and see about getting them added/see why they're not working. In the meantime, I might suggest trying my Rosetta mod, which is compatible with YnAMP.
     
  11. krmarci

    krmarci Chieftain

    Joined:
    May 1, 2019
    Messages:
    56
    Gender:
    Male
    Location:
    Hungary
    Thanks, I'll take a look at Rosetta!
     
    Last edited: Jun 3, 2020
  12. krmarci

    krmarci Chieftain

    Joined:
    May 1, 2019
    Messages:
    56
    Gender:
    Male
    Location:
    Hungary
    @SeelingCat I think I might have found the problem: I had both the Steam Workshop subscribed version of YnAMP, as well as my edited version in the mod folder. Even though I started my edited version, the original version overrode it. I removed the subscription and the Hungarian names show up.
     
    Last edited: Jun 4, 2020
  13. Gedemon

    Gedemon Modder Moderator

    Joined:
    Oct 4, 2004
    Messages:
    9,271
    Location:
    France
    Can I merge your pull request then ?
     
  14. krmarci

    krmarci Chieftain

    Joined:
    May 1, 2019
    Messages:
    56
    Gender:
    Male
    Location:
    Hungary
  15. Gedemon

    Gedemon Modder Moderator

    Joined:
    Oct 4, 2004
    Messages:
    9,271
    Location:
    France
    There is another issue, sorry, the CityMap file is not in the correct folder, I can't compare and merge it that way.
     
  16. krmarci

    krmarci Chieftain

    Joined:
    May 1, 2019
    Messages:
    56
    Gender:
    Male
    Location:
    Hungary
    The first post said that I should put all files under Gameplay.
    Anyway, I moved the file to the correct folder (more exactly, I deleted the old file and moved the new file to its location). I'm not sure if I have to do a new pull request.
     
  17. Gedemon

    Gedemon Modder Moderator

    Joined:
    Oct 4, 2004
    Messages:
    9,271
    Location:
    France
    Yes please, and I'll have a look at the OP
     
  18. krmarci

    krmarci Chieftain

    Joined:
    May 1, 2019
    Messages:
    56
    Gender:
    Male
    Location:
    Hungary
    I created a new pull request.
     
  19. Gedemon

    Gedemon Modder Moderator

    Joined:
    Oct 4, 2004
    Messages:
    9,271
    Location:
    France
    thanks a lot, merged !
     
  20. krmarci

    krmarci Chieftain

    Joined:
    May 1, 2019
    Messages:
    56
    Gender:
    Male
    Location:
    Hungary

Share This Page