3rd and 4th Unique Components for VP - Official thread 88.10

[Gokudo01]

I really think the code needs an optimisation pass : many players can't handle the extra processing needed between turns.

 

[pineappledan]

Yes, that's what we are doing

I just added Civilization checks to Carthage and Arabia. You already had updated America, and everything up to Egypt, so I think that does it for the first pass of optimizations

 

[adan_eslavo]

We're trying to make this mod less resource hungry. We did that few times but now we decided its right time to do that for serious. This update should lower that factor by 1/3 I suppose. But even then it will be heavy mod. Some luas must be performed. Where we could we put sqls instead. I will spend few days on checking luas one by one. We have few another ideas of simplification. Will be good. I told all of you that this update gonna be huge. And will be indeed.

If you have another UCs tweak suggestions tell us now. It is the right time for discussion.

I try to update github changelog for everyone to be up to current changes. You can see there what was done. We are open to suggestions.

We do not rush this update. Current v36 is somehow stable and that allows us to focus on major changes without time pressure.

 

[pineappledan]

It seems Portugal has a duplicated feature in both lua and SQL, unless I'm not understanding something?

University of Coimbra has a FreePromotion = PROMOTION_UNIT_PORTUGAL_AGE_OF_DISCOVERY. It also has a lua function, OnConstructionAddPromotion. Is there any reason to suspect that the Lua isn't just a repetition of the SQL?

 

[adan_eslavo]

Maybe sql is not able to give promotion to right unitcomatclass. Probably you have tried to convert it to sql, didn't work and maybe you forgot to delete it? The best way is to comment that part, check sql code and eventually delete it. I think that lua part can be cut. It is some relict.

 

[FoxOfWar]

Got my America game far enough to test Monitor... and it is GOOD. Hardened and double movement on coast are both promotions that don't seem much... but they really are. You can keep your coasts defended for nigh-on-forever, because your ships can be anywhere within turn or two(and that's without Grand Canal or Great Lighthouse...), and don't need to spend much time at all healing. (Due to my early aggressive expansion, I've been in near-constant wars ever since people could cross oceans...)

Of course, Monitor has plenty of potential to be used in scary offensive too, only slightly hindered by the slow(ish) ocean crossing.

All in all, I think both American UC's are in a good place.

 

[adan_eslavo]

Why didn't you use sql for tersane's Prize Ships promotion? Was that because of that Sea Beggar check?

 

[pineappledan]

I believe the tersane lua was done so that the promotions wouldnt be applied retroactively to any ship that had been built in that city, but only on a going forward basis.

If we are interested in simplifying this, then we can just apply it via sql instead.

 

[adan_eslavo]

So sql does it for all units and lua only for those trained after its construction? What was the first intention?

 

[pineappledan]

So sql does it for all units and lua only for those trained after its construction? What was the first intention?

yeah, I think that was the idea. SQL can't assign promotions only on a going forward basis

 

[adan_eslavo]

So do we leave it as it is?

 

[Ziad]

We indeed don't know what the Bayt al-Hikma looked like, and we are not even sure what exactly it was (it could have taken a lot of forms)... Do you have any info on that @Ziad ?
.

Sorry not very familiar with historical Muslim architecture, although based on what little of it there is back home I'd imagine it has a lot of arches and open spaces.

So when I googled it, the first few images I saw seemed reasonable choices.

 

[adan_eslavo]

What is the factor determining which building can be sold from city? I'm asking because I thought Waag can be sold and it didn't so no additional code is needed.

Yestarday I pushed one update with Waag. I totally reworked the code making possible iteration number lower. Today I pushed another update to its code.

 

[CppMaster]

What is the factor determining which building can be sold from city?

IIRC if a building has maintenance cost then it can be sold.

 

[Enrico Swagolo]

IIRC if a building has maintenance cost then it can be sold.

Not always, Circus costs gold per turn and cannot be sold. Back in the day it used to be otherwise and Jelling Stones even lost +instant Culture so they wouldn't be abused by building/rebuilding but then such a thing was introduced

 

[adan_eslavo]

So there's some table value determining that, right? Maybe we should consider tweaking that value for some of new UCs as well.

 

[pineappledan]

There are only 2 things that should be made unsellable, I think:

• Shoshone Buffalo pound (new buffalo resource every time it is built)
• Egypt Nilometer (2 new Flax every time it is built)

 

[adan_eslavo]

I'm curious only how to do it. I cannot find any appropriate value in sql tables...

EDIT: I made Riad "simplification" and fix. Number of iterations is simplified, but code do not looks like simple . Yassa Court also fixed.

What about Tersane @pineappledan? Do we leave it or change its functioning by using sql?

 

[pineappledan]

May as well change it, I think.

With the added distance, I feel like maybe those decisions to make the tersane complicated like that came from being too close to all these things while we were making them. We wanted everything to be soooo special and soooo unique, but in the Tersane's case I think we made have made something arbitrarily different for no reason, which will only get us complaints from other users.

I’ve got the same feeling re the university of Coimbra too. The more it works like the Arsenale di Venezia and the grande canal, the more people will like it. We made arbitrary mechanics which are only different from existing ones in the most annoying way possible. We should have realized we were just going to confuse people and make more needless lua for ourselves.

 

[adan_eslavo]

I put another update to Github. I mostly added same restrictions for few buildings with similar mechanics: Paradise Garden, Chaebol, Pitz Court, Riad, Waag and Baan Chang so far. They use loop through all cities, look for unique building and add yields or dummies. I added check if there is any of unique building, break command if last of unique was found, moved some declarations up and split notifications for Baan Chang, Pitz Court and Paradise Garden.

With so many changes, check is advised. If someone could do that I would be grateful.