CivUP v26: Trade screen broken

[Zarggg]

After a seemingly-arbitrary number of turns (usually after 100 turns, but most recently on turn 78), the Trade screen of the new Diplomatic Overview displays only one civilization, regardless of how many I have currently met, and does not display city-states at all. I have no idea what could be triggering this.

This was originally reported by zarakand in this post, but I do not see that a separate thread was made for it, as was requested of him in the thread.

This occurs even when CivUP is the only mod installed.

 

[heinous_hat]

Seconded.

Had the same behavior in v25. Thanks for confirming that it's internal. I was looking for a conflict with other UI mods.

 

[Thalassicus]

Could you post your lua.log file after the problem occurs? Thanks!

 

[heinous_hat]

Could you post your lua.log file after the problem occurs? Thanks!

I'll post one over in Bug Reports after I manage to recreate the problem in a fresh game with just cUP. Current log output is fat with entries from Gedemon's mods.

 

[Zarggg]

Oops. I completely forgot to do that. Here's a quick one I just did. It looks like it took effect right after I completed mutual embassy deals with all the civs I met so far.

 

[Thalassicus]

Thank you, that led me straight to the problem! I'm thinking about that block of code, but running out of free time and might need to finish this in the evening. It should be easy to fix once I find the root cause of the problem.

Edit: I figured it out. I was attempting to retrieve the final turn for embassy deals, which last forever. I've fixed the problem for v27. Thank you for the helpful bug report!

If you want to fix this problem in your current game, simply open this file:
/civup/interface/trade/DiploTradesStatus.lua

delete line 448:

turnsLeft = dealTable[TradeableItems.TRADE_ITEM_ALLOW_EMBASSY][targetPlayerID][1].finalTurn - Game.GetGameTurn()

That should solve the problem.

 

[Zarggg]

Looks like it did. Reloaded my last save after deleting that line, and the window displays as normal.

 

[Thalassicus]

Thank you for the confirmation. I've uploaded civup v27, which should fix this and another problem with the trade window (tooltips for non-mutual embassies were switched).

 

[Zarggg]

It looks like the change was not actually made. The line still exists in the copies of v27 I retrieved from both this forum and Steam Workshop.

 

[skodkim]

Agreed. The line is still there in v27

Haven't tested ingame though.

\Skodkim

 

[[to_xp]Gekko]

I can confirm the bug is still present in civup 27 and deleting the line above fixes the issue.

 

[Thalassicus]

How weird, I'm absolutely certain I deleted the line! Oh well, it should be gone now. Maybe I forgot to save the file last time?