Classic case is something like the Hanging Gardens. The food and the Garden are restricted to the 1 city. This is well understood because local yields are annotated in a universally recognizable way, and the free Garden explicitly says "in this city"
Temple of Artemis has a global +10% food, and then says "+15% production towards archery units". This is difficult to understand because there are numerous policies and beliefs which provide bonuses to miliary unit production, and they affect the entire empire. Those policies do not explicitly say "in all cities" or "on empire", and neither does ToA. Furthermore, pairing the local bonus production with a global bonus food, and explicitly saying the food is global, but saying nothing about whether the production is local or global, makes a reader interpret both bonuses as global.
In other words:
- This problem is specific to military unit production bonuses, because global bonuses of that type are given elsewhere using the same annotation
- This problem is exacerbated by the wording of ToA's other effect, which undermines a user's ability to comprehend the building as not being strictly a global modifier.
So yeah, at a minimum, the help text needs to be more clear. Knowing now that the bonus production to archery units is only in that city, I would imagine that boosting that to +25% would be more than fair, but the global food bonus and free herbalist are what people build that wonder for.
I opened a ticket 15 hours ago on this subject. Last time I suggested a minor change to the DLL I had to make the change multiple times because branches were merged out of order. Someone with more free access to the github should make the change, because that convinced me that making my own pull requests isn't worth the hassle, unless I'm going to make several changes at once.
You're describing vanilla buildings, though - don't make this out to be a bug with VP, it's a change from vanilla descriptions. Let's just be clear on that. I'm happy to look at it, but there's a lot of grief being thrown around for what are vanilla holdovers.
Re: Github, your branch was out of date, I'm sorry that it caused problems but don't blame the master branch if your fork isn't up to date!
G