[Feature] Turkic Civilization

[Steb]

I made a pull request for Turkic GP names yesterday, but I figured I should maybe post them here in case people are curious.

iCivTurks : {
    iGreatProphet : [
        "Tatpar Qaghan", # 6th
        "Bulan", # 9th
        "Abu Mansur al-Maturidi", # 9th
        "Al-Ghazali", # 11th (also Persian)
        "Ahmad Yasawi", # 12th
        "fFatima al-Samarqandi", # 12th
        "Haji Bektash Veli", # 13th
    ],
    iGreatArtist : [
        "Yusuf Balasaguni", # 11th
        "Suzani Samarqandi", # 12th
        "Nizami Ganjavi", # 12th (also Persian)
        "Rumi", # 13th (also Persian)
        "Izzeddin Hasanoglu", # 13-14th
        "Imadaddin Nasimi", # 14th
        "Alisher Nava'i", # 15th
        iRenaissance,
        "Khasta Qasim", # 18th
        "Magtymguly Pyragy", # 18th
        iIndustrial,
        "Qurmangazy Sagyrbaiuly", # 19th
        "Abai Qunanbaiuly", # 19th
        "fNodira", # 19th
        iGlobal,
        "Hamza Hakimzade Niyazi", # 20th
        "G'afur G'ulom", # 20th
        "Chinghiz Aitmatov", # 20th
    ],
    iGreatScientist : [
        "Al-Farabi", # 10th (also Arab)
        "Ismail ibn Hammad al-Jawhari", # 10th
        "Ibn Sina", # 10th (also Persian)
        "Omar Khayyam", # 11th (also Persian)
        "Mahmud al-Kashgari", # 11th
        "Nizami Aruzi", # 12th
        "Qadi Zada al-Rumi", # 14th
        "Jamshid al-Kashi", # 15th
        "Ulugh Beg", # 15th (also Mongol)
        "Ali Qushji", # 15th (also Ottoman)
        iIndustrial,
        "Shoqan Walikhanov", # 19th
        iGlobal,
        "Kasym Tynystanov", # 20th
    ],
    iGreatMerchant : [
        "Muqan Qaghan", # 6th
        "Sheguy", # 7th
        "Ahmad ibn Rustah", # 10th
        "Bar Sauma", # 13th
        "Yahballaha", # 13th
    ],
    iGreatEngineer : [
        "Omurtag", # 9th
        "Abu-Mahmud Khojandi", # 10th
        "Al-Biruni", # 11th
        "fSaray Mulk", # 14th
        iGlobal,
        "Kanysh Satbayev", # 20th
    ],
    iGreatStatesman : [
        "Ishbara Qaghan", # 6th
        "Ashina Simo", # 7th
        "Nizam al-Mulk", # 11th
        "fTerken Khatun", # 11th
        "Aq Sunqur al-Hajib", # 11th
        "Abd-al-Razzaq Samarqandi", # 15th
        "Muhammad Shaybani", # 15th
        iRenaissance,
        "Abdullah Khan", # 16th
        iIndustrial,
        "Alikhan Bukeikhanov", # 19th
        iGlobal,
        "Sopubek Begaliev", # 20th
    ],
    iGreatGeneral : [
        "Tong Yabghu Qaghan", # 7th
        "Qapaghan Qaghan, # 7th
        u"Kültigin", # 8th
        "Tughril", # 11th (distinct from Mongol Toghril)
        "Anushtegin Gharchai", # 11th
        "Nur ad-Din Zengi", # 13th (also Arab)
        "Uzun Hasan", # 15th
        iRenaissance,
        "Ablai Khan", # 18th
        "Raiymbek Batyr", # 18th
        iGlobal,
        "Sobir Rakhimov", # 20th
    ],
},

 

[Leoreth]

That looks great, thanks! I was really busy yesterday so I completely missed the pull request so far. Also thanks for keeping track of the overlap in the comments.

I am currently chasing some general bugs in the DLL while fixing another issue, so I'll probably push those first and you might need to have to rebase on that again before I can merge the pull request.

 

[ales_]

Yeah, I think they're different enough from everything else to warrant being their own thing. In particular their whole migration to Pakistan/India itself could make for interesting gameplay, and they had a unique relationship to Buddhism and Greek culture that would be nice to represent in some way.

Especially considering there's a Kushan civ in History Rewritten.

 

[Steb]

Why the color changes? I'll need to check in game to see how it looks, but I'm not sure why you changed the Greek color. I liked their blue a lot... Also I feel like the Seljuks' color would have been fine for the Turkic civilization as a whole.

I take that back, the Greeks' silvery blue color looks very elegant for them, and I like that the Babylonians have reverted to their original Civ4 color.

 

[Leoreth]

Nice that it grew on you.

 

[DC123456789]

Opening the victory screen on Epic gives a Python exception and gives a broken screen (but not on Normal).

 

[DC123456789]

Getting a crash on this save, when you press next turn. I'm using the Turks feature branch for this (latest Git commit).

 

[Leoreth]

Please report issues from feature branches in their corresponding threads.

 

[Leoreth]

New update:
- fixed a Python error
- count Turkic pillages
- Turkic AI flips barbarians even when they only enter their territory

Rebased on the latest develop branch.

 

[Leoreth]

Rebased the branch again.

 

[FinalLegendZero]

Goals now checking properly, and pillaging is properly counted, but the trade route from Jerusalem to China still isn't being recognized. Save provided (WB'd as the game was being run solely to test the UHV).

 

[Steb]

I tried rebasing my pull request but got a conflict in the dll. Please feel free too simply copy the names into the GP file yourself.

 

[Leoreth]

I tried rebasing my pull request but got a conflict in the dll. Please feel free too simply copy the names into the GP file yourself.

Alright, I'll see how I'll do it.

Edit: I'll take care of this, but for future reference:

If you use "git rebase" (as you should) then git will first rewind to the last correct state of the branch you're rebasing on, and then apply your commit(s) on top of that. A conflict will only arise when your commits are applied. The DLL is a binary file which git cannot automatically merge, so it will always create a conflict. Since you did not change the DLL, you want to use "my" DLL, which you can do with

git checkout --ours Assets/CvGameCoreDLL.dll
git add Assets/CvGameCoreDLL.dll
git rebase --continue

It is "ours" in the sense that it comes from the commit that's already there as opposed to coming from your commit that is currently being merged (this is a bit confusing terminology when you are rebasing). If you actually did compile a DLL in this commit, do "git checkout --theirs Assets/CvGameCoreDLL.dll".

Just to explain the checkout command, in case of a conflict it will only use the state of the existing or currently merged commit, depending on the parameter.

Note that if you use "git merge" (which I discourage) everything will be reversed. "My" commits will be the ones being merged and yours the ones that already exist, so git checkout --theirs picks the state I have created.

 

[Leoreth]

Merged a pull request by Steb: Turkic GP names

 

[TJDowling]

I'd say Timurids should come from a respawn of the Turks. The Mongol legacy is there but the region is more Turkic than Mongol. I'm not sure if this has been answered but how will the Timurids, Mughals and Iranians occupy the same space if all exist at the same time. I guess the core of the Turks will revert back upon spawn of the Iranians? Or will Iran become a conditional spawn?

 

[DC123456789]

I'd say Timurids should come from a respawn of the Turks. The Mongol legacy is there but the region is more Turkic than Mongol. I'm not sure if this has been answered but how will the Timurids, Mughals and Iranians occupy the same space if all exist at the same time. I guess the core of the Turks will revert back upon spawn of the Iranians? Or will Iran become a conditional spawn?

Iran spawns/respawns right around when the Timurids are meant to collapse (not a coincidence, obviously ). I don't think the Mughals are meant to be much involved in Persia, and vice versa for the Timurids and India.

 

[Leoreth]

I'm also coming down as Timur as a Turkic leader and the Timurid Empire as a Turkic respawn or dynamic name. The continuity between the Timurids and Mughals will not really be represented in DoC, because the Mughal civ is a greater umbrella civ for all of Muslim Persianate India. So in conclusion, Timurids and Iran won't really coexist, since the Iranian respawn essentially forces them out of their core (their are historical Timurid successor states in Transoxania where their core could revert and whose dynamic names they could receive). Timurids and "Mughals" can coexist, e.g. in the shape of the Sultanate of Delhi. It probably makes sense to only enable the Mughal dynamic name while the Timurids no longer exist.

 

[Leoreth]

New update: fixed the Silk Route goal

 

[TJDowling]

I'm also coming down as Timur as a Turkic leader and the Timurid Empire as a Turkic respawn or dynamic name. The continuity between the Timurids and Mughals will not really be represented in DoC, because the Mughal civ is a greater umbrella civ for all of Muslim Persianate India. So in conclusion, Timurids and Iran won't really coexist, since the Iranian respawn essentially forces them out of their core (their are historical Timurid successor states in Transoxania where their core could revert and whose dynamic names they could receive). Timurids and "Mughals" can coexist, e.g. in the shape of the Sultanate of Delhi. It probably makes sense to only enable the Mughal dynamic name while the Timurids no longer exist.

Yeah, it would probably be best if the Turkic core reverts back in case anyone wants to continue playing past Iranian spawn. That said, it wouldn't be very interesting to keep playing past that point. Though, it's more interesting for Iran/Russia if there isn't a total collapse, provides more of a challenge to expanding into the Turkic region. As it is, usually Iran conquers the independent cities very quickly.

 

[KeeperOT7Keys]

I think Iranian spawn now should be conditional depending on the Turkic Civ. Historically even Safavids were a Turkic dynasty and Iran was ruled by Turks until 1925~. And gameplaywise it renders useless to conquer Iran for human player if it's going to get spawn anyway.
This way when Turkic Civ becomes destabilized a new/native "Iranian" dynasty can be found in Iran, and Turkic civ can still exist as a threat to Iran, like the Uzbeks for example.
However I believe this would require a change in Iranian UU since it can become useless in most cases, a UU representing "Gunpowder Empire" would fit nicee imho. While jumping randomly on Wikipedia I found this: Zamburak a weapon used extensively in Nader Shah's campaigns who is probably the greatest Iranian military leader/ruler.