Military Doctrines / Promotion System Rework 1.703

[Ewok-Bacon-Bits]

Ok so hopefully this update solves the issue you guys were having which was other mods giving free promotions (I think). It gets rid of the promotion option which isn't needed in this mod as your units will automatically promote. And you can choose doctrines in the doctrine panel which is in the top left there with the great people/tech/civic options. Note that any unit that does give the free promotion will automatically give all the veterancies.

 

[Puer]

There is a small issue if units gets experience from goody hut - no promotion was added (see the pic: 38/25 until level next veterancy).

Next veterancy was added few turns later, once same unit attacked barbarian and won the battle.

Thanks for CQUI and Quo's Combined Tweaks compatibility!

 

[Ewok-Bacon-Bits]

Ok it doesn't check XP unless after combat or upon turn end. But there is a game event for goody huts so I'll add that in, thanks!

 

[Ewok-Bacon-Bits]

Ewok-Bacon-Bits updated Military Doctrines / Promotion System Rework with a new update entry:

Checks unit XP after finding a goody hut

- Checks unit XP after finding a goody hut

- Corrected a grammer error

Read the rest of this update entry...

 

[Puer]

Few UX suggestions more:

It would be nice to separate most important text from less important.
Also I think the background color is too bright and this makes hard to read.

For example something like this:

VS

 

[Ewok-Bacon-Bits]

The first thing I definitely plan to do perhaps highlighting it in a green?

The second thing, it looks like your having a similar problem as someone else the background should be the paper texture (not that eye-piercing red) just like out of the civics/tech screen. I'm not sure what is causing this because I can't seem to replicate it. Do you have any other mods? Also is it possible you could post your lua log.

 

[Puer]

Mods I'm using:

• cqui
• Military Doctrines
• Quo's Combined Tweaks
• Research Reminder
• Smoother Difficulty

Lua log (7z self-extract exe): https://mega.nz/#!pLYgRaAY!o9x0mqTgqPjrDTC-6hpAv2gNXTJe5DvRDfMbtMcHetE

Highlighting in a green is good idea

Edit: I uploaded all my mods also here (7z exe 1 click unpack): https://mega.nz/#!UXZjELAD!Ii8A00QpUylAAtngQTQwP4LrgUuYsbq4eNu3vMzyCbs

 

[Ewok-Bacon-Bits]

Ewok-Bacon-Bits updated Military Doctrines / Promotion System Rework with a new update entry:

Possibly fixed a bug that made the background turn red

- Possibly fixed a bug that made the background turn red

Read the rest of this update entry...

I did find errors and I *think* I fixed them for some reason it was getting nil in combat but now it accounts for it.

Thanks for all that^!

 

[Puer]

v1.22:

 

[Ewok-Bacon-Bits]

Ok could you upload the saved game?

 

[Puer]

Savegame: https://mega.nz/#!AXAkESwA!V2Zq-ZT4-moHYEQHD-Y40Vhp5FK4uZQPP-SBWNdap9Q

 

[Ewok-Bacon-Bits]

Ewok-Bacon-Bits updated Military Doctrines / Promotion System Rework with a new update entry:

Fixes red screen found in anything lower the dx 12

- Fixes the red background found in anything lower then dx 12

Read the rest of this update entry...

This should work now, I managed to replicate it. I was testing on dx12 every game but I was getting the red screen in normal civilization so I fixed this. It also shouldn't have that gap at the bottom anymore. Thank you for the save, hopefully it looks way better now.

 

[Puer]

Red background issue is now resolved (v1.23).
Indeed, it reproduced with DX11 before and did not reproduced with DX12 version (CivilizationVI_DX12.exe).

 

[skodkim]

Unfortunately the mod (v. 1.23) screws up the Apostle Promotions. As soon as an Apostle is built it gains all the standard promotions, etc. Regulars, Veterans...

Would really like to try this out but I'll wait for a fix.

Edit: Have tried fiddling with the files myself as I'm eager to start a new game with the mod, but unfortunately my lua skills are really bad

\Skodkim

 

[Ewok-Bacon-Bits]

Ewok-Bacon-Bits updated Military Doctrines / Promotion System Rework with a new update entry:

Removes veterancy from religious units and spies

- Removes veterancy from religious units and spies

Read the rest of this update entry...

Hopefully that works! You will need to go back to a save that hasn't already applied veterancy to units.

 

[skodkim]

You are the best!

Will test right away

\Skodkim

 

[skodkim]

Unfortunately it only soles it half-way. Apostles don't get the Veterancy anymore, but since the promotion button is removed you cant promote them with their usual system

(Used the Fire tuner to test by giving myself the appropriate techs/civics, a holy site, a shrine, a temple, a great prophet and found a religion).

\Skodkim

 

[Ewok-Bacon-Bits]

Ya unfortunately I had to take out promotions completely so that includes religious units and espionage units which aren't effected by doctrines. What I was thinking is possibly adding another branch that would include support that would give some doctrines to religious units. The other thing is trying to find a way to apply those promotions (because they still exist) through another method.

 

[skodkim]

Ya unfortunately I had to take out promotions completely so that includes religious units and espionage units which aren't effected by doctrines. What I was thinking is possibly adding another branch that would include support that would give some doctrines to religious units. The other thing is trying to find a way to apply those promotions (because they still exist) through another method.

I see. IMHO that's a pretty big sacrifice but on the other hand the Vanilla Promotion system really needs some love and your take on it seems really good.

I'll give the mod a try - see how much impact it has on the game. Then maybe you'll come up with some kind of solution for upcoming versions

A small plea: Could you please use the version numbering system in the modinfo file and/or in the name of the mod folder? This makes it much easier to see which version we have installed.

\Skodkim

 

[skodkim]

Another small issue: The mod is in current version (v1.24) incompatible with MOAR units mod. It's not that big an issue but since MOAR unis lets scouts, explorers, rangers, scouts and amazon scouts (some of these may be unique to MOAR units mod) start at level 2 they start with five veterancy levels.

MOAR_Units_Data.sql has the line below. The issue is solved by commenting this out.

UPDATE Units SET InitialLevel = 2 WHERE UnitType = 'UNIT_SCOUT' OR UnitType = 'UNIT_EXPLORER' OR UnitType = 'UNIT_RANGER' OR UnitType = 'UNIT_SNIPER' OR UnitType = 'UNIT_AMAZON_SCOUT';

\Skodkim

 

[skodkim]

Ok, sorry for spamming you. Id like to stress that I'm not trying to criticize you work, which I think is really coll, and you should just tell me to stop if you want! My problem here is that I really, really like what you're trying to do - I guess I just don't really agree with how it's implemented.

I like the idea that the promotions for the military units should be changed, but there's also other units that lose their ability to gain non-military promotions now, e.g. apostles, spies and scouts.

A suggestion (mind you, from a lua noob - it may not be as simple as it sounds).
The way it's implemented right now is - AFAIK - that you A) keep all vanilla promotions in the database, B) Prevent units from being promoted by removing the promotion action and C) automatically assign veterancy levels to units.

With v 1.24 you made a small change to the code so that certain units like apostles, spies etc. wont get veterancy levels.

Could this check for unit types be moved to the part of the code where standard promotions are chosen, i.e. so that you can chose promotions for the units you check for (e.g. apostles, spies, ...) while all other still have the ability to promote removed?

Just a thought...

\Skodkim